2648175275
Merge branch 'taiko-barline-separation' into taiko-fixes-combined
2022-11-07 18:32:09 +09:00
2b72c3833b
Remove unnecessary centering logic in DrawableJudgement
2022-11-07 17:19:32 +09:00
c69a4f9333
Move major barline portion to default implementation to allow for further customisation
...
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
...
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
566738494f
Merge pull request #20952 from OliBomby/bezier-convert
...
Add conversion algorithm for lazer slider curves to work with stable
2022-11-04 16:49:51 +09:00
ac554c644d
Merge branch 'master' into fix-slider-sv-snap
2022-11-01 13:19:46 +01:00
f014acfc8d
Fix DrawableHitObject.AccentColour not being updated if object entry is not attached
2022-11-01 19:34:53 +09:00
29bc653d24
Remove incorrect double multiplication and add missing test coverage
2022-11-01 17:17:54 +09:00
2a88409dfe
Fix time snap of sliders not matching when SV is not 1.0x
...
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.
Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.
The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
706adfb28c
Improve messaging when ruleset load fails
2022-11-01 13:57:34 +09:00
0461303895
Change return type to List
2022-10-31 11:39:41 +01:00
414e21c657
Added xmldoc to public methods
2022-10-31 11:39:14 +01:00
94dd4045f1
Remove borrowed framework code
2022-10-31 15:42:17 +09:00
31ba77e378
Merge branch 'master' into bezier-convert
2022-10-31 15:41:08 +09:00
a1a9238bd1
Use empty string instead of null because issue template not accept null.
2022-10-30 16:31:07 +08:00
505ec800da
File name should be nullable.
2022-10-30 16:29:54 +08:00
db48a57fa7
Remove nullable disable annotation in some checks class.
2022-10-30 16:28:49 +08:00
24c27e62f6
Remove nullable disable annotation in the issue and issue template-related class.
2022-10-30 16:25:15 +08:00
42eafe318c
Remove various simple obsoletions
2022-10-28 13:20:58 +09:00
86d5fcc26d
Added tests
2022-10-26 19:30:42 +02:00
77dcd0fae2
Create BezierConverter.cs
2022-10-26 17:21:20 +02:00
6b53ea3400
Enable distance snapping when DS value is changed via user interaction
2022-10-26 13:37:01 +09:00
7d59bc6e2f
Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap
2022-10-26 13:28:04 +09:00
54ae16badc
Move distance snap toggle button implementation to DistancedHitObjectComposer
2022-10-26 13:27:23 +09:00
8d9a85e9e5
Fix typos in xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-10-26 13:14:12 +09:00
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey
2022-10-25 20:32:32 +02:00
da93849b80
Rename some pieces and better document SampleBankInfo
2022-10-25 14:55:33 +09:00
2b850694fa
Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts
2022-10-25 14:10:45 +09:00
d0e6bda9ef
Stop HitObjectComposer from handling Shift+Number keys
2022-10-24 15:19:36 +09:00
f516e32949
Improve UI a bit
2022-10-21 23:35:53 +09:00
bb921ff9a7
Fix incorrect current DS value when inside a slider
2022-10-21 23:35:47 +09:00
f6de366766
Combine display and button into one control
2022-10-21 23:21:07 +09:00
645a84b1d6
Display current distance snap and add button to update to use it
2022-10-21 22:58:36 +09:00
7dc03097ff
Change distance snap to never account for slider velocity
...
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
6cdfddea62
Always enable distance spacing when adusting distance space multiplier
2022-10-21 16:10:55 +09:00
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
...
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
5c13c443ff
Fix incorrect fallback logic
...
Regressed when attempting to share implementation of binary search.
2022-10-20 23:08:44 +09:00
26860a903e
Refactor implementation to support hitobjects nested multiple levels deep
2022-10-20 22:30:30 +09:00
d237c818f6
Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
2022-10-18 16:15:21 +09:00
ec3761ced9
Standardise control point search logic in OverlappingScrollAlgorithm
...
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
2022-10-18 16:01:05 +09:00
860214c22a
Adjust paddings to feel better now that backgrounds are visible of toolboxes
2022-10-18 14:38:45 +09:00
6a7f6c76ff
Fix osu! editor padding being applied to toolboxes
...
The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.
2022-10-18 14:32:00 +09:00
ccbac08985
Merge pull request #20593 from ekrctb/catch-editor-height
...
Allow arbitrary height catch editor
2022-10-18 12:10:49 +09:00
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
32c3e35762
Change background colour to a lighter tint to avoid clash with slider bars
2022-10-14 19:38:27 +09:00
4d99c7002b
Add background behind editor toolbox groups
2022-10-13 16:36:19 +09:00
4fb156ef4e
Update xmlodc and add nullability attributes
2022-10-13 00:16:42 +03:00
7a6ecaff0d
Remove default invisible cursor container from rulesets
2022-10-12 17:50:47 +03:00
84fdd2e107
Improve flashlight display on break periods
2022-10-11 17:16:57 +03:00
