Commit Graph

22552 Commits

Author SHA1 Message Date
6c878cb167 Prevent nullrefs 2019-10-03 19:15:37 +09:00
662a1a9c2c Use current 2019-10-03 18:55:53 +09:00
4aeb5b520d Merge branch 'master' into fix-negative-key-counter 2019-10-03 18:52:08 +09:00
bcf0b2752e Fix possible MusicController nullref 2019-10-03 18:48:44 +09:00
b337a3793d Merge pull request #6375 from peppy/fix-carousel-test-failures
Fix random failures on BeatmapCarousel filter test
2019-10-03 18:44:22 +09:00
80585d446c Split applyPositionOffset into two methods and add xmldocs 2019-10-03 18:40:48 +09:00
f1ff22cf8b Fix hold note blueprint placing in the wrong direction 2019-10-03 18:40:48 +09:00
39369620fa Remove position offset from ColumnAt 2019-10-03 18:40:48 +09:00
0a409075be Fix note placement offset not working for down-scroll 2019-10-03 18:40:48 +09:00
754fbc59e1 Fix note placement being offset 2019-10-03 18:40:48 +09:00
ee34c5ccb4 Add a flip step to mania placement test scenes 2019-10-03 18:40:48 +09:00
e9c73ce30f Fix random failures on BeatmapCarousel filter test
The "un-filter" step causes a `SelectNextRandom` invocation. If this happens to select a difficulty in set 3 other than the previously buffered difficulty #2, the subsequent test would fail.

I've split this test out to remove the random element, but added a new assert to ensure buffered (previously visited?) difficulty is re-selected on return to the same set.
2019-10-03 16:21:14 +08:00
f2ba87a1d2 Fix placement blueprint test scenes not working 2019-10-03 16:28:56 +09:00
652acac87f Move placement movement event to BlueprintContainer 2019-10-03 16:14:42 +09:00
6268bbcfc8 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-10-03 15:12:21 +08:00
b28689c774 Fix key counters appearing negative on intense beatmaps
When `FrameStabilityContainer` decides it needs multiple updates on the same frame, it ends up with an elapsed time of zero. This was interacting badly with the condition used in `RulesetInputManager` to govern playback direction.

I have changed this to use `Rate` as exposed by the frame stable clock.

- Closes #6198.
2019-10-03 15:01:54 +08:00
2c13043c42 Hook up the event to HitObjectComposer 2019-10-03 14:40:00 +09:00
3fb0b0b668 Rename to StartTimeChanged and add xmldocs 2019-10-03 14:37:16 +09:00
f2719afd0e Add tests for Editorbeatmap 2019-10-03 14:27:40 +09:00
897b3233af Add start time tracking to EditorBeatmap 2019-10-03 14:23:48 +09:00
cbdf42cd7b Only lock the database for the duration of a deletion (#6363)
Only lock the database for the duration of a deletion
2019-10-03 10:40:08 +08:00
f8eb07b211 Only lock database for the duration of a model restoration 2019-10-03 11:24:17 +09:00
c85d7c8b3f Merge branch 'master' into reduce-database-deletion-locks 2019-10-03 10:17:27 +08:00
8017788521 Revert "Fix alt-f4 being blocked in interface"
This reverts commit 752dd26a4f.
2019-10-02 16:08:24 -07:00
148089f160 Revert "Remove unnecessary exitConfirmed condition check"
This reverts commit 38fe519c91.
2019-10-02 16:08:19 -07:00
38fe519c91 Remove unnecessary exitConfirmed condition check 2019-10-02 12:28:48 -07:00
ff56453f1a Fix test regressions 2019-10-02 12:07:07 -07:00
752dd26a4f Fix alt-f4 being blocked in interface 2019-10-02 11:17:43 -07:00
a69b9f1148 Fix alt-f4 being blocked during gameplay 2019-10-02 11:16:31 -07:00
4d4e846296 Merge branch 'master' into muted-notification 2019-10-02 17:31:34 +02:00
6929847b08 Remove redundant override 2019-10-02 17:22:34 +02:00
8d6a177a6b Merge pull request #6344 from smoogipoo/fix-track-leak
Fix memory leaks due to audio track recycle order
2019-10-02 22:43:47 +08:00
3e07e508f2 Merge branch 'master' into fix-track-leak 2019-10-02 22:20:05 +08:00
dfaa9531f8 Only lock the database for the duration of a deletion 2019-10-02 18:48:50 +09:00
2519fd26a9 Merge pull request #6351 from Joehuu/simplify-exit-logic-of-screens
Simplify exit logic of screens with textboxes using back button receptor
2019-10-02 18:38:06 +09:00
bd987e43a3 Merge pull request #6359 from LanTenDragon/holdformenu-slider-precision
Change HoldForMenu slider precision to 50
2019-10-02 18:19:19 +09:00
b161aa22c3 Merge branch 'master' into simplify-exit-logic-of-screens 2019-10-02 18:13:57 +09:00
faf8fe132e Change bindable int to float 2019-10-02 12:26:46 +08:00
c52cd02b62 Merge pull request #6348 from GSculerlor/truncate-username
Fix username overlap timestamp in match chatroom
2019-10-02 10:46:55 +09:00
b6dd610af8 Apply reviews 2019-10-01 23:18:03 +07:00
5f399add82 Resolve @iiSaLMaN 's suggested changes 2019-10-01 18:15:40 +02:00
2ac5e0bfa0 Make use of SessionStatics 2019-10-01 17:39:01 +02:00
e3502f5200 Fix typo on Key.Escape comment 2019-10-01 08:37:08 -07:00
ff6367fa4b Make back button glow when pressing escape 2019-10-01 08:26:45 -07:00
5f700f2ae9 Simplify exit logic of screens with textboxes using back button receptor 2019-10-01 08:26:34 -07:00
4e394e0ed5 Merge branch 'master' into muted-notification 2019-10-01 17:26:11 +02:00
208b9a4eba Add new virtual float for username to timestamp padding 2019-10-01 20:47:53 +07:00
cc533e8fe4 Remove BindableBeatmap 2019-10-01 17:24:47 +09:00
2f877be0c4 Hide unnecessary profile sections for bots (#6289)
Hide unnecessary profile sections for bots

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2019-10-01 16:08:30 +08:00
b4da92e5a6 Merge branch 'master' into bot-profile 2019-10-01 16:26:48 +09:00