Commit Graph

12428 Commits

Author SHA1 Message Date
f25439e359 Move track change subscription to LoadComplete 2022-12-23 01:54:49 +03:00
30de9ba795 Dispose previous waveform on track reload 2022-12-23 00:35:59 +03:00
20370bd5ae Invalidate waveform on track load 2022-12-22 20:49:09 +03:00
d0645ce151 Rewrite waveform invalidation 2022-12-22 15:59:51 +03:00
f2e8776529 Bind to clock instead of music controller 2022-12-22 15:35:53 +03:00
a18ece8610 Listen for track reload in timing screen 2022-12-22 01:24:23 +03:00
7089bb6c23 Listen for track reload in timeline 2022-12-22 01:23:59 +03:00
66a02374da Clear cached waveform on track change in editor 2022-12-22 01:23:24 +03:00
4a7d7c6ed9 Use MaxBy in all locations that can and update inspection level to match dotnet-build 2022-12-19 16:47:10 +09:00
b64a5cbda6 Merge branch 'master' into guard-url-protocols 2022-12-19 15:46:45 +09:00
fea0895f16 Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
ba54551313 Merge branch 'master' into guard-url-protocols 2022-12-16 18:23:16 +09:00
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
d5b2c7dfe9 Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
cbee72897a Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
232f590ba3 Merge pull request #21628 from peppy/go-hard-file-writes
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
50dc76d579 Merge pull request #21618 from smoogipoo/multi-spec-only-local-results
Only show local results in multi-spectator results screen
2022-12-14 14:00:02 +09:00
b8904fe747 Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
cb16d62700 Hook up ImportParameter flow with IModelImporter caller methods 2022-12-13 21:29:32 +09:00
7b48c91fe2 Only show local results in multi-spectator results screen 2022-12-12 18:56:43 +09:00
caa0b7c290 Move score token to BeginPlaying 2022-12-12 13:59:27 +09:00
4a65f5c864 Add score token to spectator state 2022-12-09 19:09:51 +09:00
0aeee8d6ab fix typo in today's tip 2022-12-07 17:47:37 +03:00
eea7984ba9 Remove triangle effect from latency certifier buttons 2022-12-07 14:53:56 +09:00
9ddc2f4804 Merge pull request #21523 from Feodor0090/rewind-click-fix
Perform rewind with right click only if cursor didn't leave the button
2022-12-06 13:38:20 +09:00
b66409bd37 Perform rewind with right click only if cursor didn't leave the button 2022-12-05 23:38:45 +03:00
41f7dad8e9 Delete SmoothCircularProgress.cs 2022-12-03 16:40:41 +03:00
97b6d88f00 Remove SmoothCircularProgress usage in AccuracyCircle 2022-12-03 16:39:44 +03:00
5a69656764 Merge pull request #21496 from peppy/fix-zero-length-spinners
Fix being able to place zero-length spinners
2022-12-02 19:25:00 +09:00
850931120d Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time
Fix some components not accounting for final hold notes in osu!mania beatmaps
2022-12-02 18:12:00 +09:00
d1296a22ce Update timeline blueprint's end time logic to better match new blueprint implementation 2022-12-02 17:57:15 +09:00
a39bd634c4 Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies
Provide DrawableRulesetDependencies from HitObjectComposer
2022-12-02 17:31:31 +09:00
d684aa75b8 Merge pull request #21477 from peppy/fix-mania-timeline-blueprint-colour
Fix osu!mania editor timeline showing bright-white blueprints
2022-12-02 16:55:29 +09:00
a2db0afe19 Avoid querying GetLastObjectTime twice in editor seek flow 2022-12-02 16:07:24 +09:00
8cf89fcb81 Use Highlight1 instead of dull grey 2022-12-02 15:30:47 +09:00
896f2d8f74 Fix multiple instances of last hitobject time being calculated incorrectly 2022-12-01 18:04:06 +09:00
f34a79b1a9 Set a better default colour for timeline blueprints when no colour information is available 2022-12-01 17:03:53 +09:00
bbf023cf68 Fix incorrect culture used when parsing timeline popup textbox content 2022-12-01 16:12:29 +09:00
5c8fce1c08 Remove extra blank line 2022-11-30 13:05:14 +01:00
6a61e70766 Expose Ruleset from HitObjectComposer instead 2022-11-30 12:17:58 +01:00
4215f4f5d7 Merge branch 'master' into Editor-DrawableRuleset-Dependencies 2022-11-30 17:42:46 +09:00
2a3b24d058 Avoid need for implicit null casting 2022-11-30 14:21:04 +09:00
0659c84341 Rename method to be more in line with project naming 2022-11-30 14:17:49 +09:00
63ba40ff39 Merge branch 'master' into control-point-scroll-into-view 2022-11-30 14:12:19 +09:00
7dbf379351 Don't use verbatim string literals 2022-11-29 18:22:07 +00:00
70c320b2e8 Provide ruleset dependencies only to Compose Placement Blueprints 2022-11-27 21:43:33 +01:00
0aba119056 Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
#	osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
218c04c174 Code quality 2022-11-27 03:23:08 +00:00
6000e14668 Correctly select issue row 2022-11-27 03:08:54 +00:00