Commit Graph

56972 Commits

Author SHA1 Message Date
b29c894144 Merge pull request #20267 from peppy/notification-fling-right
Add ability to flick notifications to the right to store for later
2022-09-14 09:12:38 +09:00
04dbb6fc1b Add inline comment 2022-09-14 00:49:02 +03:00
4a49433e2e Merge branch 'master' into notification-fling-right 2022-09-13 20:01:56 +09:00
81b5e4a865 Fix back-to-front condition on leaderboard always show configuration 2022-09-13 19:57:40 +09:00
94693a4667 Fix oversight when making interface implementation explicit 2022-09-13 19:55:57 +09:00
566a61e770 Merge pull request #20244 from peppy/notification-fling
Add ability to "fling" notifications to dismiss them
2022-09-13 19:50:34 +09:00
9226f0abbc Implement equality correctly in Live 2022-09-13 19:16:25 +09:00
e15a25ea49 Fix leaderboard positioning logic to actually consider elements on the left side 2022-09-13 18:45:11 +09:00
678eec1c67 Move LeaderboardFlow to HUDOverlay to share positioning logic 2022-09-13 18:45:11 +09:00
5894d2f0bc Ensure gameplay leaderboard hides with rest of HUD when it should 2022-09-13 18:45:11 +09:00
6d167070f8 Add back DI leaderboard retrieval via bindable pathway 2022-09-13 18:45:11 +09:00
70e6b595f1 Refactor SoloGameplayLeaderboard to not read scores via DI
Also allows updating scores if they arrive late.
2022-09-13 18:00:21 +09:00
d2b80645ab Change Leaderboard to use IUser instead of APIUser 2022-09-13 18:00:21 +09:00
ac58c222b9 Allow DrawableAvatar to accept an IUser for now 2022-09-13 18:00:21 +09:00
d251c0b2ac Move leaderboard implementation to Player itself 2022-09-13 18:00:21 +09:00
368faa0084 Make constructor protected in base implementation 2022-09-13 18:00:21 +09:00
4c669e2bce Track local Player.Score's user rather than using APIProvider 2022-09-13 18:00:21 +09:00
fed9a47866 Add test coverage 2022-09-13 18:00:21 +09:00
3490b16056 Add simplified SoloGameplayLeaderboard implementation
Note that this doesn't support waiting until leaderboard finishes fetching scores.
2022-09-13 18:00:21 +09:00
27a81dfb9f Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
53ac9dbc38 Merge branch 'master' into notification-fling 2022-09-13 17:07:16 +09:00
08f0056b37 Merge pull request #20265 from peppy/fix-song-progress-invalidations
Fix `SongProgress` invalidating too often
2022-09-13 16:51:11 +09:00
4004d57448 Merge branch 'master' into move-td-reduction 2022-09-13 16:12:26 +09:00
0e2155303e Merge branch 'master' into fix-song-progress-invalidations 2022-09-13 16:07:05 +09:00
62971ef1cc Merge pull request #20281 from peppy/fix-drawable-ruleset-dependencies
Fix null considerations in `DrawableRulesetDependencies`
2022-09-13 15:26:29 +09:00
608c893b23 Add basic test guarantees 2022-09-13 15:03:13 +09:00
ea07f6692c Merge pull request #20283 from peppy/fix-multi-spectator-player-null-ref
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:59:36 +09:00
f53507828c Rename event to be more generic (and add comprehensive xmldoc) 2022-09-13 14:59:30 +09:00
ac034bffeb Fix potential crash if multiplayer spectator load is aborted early 2022-09-13 14:21:54 +09:00
0fcd9e02f6 Fix skin dropdown not updating correctly when skin is changed externally 2022-09-13 14:01:40 +09:00
d368f37c3a Remove redundant second Current set operation 2022-09-13 13:50:59 +09:00
6bf6b7e125 Fix null considerations in DrawableRulesetDependencies 2022-09-13 13:13:38 +09:00
9c2b0efbc7 Merge pull request #20262 from smoogipoo/scoreprocessor-computeaccuracy
Add `ScoreProcessor.ComputeAccuracy()`
2022-09-13 11:55:02 +09:00
34463c3956 Merge pull request #20260 from peppy/fix-skin-animation-edge-case
Fix new-style legacy skins with animated judgements not adding correct transforms
2022-09-13 04:20:09 +03:00
0ca4be5e5b Fix one more inspection 2022-09-13 03:45:31 +03:00
fd48249eef fix with new event 2022-09-13 02:20:52 +02:00
69b9bae3b3 Merge branch 'master' into scoreprocessor-computeaccuracy 2022-09-13 03:09:52 +03:00
a6f68e4a90 Fix NRT inspections 2022-09-13 03:08:13 +03:00
a1f4724685 moved the location of the tests 2022-09-13 01:38:29 +02:00
a20c97d072 Merge branch 'master' into fix-skin-animation-edge-case 2022-09-13 02:26:55 +03:00
5fba21d658 Rename parameter to clarify purpose 2022-09-13 02:21:01 +03:00
718f8c4ee2 revert the fix 2022-09-13 01:09:42 +02:00
07f577a0c6 Fix beatmap listing potentially showing duplicate beatmap cards 2022-09-13 01:39:21 +03:00
a5b962d9a3 Add failing test case 2022-09-13 01:37:23 +03:00
8400de4b2e invoking hitobject updated before invoking removed 2022-09-12 17:50:11 +02:00
8cbc0502ae Inline CalculateEffect 2022-09-12 15:51:18 +03:00
88107108ee Add ability to flick notifications to the right to store for later 2022-09-12 20:20:57 +09:00
802c5629c0 Merge branch 'master' into notification-fling 2022-09-12 20:09:21 +09:00
2b4b14ca99 Fix SongProgress invalidating too often
This regressed with https://github.com/ppy/osu/pull/19556. Rather than
try and figure whether that new container needs to handle size
differently, this is a simple solution.

Height was taken from a runtime check (maxes out at about 14.5).

Closes #20235.
2022-09-12 20:06:53 +09:00
2bd72fd9b4 add test for hide catchercombo 2022-09-12 19:56:05 +09:00