Commit Graph

7893 Commits

Author SHA1 Message Date
a104277e7f Rename ModSelect{Screen -> Overlay}Strings 2022-05-11 18:01:33 +02:00
76c63f1d0a Rename ModSelect{Screen -> Overlay} in place of removed old design 2022-05-10 22:56:50 +02:00
33634cba1e Remove old mod buttons 2022-05-10 21:58:22 +02:00
8b0ece1c09 Remove old mod section 2022-05-10 21:55:54 +02:00
dfd97701d7 Remove old mod settings container & related controls 2022-05-10 21:53:42 +02:00
128468e13d Remove old base mod select overlay 2022-05-10 21:52:30 +02:00
24c59e2f2f Remove old user mod select overlay 2022-05-10 21:52:17 +02:00
9446be2511 Remove unnecessary UnbindAdjustments call
It is not necessary given that `CurrentTrack` already removes all adjustments first.
2022-05-10 20:49:44 +03:00
36a7644164 Reinstantiate mod adjustments layer for safety against previous mods 2022-05-10 20:46:33 +03:00
725ff93f34 Define local adjustments component for mods in MusicController
Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).
2022-05-10 18:24:29 +03:00
42fe708225 Fix inspection 2022-05-10 19:56:21 +09:00
a578f7a406 Force nested screens to load synchronously 2022-05-10 18:21:35 +09:00
a93c63b2b5 Add loading spinner when loading first run screens 2022-05-10 18:21:35 +09:00
25c6226ca9 Adjust transition length for a more seamless screen change 2022-05-10 18:21:35 +09:00
493798ae5e Fix nested ui scale example screens no longer fitting 2022-05-10 18:21:35 +09:00
63b9e01d38 Fix behaviour screen using old style buttons 2022-05-10 18:21:35 +09:00
61313b69ec Standardise font sizes in first run overlay screens 2022-05-10 18:21:35 +09:00
e5204e565d Move horizontal padding to content level to better align scrollbar 2022-05-10 18:21:35 +09:00
bcce9c5e67 Limit the width of first run overlay content 2022-05-10 18:21:35 +09:00
9aadc274bf Show first run dialog on first run of the game 2022-05-10 18:21:35 +09:00
8ccf2ee075 Add inline comment 2022-05-10 15:07:08 +09:00
2b7eeadac0 Workaround bad performance when selecting all freemods 2022-05-10 14:48:41 +09:00
886a4815fa Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap
Fix `SettingsToolboxGroup` not clearing transforms before updating autosize
2022-05-10 13:48:02 +09:00
2481201a73 Fix selector dismissal behaviour during user actions 2022-05-09 22:58:46 +01:00
96ea4ee7b3 Add explanatory comment 2022-05-09 23:49:05 +03:00
626fcd5d35 Merge branch 'master' into column-flow-cq 2022-05-09 19:22:29 +02:00
d4cc2bd7dd Ensure channel selector is dismissed when the current channel is changed 2022-05-09 12:11:25 +01:00
702c6ae658 Fix SettingsToolboxGroup not clearing transforms before updating autosize 2022-05-09 13:49:31 +03:00
1c63c27fdf Merge branch 'master' into new-chat-drawable-channel 2022-05-09 18:23:00 +09:00
e9cc3ab54a Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state
Fix popup dialog potentially not clicking last button when dismissed
2022-05-09 17:22:03 +09:00
623e2c94ae Adjust padding 2022-05-09 00:32:22 +01:00
aeb2984989 Move ChatOverlayDrawableChannel to it's own file 2022-05-09 00:31:22 +01:00
5f80e344c3 Update day separator date text to right align against username 2022-05-09 00:15:08 +01:00
21e1f4546a Fix popup dialog potentially not clicking last button when dismissed 2022-05-08 14:40:30 -07:00
172d14bcc6 Improve code quality of mod column flow container 2022-05-08 11:40:14 -07:00
d964b4f23c Fix uneven spacing when some mod columns are hidden 2022-05-08 15:40:21 +02:00
6bdcf893b7 Move alpha management closer to screen level
Felt bad messing with alpha at the column level.
2022-05-08 15:40:10 +02:00
92ccec20d7 Hide mod columns if all mods within are filtered out 2022-05-08 14:53:59 +02:00
b8cb2c1b82 Increase scroll amount slightly 2022-05-08 19:57:03 +09:00
778497b9e2 Scroll mod select slightly into view on first display 2022-05-08 18:58:54 +09:00
b92d95a17a Fix mod panels playing samples when hidden at a higher level 2022-05-08 10:39:49 +02:00
81ca534f87 Implement ISamplePlaybackDisabler in mod select 2022-05-08 10:39:49 +02:00
230c4e27b8 Simplify and centralise hiding logic for mod overlay
Behaviourally, this also always toggles via button triggering to add the
button flash animation.
2022-05-08 13:03:28 +09:00
8da7bbd322 Code quality 2022-05-07 23:30:46 +01:00
c0643cae75 Create ChatOverlayDaySeparator and use in ChatOverlayDrawableChannel 2022-05-07 23:24:34 +01:00
f4acfbd0df Change return type of CreateDaySeparator to Drawable 2022-05-07 22:23:46 +01:00
bec28c5b28 Remove virtual ColourInfo properties from DaySeparator 2022-05-07 22:16:11 +01:00
46d3220c07 Isolate sample screens from global mods bindable
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.

The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.

This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
2278da563e Add various xmldoc for nested classes 2022-05-08 02:03:28 +09:00
03c80d9197 Reorder methods / properties in ModSelectScreen for legibility 2022-05-08 01:58:37 +09:00