|
|
f3af612133
|
Suggest removing difficulty filter if no matches found at song select
|
2022-07-01 15:18:04 +09:00 |
|
|
|
42d56aa640
|
Merge pull request #18958 from andy840119/remove-nullable-disable-in-the-extension
Remove nullable disable annotation in the extension namespace.
|
2022-07-01 13:52:12 +09:00 |
|
|
|
48047f2e58
|
Move the null check in the outside.
AddCursor() should not accept the null value.
|
2022-06-30 23:29:49 +08:00 |
|
|
|
a5b1f1a688
|
mark the string as nullable.
|
2022-06-30 23:23:14 +08:00 |
|
|
|
26de34da84
|
Remove the nullable disable annotation.
|
2022-06-30 23:20:40 +08:00 |
|
|
|
e50e0f7339
|
Remove the nullable disable annotate.
|
2022-06-30 23:05:09 +08:00 |
|
|
|
356c0501ec
|
Guard again potential nulls in RealmNamedFileUsage
Hopefully help in figuring out https://sentry.ppy.sh/organizations/ppy/issues/3679/?project=2&query=user%3A%22id%3A10078484%22
|
2022-06-30 15:40:57 +09:00 |
|
|
|
78d86fd3ff
|
Fix PerformWrite not rolling back transaction on exception
|
2022-06-30 15:15:09 +09:00 |
|
|
|
e89f220e9a
|
Merge pull request #18949 from smoogipoo/fix-flaky-star-display-test
Ensure PlaylistItem's beatmap is not null
|
2022-06-30 15:15:06 +09:00 |
|
|
|
c6520de749
|
Ensure PlaylistItem beatmap is not null
|
2022-06-30 14:24:49 +09:00 |
|
|
|
edc4ace17e
|
Attach DT with NC, SD with PF, and Cinema with Autoplay
|
2022-06-30 11:52:30 +09:00 |
|
|
|
582175c3a4
|
Update framework
|
2022-06-29 22:57:52 +09:00 |
|
|
|
18d465eff7
|
Guard against NaN star difficulty results
|
2022-06-29 21:02:29 +09:00 |
|
|
|
87e3b44181
|
Ensure icon is loaded inside try-catch
|
2022-06-29 13:37:42 +03:00 |
|
|
|
e3eba58cb6
|
Catch in triangles intro
|
2022-06-29 13:37:42 +03:00 |
|
|
|
6c64cea057
|
Catch a second location
|
2022-06-29 18:56:15 +09:00 |
|
|
|
b092e6937a
|
Guard against ruleset icon creation failures to avoid whole game death
|
2022-06-29 18:51:07 +09:00 |
|
|
|
2989803b71
|
Merge branch 'master' into speed-acc-scaling
|
2022-06-29 16:15:20 +09:00 |
|
|
|
f435f0d8e4
|
Merge pull request #18920 from andy840119/remove-nullable-disable-in-the-migration
Remove the nullable disable annotations in the class belongs to the migration namespace.
|
2022-06-29 14:40:11 +09:00 |
|
|
|
fde5b2cf2b
|
Merge pull request #18921 from andy840119/remove-nullable-disable-in-the-localisation
Remove the nullable disable annotation in the localisation.
|
2022-06-29 13:51:50 +09:00 |
|
|
|
114f1b47c4
|
Merge branch 'master' into remove-nullable-disable-in-the-migration
|
2022-06-29 13:11:45 +09:00 |
|
|
|
a0125cbb62
|
Merge branch 'master' into fix-da-settings-slider-padding
|
2022-06-28 20:53:07 +02:00 |
|
|
|
ecdb30d215
|
Fix one more case of collection modification during enumeration
https://sentry.ppy.sh/share/issue/a61c27b2a63a4a6aa80e75873f9d87ca/
|
2022-06-29 02:28:23 +09:00 |
|
|
|
aacded0ecf
|
Fix difficulty adjust settings having more padding on sliders
|
2022-06-28 07:33:05 -07:00 |
|
|
|
de7f2a0bba
|
Remove the nullable disable annotation in the localisation.
|
2022-06-28 20:59:57 +08:00 |
|
|
|
2269f1046e
|
Remove the nullable disable annotations.
|
2022-06-28 20:59:03 +08:00 |
|
|
|
7c9c499e19
|
Update resources (translation updates)
|
2022-06-28 19:21:46 +09:00 |
|
|
|
c282e19316
|
Update language initialisation in line with framework LocalisationManager changes
|
2022-06-28 18:19:48 +09:00 |
|
|
|
975ba83838
|
Update framework
|
2022-06-28 18:19:48 +09:00 |
|
|
|
d630b62cfc
|
Merge pull request #18915 from peppy/slider-snaking-test-refactoring
Apply various refactorings to `TestSceneSliderSnaking`
|
2022-06-28 16:16:35 +09:00 |
|
|
|
8e4a6c43b5
|
Merge pull request #18914 from peppy/spectator-playback-test-leniences
Increase leniences on `TestSceneSpectatorPlayback.TestWithSendFailure`
|
2022-06-28 16:15:51 +09:00 |
|
|
|
6bfd351dec
|
Add logging of GameplayClockContainer seeks
|
2022-06-28 15:23:29 +09:00 |
|
|
|
35745c83b7
|
Replace dodgy SetUpSteps overriding with usage of HasCustomSteps
|
2022-06-28 15:19:02 +09:00 |
|
|
|
22b254e5c5
|
Handle task exception outside of schedule to avoid unobserved exceptions
|
2022-06-28 15:09:28 +09:00 |
|
|
|
c1075d113f
|
Add logging around current channel changes and join requests
Tracking down a flaky test
(https://teamcity.ppy.sh/buildConfiguration/Osu_Build/553?hideProblemsFromDependencies=false&expandBuildTestsSection=true&hideTestsFromDependencies=false):
```csharp
TearDown : System.TimeoutException : "PM Channel 1 displayed" timed out
--TearDown
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503
at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
------- Stdout: -------
[runtime] 2022-06-27 23:18:55 [verbose]: 💨 Class: TestSceneChatOverlay
[runtime] 2022-06-27 23:18:55 [verbose]: 🔶 Test: TestKeyboardNextChannel
[runtime] 2022-06-27 23:18:55 [verbose]: Chat is now polling every 60000 ms
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #1 Setup request handler
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #2 Add test channels
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #3 Show overlay with channels
[runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #4 Select channel 1
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #5 Channel 1 is visible
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #6 Press document next keys
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #7 Channel 2 is visible
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #8 Press document next keys
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #9 PM Channel 1 displayed
[network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/587 failed with System.Net.WebException: NotFound.
[network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/503 failed with System.Net.WebException: NotFound.
[runtime] 2022-06-27 23:19:05 [verbose]: 💥 Failed (on attempt 5,550)
[runtime] 2022-06-27 23:19:05 [verbose]: ⏳ Currently loading components (0)
[runtime] 2022-06-27 23:19:05 [verbose]: 🧵 Task schedulers
[runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0
[runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-06-27 23:19:05 [verbose]: 🎱 Thread pool
[runtime] 2022-06-27 23:19:05 [verbose]: worker: min 1 max 32,767 available 32,766
[runtime] 2022-06-27 23:19:05 [verbose]: completion: min 1 max 1,000 available 1,000
[runtime] 2022-06-27 23:19:05 [debug]: Focus on "ChatTextBox" no longer valid as a result of unfocusIfNoLongerValid.
[runtime] 2022-06-27 23:19:05 [debug]: Focus changed from ChatTextBox to nothing.
```
This kind of logging should be helpful:
```csharp
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #5 Channel 1 is visible
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #6 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to #channel-2
[runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay.
[runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer.
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #7 Channel 2 is visible
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #8 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 685
[runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay.
[runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer.
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #9 PM Channel 1 displayed
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #10 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 218
```
|
2022-06-28 14:00:30 +09:00 |
|
|
|
93e13ef890
|
Merge branch 'master' into no-invalid-operation-without-message
|
2022-06-27 19:11:08 +02:00 |
|
|
|
54fe6b7df3
|
Fix incorrect string interpolation
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2022-06-28 01:43:09 +09:00 |
|
|
|
569fde4b47
|
Add messages to all InvalidOperationExceptions
Without this, they can be very non-descript and hard to track down
|
2022-06-28 01:34:25 +09:00 |
|
|
|
b28cfc222b
|
Schedule unregister instead
|
2022-06-28 01:19:28 +09:00 |
|
|
|
3e3843dcf9
|
Fix potential crash on CloseAllOverlays due to collection mutation
|
2022-06-28 00:32:36 +09:00 |
|
|
|
d43b980a17
|
Merge pull request #18872 from peppy/add-working-beatmap-changed-logging
Add various logging of global `WorkingBeatmap` state changes
|
2022-06-27 21:34:05 +09:00 |
|
|
|
c2b03cb6b9
|
Merge pull request #18875 from peppy/logging-finalise-selection-abort-operations
Add logging for various cases of `SongSelect.FinaliseSelection` being aborted
|
2022-06-27 21:33:51 +09:00 |
|
|
|
6c6de9ce53
|
Fix typo
|
2022-06-27 20:40:02 +09:00 |
|
|
|
396e7fc166
|
Merge pull request #18862 from peppy/empty-beatmap-file-fix-2
Fix second case of empty beatmaps being reported to sentry as errors
|
2022-06-27 20:37:57 +09:00 |
|
|
|
aa7d54f8b6
|
Add logging for various cases of SongSelect.FinaliseSelection being aborted
|
2022-06-27 20:10:17 +09:00 |
|
|
|
f355c3a3c9
|
Merge pull request #18864 from peppy/fix-realm-audio-track-test-fail
Centralise and harden editor-ready-for-use check
|
2022-06-27 19:42:49 +09:00 |
|
|
|
8f91ce8f0c
|
Merge pull request #18871 from peppy/fix-realm-assertion-during-tests
Fix occasional failure in realm test proceedings due to incorrect `Debug.Assert`
|
2022-06-27 18:48:47 +09:00 |
|
|
|
50c1c066de
|
Add various logging of global WorkingBeatmap state changes
|
2022-06-27 18:41:31 +09:00 |
|
|
|
0ba29b6fa6
|
Use currentScreen instead to make sure the screen we care about is loaded
|
2022-06-27 18:28:00 +09:00 |
|
|
|
b13fa924fd
|
Merge pull request #18865 from peppy/fix-flaky-chat-test
Fix chat tests failing 1/10000 runs
|
2022-06-27 18:06:00 +09:00 |
|
