Commit Graph

5861 Commits

Author SHA1 Message Date
f3d4756c7f Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2
Fix multiplayer spectator occasionally rewinding time unexpectedly
2022-01-31 18:33:08 +09:00
575d9671bf Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures
Fix test failures if `DialogOverlay` is not loaded in time
2022-01-31 17:06:24 +09:00
9001c3a396 Fix test failures if DialogOverlay is not loaded in time
As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true, where `DialogOverlay` hasn't loaded in single file yet.
2022-01-31 15:17:07 +09:00
c8c0ae5658 Merge branch 'master' into flush-frames-end-play 2022-01-31 15:12:41 +09:00
57f793aff0 Rename dictionary and make private for added safety 2022-01-31 15:12:08 +09:00
e9f3e7f5cb Merge pull request #16703 from peppy/leaderboard-component-fixes
Rewrite `Leaderboard` component to bring up to current code standards
2022-01-31 14:33:04 +09:00
f8939af5e6 Track loading via state as well 2022-01-31 01:12:03 +09:00
6a21d58325 Avoid test failures on non-triangle intro tests 2022-01-30 18:59:18 +09:00
1dbcb5ab63 Add test coverage of intro fail scenario 2022-01-30 18:51:16 +09:00
04dbb5d3c6 Disallow setting "NoScores" externally as it is handled internally 2022-01-30 16:18:19 +09:00
acc1199add Consolidate flows of Set operations, either result or error 2022-01-30 16:16:00 +09:00
c401629dd8 Also refactor placeholder logic to make more sense 2022-01-30 10:50:32 +09:00
4f4f60248f Add failing test case 2022-01-30 01:46:10 +03:00
06660ff960 Fix null beatmap in test scene 2022-01-30 03:02:56 +09:00
d21464ea61 Fix assertions to work in both directions 2022-01-30 02:54:51 +09:00
51acf79935 Change test exposure to property instead of method 2022-01-30 02:29:51 +09:00
9861c50b33 Remove pointless tests that no longer show anything valid 2022-01-30 00:03:22 +09:00
a915b9cd30 Fix occasional failures in TestSceneDeleteLocalScore 2022-01-29 23:58:57 +09:00
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
aee93934d5 Rename methods to make more sense (and always run through AddOnce) 2022-01-29 23:58:57 +09:00
4c97ed676f Fix score presentation tests not correctly entering song select before running 2022-01-29 14:46:24 +09:00
1253e1ecc1 Replace LINQ Count() invocation with count property access 2022-01-28 20:25:12 +01:00
3037a3a769 Purge final spectator frames before ending play 2022-01-28 22:26:05 +09:00
f021a274d2 Merge pull request #16681 from peppy/fix-delete-local-scores
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
2453bf5ed0 Add test coverage of the same thing but via "clear all scores" button 2022-01-28 15:54:53 +09:00
778eebc94d Add test coverage of local score import and deletion 2022-01-28 15:50:36 +09:00
32f9299fe0 Remove unused using 2022-01-28 15:26:29 +09:00
28c8e07e3f Ensure hold for menu button fades out if the cursor is never moved
Closes https://github.com/ppy/osu/discussions/16669.
2022-01-28 14:48:35 +09:00
f32d56e213 Bring HoldForMenuButton tests up-to-date in code quality 2022-01-28 14:48:17 +09:00
04d6ca59a3 Merge branch 'master' into song-select-scroll-position-during-delete 2022-01-27 20:46:19 +01:00
e872877185 Merge pull request #16648 from peppy/fix-song-select-tests
Fix song select tests not waiting for beatmap imports to arrive
2022-01-27 23:00:58 +09:00
fae4f8bd8e Move nulling of previous songSelect to SetUpSteps instead 2022-01-27 21:59:44 +09:00
831fa44433 Fix song select tests not waiting for beatmap imports to arrive
After the change to realm, notification fires could take a frame or two.
We aren't accounting for this.

Fixes test failures like
https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true
2022-01-27 19:35:42 +09:00
a5d422e82c Merge branch 'master' into ruleset-id-fixes 2022-01-27 17:07:18 +09:00
f2cecad83b Add failing test coverage showing carousel deletions don't keep scroll position 2022-01-27 16:52:02 +09:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
e0616476e2 Fix test gameplay tests failing due to beatmap refetch on suspend 2022-01-26 21:15:49 +01:00
4382adad82 Add test coverage for editor changes not resetting after exit without save 2022-01-26 21:15:49 +01:00
cdca1285ab Merge branch 'master' into playlist-overlay-optimisations 2022-01-26 19:01:33 +09:00
68ee80c5de Merge pull request #16623 from frenzibyte/refactor-editor-save-test
Refactor editor saving test scene for scalability
2022-01-26 15:40:39 +09:00
701f00a4b1 Merge pull request #16609 from peppy/fix-realm-related-failures
Fix some realm-related test failures
2022-01-26 15:31:18 +09:00
9532454e2a Remove ILive remnants 2022-01-26 15:12:07 +09:00
ba46827ac0 Merge branch 'master' into playlist-overlay-optimisations 2022-01-26 15:11:14 +09:00
064468faad Refactor editor saving test scene for scalability 2022-01-26 07:57:46 +03:00
cd71ec0edd Remove ILive<> interface (and use abstract Live<> instead) 2022-01-26 13:38:56 +09:00
dda513dd08 Change PlaylistOverlay to use ILive 2022-01-26 12:19:59 +09:00
bdf215c576 Merge branch 'master' into improve-timeline-zoom 2022-01-26 03:40:53 +09:00
5085eb6801 Ensure gameplay starts by dismissing any notifications in TestSceneChangeAndUseGameplayBindings 2022-01-26 03:39:01 +09:00
ad18bc4983 Update timeline selection test scene with zoom changes 2022-01-25 18:57:39 +03:00
5b82eaf112 Merge branch 'master' into fix-beat-divisor-not-saving 2022-01-25 23:29:37 +09:00