Commit Graph

239 Commits

Author SHA1 Message Date
992441b9de Disable alpha component parsing in beatmap / skin colour sections 2022-09-21 16:11:41 +09:00
cf25ee8e84 Add test coverage of storyboard animation start time 2022-09-12 14:17:15 +09:00
5b758afd09 Merge branch 'master' into taiko-geki-katu 2022-09-07 16:22:47 +09:00
7c0e99c5a8 Decode Geki/Katu from legacy taiko scores into LargeBonus 2022-09-07 00:12:34 +09:00
fa0a4614f8 Add failing test for second incorrect case of start time handling 2022-09-06 16:40:59 +09:00
abf0242686 Add failing test for incorrect start time of storyboard elements 2022-09-06 16:16:58 +09:00
adea29c106 Fix test failures 2022-08-24 03:37:33 -04:00
c7d4c739aa Add a basic NaN control point test for LegacyBeatmapDecoder 2022-08-24 02:53:55 -04:00
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
9259aa94f1 Fix Catmull slider parsing with duplicate initial point 2022-05-24 11:47:42 +09:00
fe49a7e678 Add failing tests 2022-05-18 17:10:19 +09:00
478174dd58 Merge pull request #17416 from peppy/skin-fuck
Refactor skin construction
2022-03-25 15:36:06 +09:00
d6fc53579e Split out shared code for encode-decode cycle (and remove unrelated culture set) 2022-03-24 17:00:49 +09:00
a7554dcdf7 Use a constant for the early version timing offset 2022-03-24 16:43:41 +09:00
2efae031c9 Add test coverage of decode specifically 2022-03-24 16:39:56 +09:00
59a7eb5322 Add test coverage ensuring offsets are correct before and after legacy replay encode 2022-03-24 16:34:21 +09:00
7a1909bf97 Change parameter order of LegacySkin to put IStorageResourceProvider first
The optional resource store should not be before the (basically)
required resource provider.
2022-03-23 15:02:04 +09:00
bda3cdc9a7 Add tests 2022-01-28 19:29:30 +09:00
7dc3940dee Add test coverage for preserving legacy beatmap info defaults 2022-01-27 21:49:26 +01:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
bb6f40d16e Add test coverage of all mod storages containing classic mod post-import 2022-01-19 14:34:27 +09:00
7f65f3a47f Remove all usage of BaseDifficulty (and access Difficulty instead) 2022-01-18 22:57:39 +09:00
b2d09b7b10 Fix further warnings 2022-01-12 23:42:12 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
f6f24220c2 Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs
This has been wrong from the outside, but hidden by the fact that the
default values are equal. I've changed to MD5Hash which actually asserts
that the correct beatmap has likely arrived.

Found this in my realm changes, where it fails due to the beatmap ID
being a differing Guid in each case.
2022-01-08 15:28:13 +09:00
b0d14526ea Move test ScoreInfo creation to TestResources
The main goal here is to remove the inheritance, since realm doesn't
like that. Unfortunate that we can't use object initialisers in a few of
these places, but no real way around that.
2021-12-13 16:34:50 +09:00
ea6766d940 Add failing test case 2021-12-04 17:13:43 +01:00
bbd3ea5b77 Update all actual usages of RulesetInfo.ID to use OnlineID instead 2021-11-24 15:50:26 +09:00
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
ed07ee8c61 Update all existing usages of AuthorString/AuthorId
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00
09f9731d74 Add temporary disable of failing r# inspection 2021-11-04 15:09:04 +09:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
aa0762ebe2 Add test coverage for failing slider case 2021-10-26 17:35:03 +09:00
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
281a3a0cea Add test case for legacy loop count behaviour 2021-10-02 18:40:41 +02:00
46bafb6252 Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-28 13:53:56 +09:00
cd181452be Add decoding support for SamplesMatchPlaybackRate 2021-09-12 16:45:27 +02:00
5f61936700 Update legacy encoder tests to only compare pieces we care about 2021-09-10 17:29:09 +09:00
1952ebece9 Update tests to use more correct control point definitions 2021-09-06 22:04:51 +09:00
8ffcea2e51 Remove unnecessary null checks 2021-09-06 21:32:43 +09:00
3c7a34bdbd Move mania-specific conversion to converter 2021-09-06 21:06:13 +09:00
b2a14b13dc Update outdated tests 2021-09-03 17:11:12 +09:00
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
071c56e90b Update usages of DifficultyPointAt 2021-09-03 16:58:16 +09:00