8dbe24fd7c
Simplify colour assigning logic and remove system mod colour for now
2022-07-12 14:36:50 +09:00
8e1ed1c621
Mark CreateHitObjectComposer() accept null.
...
And add the null check in the test case.
2022-07-10 10:15:27 +08:00
57c6763556
Mark the CreateBeatmapProcessor() as nullable.
...
Also, should add the null check in the working beatmap.
2022-07-10 10:15:27 +08:00
d39f53f1f0
Mark CreateConfig() return type as nullable because it's not required all ruleset to implement.
...
Also, remove nullable disable annotation for all using classes.
Setting store can be nullable because `RulesetConfigManager()` can accept null setting store.
2022-07-10 10:15:27 +08:00
857377e145
Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.
...
But seems some of the customized ruleset use it for save the replay frame.
2022-07-10 10:15:27 +08:00
e67cb4c905
Mark create beatmap verifier as nullable because seems it's not requirement to be implemented.
2022-07-10 10:10:43 +08:00
4a503bab0a
Remove unnecessary attribute.
2022-07-10 10:10:43 +08:00
855debd5f6
Remove nullable disable annotation and mark some return value as nullable.
2022-07-10 09:29:17 +08:00
7ced84b7ef
Replace switch statement with ForModType
...
In order to make `highlightedColour` dependent on the mod type color, the color is converted to an `osu.Framework.Graphics.Colour4` and calls `Lighten`.
2022-07-08 03:23:58 -05:00
89f1c75f7a
Update mod icon colors
2022-07-07 21:57:18 -05:00
59e3d4b9e5
Remove the nullable disable annotation in the Ruleset.Filter namespace.
2022-07-03 21:00:54 +08:00
ea573f314e
Remove the nullable disable annotation in the Rulesets.Replays namespace in the osu.game project.
2022-07-02 13:08:25 +08:00
edc4ace17e
Attach DT with NC, SD with PF, and Cinema with Autoplay
2022-06-30 11:52:30 +09:00
6c64cea057
Catch a second location
2022-06-29 18:56:15 +09:00
b092e6937a
Guard against ruleset icon creation failures to avoid whole game death
2022-06-29 18:51:07 +09:00
2989803b71
Merge branch 'master' into speed-acc-scaling
2022-06-29 16:15:20 +09:00
aacded0ecf
Fix difficulty adjust settings having more padding on sliders
2022-06-28 07:33:05 -07:00
0fd2c010e5
Remove NRT disables from attributes classes
2022-06-27 16:07:15 +09:00
0579780bb8
Add IBeatmapOnlineInfo parameter and use to extract more data
2022-06-27 16:07:15 +09:00
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
30eebf3511
Merge branch 'master' into c-sharp-10
2022-06-24 21:22:33 +09:00
26c5b59f6d
Replace usages of string.To{Lower,Upper}()
2022-06-24 11:57:45 +02:00
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
a7de43ade6
Add attribute ID
2022-06-21 19:31:45 +09:00
e0c82d11ab
Convert == usages to ReferenceEquals
2022-06-20 16:56:19 +09:00
bd5037fcad
Fix new hitobject placements not taking on the existing sample settings
...
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.
Closes https://github.com/ppy/osu/issues/18742 .
2022-06-18 13:49:59 +09:00
fd9902e816
Manual #nullable processing
2022-06-17 16:38:35 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
ea191da496
Merge pull request #18728 from peppy/fix-unsafe-sample-playback
...
Fix unsafe sample playback in `GameplaySampleTriggerSource`
2022-06-17 12:26:46 +09:00
ec53d87c30
Fix unsafe sample playback in GameplaySampleTriggerSource
...
Resolves https://github.com/ppy/osu/issues/18727 .
Added delay from `Schedule` should be minimal as it is always called
from the `Update` thread (input propagation) anyway.
2022-06-16 16:04:57 +09:00
30382b0445
Fill out GetModsFor() xmldoc and annotate items as non-null
2022-06-15 17:40:15 +02:00
6d2a2ba7d6
Rename Position -> Index
2022-06-09 18:49:11 +09:00
f0ef2e610e
Merge branch 'master' into dho
2022-06-09 18:29:14 +09:00
6351f652a2
Fix combo starting at 0 when spectating
2022-06-06 17:56:25 +09:00
a638392e81
Rename member
2022-06-02 16:35:50 +09:00
055845d4f5
Throw exception on access before ApplyBeatmap()
2022-06-02 16:34:45 +09:00
e551e48697
Use ScoreInfo overload in more places
2022-06-02 11:01:46 +09:00
425390e13b
Refactor to reduce nested conditions
2022-06-01 09:54:47 +09:00
50c3dfca31
Apply code reviews
2022-06-01 09:54:47 +09:00
1e0ee1b214
Expose MaximumScoringValues for user consumption
2022-05-31 19:49:37 +09:00
93240073a6
Rename field + rewrite xmldoc a bit
2022-05-31 19:40:07 +09:00
28d8799e11
Add overloads to + document + expose ExtractScoringValues
2022-05-31 19:40:07 +09:00
d6d56ee22d
Fix unintentional truncation
2022-05-31 19:40:07 +09:00
44ca350822
Reset minimal scoring values from frames
2022-05-31 19:40:07 +09:00
20988be6bb
Fix incorrect value
2022-05-31 19:40:07 +09:00
6ccdb61853
Use new ComputeScore() overload in more cases
2022-05-31 19:40:02 +09:00
2289812801
Add method to compute score from ScoringValues
2022-05-31 19:39:53 +09:00
a809a19eec
Remove getBonusScore()
2022-05-31 19:39:42 +09:00
d0e3e50ca7
Extract score statistics directly into ScoringValues
2022-05-31 19:39:42 +09:00
af0f934e1a
Move raw ScoreProcessor values into ScoringValues struct
2022-05-31 19:39:38 +09:00
