f6b1405fa0
Merge branch 'master' into fix-listing-terminal-breakage
2022-01-04 11:49:02 +09:00
87fbac15fd
Merge branch 'master' into fix-skin-editor-overlay-show-thread-safetyu
2022-01-03 20:12:18 +01:00
de33b420ab
Add safety against performing operation on non-alive foundContent
2022-01-03 20:02:46 +01:00
586f158920
Remove initial foundContent value
...
It always is replaced on the first search anyway, and just remains
forever in the overlay otherwise.
2022-01-03 19:52:42 +01:00
6650a468e0
Fix and simplify very broken beatmap listing content swap-out logic
...
The beatmap listing content swap-out logic was already a source of
several problems, and several attempts of fixing it were made. But as it
turns out it was terminally broken in several aspects.
* The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't
really look much different than an instant fade. Therefore, all fade
durations and manipulations of `BypassAutoSizeAxes` are removed.
* The transform sequence juggling the `BypassAutoSizeAxes` manipulations
was enqueued on the content which is being in the process of fading
out. That was partially fixed in 25e38560
2022-01-03 19:51:46 +01:00
ef9f56e585
Fix bad check if content is placeholder
...
The `lastContent == foundContent` check, last touched in a49a4329a49a4329
2022-01-03 19:51:20 +01:00
97439c3df1
Rename method to reflect what it actually does
2022-01-03 19:30:17 +01:00
6356180b6a
Remove unnecessary code and fix double nesting causing filtering to not work
2022-01-03 12:53:58 +09:00
623d6d6d2d
Add migration of positional hitsounds setting to new level based setting
2022-01-03 12:46:20 +09:00
5dd024aab7
Remove outdated settings migration
2022-01-03 12:46:02 +09:00
bb54f438aa
Merge branch 'master' into positional-sounds-strength-adjustment
2022-01-03 12:40:56 +09:00
e7d7587ea5
Merge branch 'master' into reduce-chat-overhead
2022-01-01 15:02:55 +01:00
1262e76a58
Fix test failure due to missing DI cached IdleTracker
2021-12-31 23:18:03 +09:00
670a30b64b
Remove usage of .Result in ArchiveReader
2021-12-31 01:52:01 +09:00
089b756f93
Invert logic to make reading easier
2021-12-30 16:03:16 +09:00
ef49f2ed0e
Add extra extra safety against attempting to load a previously expired editor
2021-12-30 16:02:31 +09:00
b1a444180f
Fix Show then Reset potentially resulting in incorrect load target
2021-12-29 21:46:34 +09:00
471eea750a
Fix calling SkinEditorOverlay.Show before the overlay is loaded causing an exception
...
As seen at https://github.com/ppy/osu/runs/4652969942?check_suite_focus=true .
2021-12-29 21:18:17 +09:00
63e0492725
Mark ShouldSerialize() methods as implicitly used
2021-12-28 09:02:03 +01:00
bc39c2a877
Revert incorrect property rename
2021-12-28 08:31:27 +01:00
73dca0c7e3
Merge pull request #16266 from Joehuu/fix-identifier-typos
...
Fix and normalise most identifier names in code
2021-12-28 15:21:42 +09:00
0bd928b5cd
Fix incorrect naming / apply review
2021-12-27 21:44:19 -08:00
5082b0e63f
Fix some identifiers using shortened naming
2021-12-27 20:26:28 -08:00
7de43e3aba
Fix most open compound words in identifiers being closed
2021-12-27 20:26:28 -08:00
98524d60a4
Fix clear identifier typos
2021-12-27 20:26:28 -08:00
eb04cc9213
Update framework
2021-12-27 23:04:10 +09:00
8d927920cb
Add comment explainng why to block idle updates when host is not active
2021-12-27 13:31:07 +09:00
5a591713ae
Fix legacy combo counter not fully hiding for rulesets that implement their own
2021-12-26 16:49:20 +01:00
724b601d2a
Rename AllowSampleLookup argument to something saner
2021-12-26 14:29:07 +01:00
dc21c8901e
Always allow looking up storyboard samples from beatmap skin
2021-12-26 14:25:28 +01:00
7c25ce81e1
Further reduce chat poll rate when idle or not visible
2021-12-26 16:26:47 +09:00
e448c28cad
Change IdleHandler to not consider mouse movement as active unless focused
2021-12-26 16:26:33 +09:00
8ad53138a6
Merge pull request #16234 from smoogipoo/fix-initial-button-colour
...
Fix OsuAnimatedButton animating when initially disabled
2021-12-25 15:34:40 +09:00
957a1648c7
Merge pull request #16237 from smoogipoo/fix-finished-play-exception-2
...
Improve reliability of exiting gameplay in multiplayer
2021-12-25 15:32:14 +09:00
ac1a452e20
Merge pull request #16239 from peppy/sanitise-test-directory-usage
...
Fix some more test directory usage weirdness
2021-12-25 12:09:18 +09:00
7088471cad
Protect against test failures due to logger being set too early (and beginning logging)
2021-12-25 02:21:49 +09:00
a9a7a33974
Update framework
2021-12-25 02:04:47 +09:00
a43cc20ae2
Apply changes to GameplayCompleted from reviews
2021-12-24 21:58:20 +09:00
c6854b37c8
Unbind event on disposal
2021-12-24 21:58:09 +09:00
d36fe3af09
Merge pull request #16238 from peppy/fix-incorrect-delegate-capture
...
Fix incorrect delegate capture leading to slow leak of audio tracks
2021-12-24 21:34:04 +09:00
1c0dc204c4
Fix some regressing behaviour due to CleanRunHeadlessGameHost's naming structure changing
2021-12-24 20:24:37 +09:00
8cdad5f4d9
Remove incorrectly used gameSuffix from CleanRunHeadlessGameHost
2021-12-24 20:15:10 +09:00
2ee3e61983
Merge branch 'master' into beatmap-card/extra-on-listing
2021-12-24 19:02:51 +09:00
cc7089c3f4
Cancel more liberally
2021-12-24 19:00:09 +09:00
d602aebebb
Add missing cancellation token and rename load task variable to match purpose
2021-12-24 18:58:31 +09:00
842d508aee
Fix incorrect delgate capture leading to slow leak of audio tracks
...
During profile, it was found that the `Completed` delegate was
incorrectly also capturing `lastTrack`, leading to an unexpected
reference chain that led to a memory leak over a long period of time.
This solves the issue by moving the delegate construction to its own
method, where it won't capture the other variables.
2021-12-24 18:39:29 +09:00
83a1d39f80
Merge pull request #16231 from bdach/ruleset-config-cache-overwriting-3
...
Fix ruleset config cache potentially not working correctly in test contexts
2021-12-24 17:18:42 +09:00
3ca238825b
Unify width of normal and extra card sizes
2021-12-24 09:17:07 +01:00
18c144395a
Rename to dimColour
2021-12-24 17:03:29 +09:00
f44af1ad69
Move bind to LoadComplete
2021-12-24 17:00:59 +09:00
