Commit Graph

927 Commits

Author SHA1 Message Date
cd71ec0edd Remove ILive<> interface (and use abstract Live<> instead) 2022-01-26 13:38:56 +09:00
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
7f65f3a47f Remove all usage of BaseDifficulty (and access Difficulty instead) 2022-01-18 22:57:39 +09:00
90166829c3 Update tests which were importing scores without a valid beatmap 2022-01-17 14:47:19 +09:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
8d4a3cc569 Remove pointless Metadata set 2022-01-14 23:27:33 +09:00
5cbd731864 Add RulesetInfo hashcode implementation and tidy up equality 2022-01-12 17:49:10 +09:00
605898ec53 Add missing "non-null" elements missing from some tests 2022-01-12 17:49:10 +09:00
6251713796 Add missing Ruleset in ReplayRecorder tests 2022-01-12 17:00:17 +09:00
31a3161189 Make tests compile again 2022-01-12 17:00:16 +09:00
213d89b479 Update null fallback cases involving OnlineID 2022-01-12 16:39:36 +09:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
3cd996eb4a Merge branch 'master' into async-deadlock-safety 2022-01-07 17:28:59 +09:00
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
66613cbaa4 Wait for async continuation in score submission test
The previous assert step was optimistically assuming that the async
continuation that writes the value of
`FakeImportingPlayer.ImportedScore` always completes before it, but
that's not necessarily true even if the continuation is instant (it is
still subject to things like task scheduling and TPL thread pool
limits).

To ensure no spurious failures, swap out the assert step for an until
step instead.
2022-01-06 13:09:25 +01:00
84765b99b3 Handle score submission request in submission test scene
Was previously not handled at all, therefore displaying request failures
in the test log output. While that was mostly a red herring and
shouldn't have caused any actual *test* failures, it is still better to
handle this explicitly in a realistic manner.
2022-01-06 12:57:26 +01:00
73b40e6833 Replace usage of .Result with .WaitSafelyForResult 2022-01-04 11:51:41 +09:00
7cdba2f7c3 Add test coverage of score submission if player is exited during import 2022-01-03 22:00:47 +01:00
04d8fd3a58 Improve reliability of TestStoryboardSkipOutro
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
34b0101ff4 Add visual test coverage of "hidden by ruleset" combo option 2021-12-26 16:49:18 +01:00
f3f491374b Remove unused load checks 2021-12-22 18:17:00 +09:00
54790bb758 Merge branch 'master' into fix-realm-post-storage-migration-failure 2021-12-17 00:19:46 +01:00
eb3050b2ac Fix incorrect test 2021-12-14 15:08:00 +09:00
441b7baa93 Provide a realm factory to usages of ToLive/RealmLive 2021-12-14 14:26:34 +09:00
309290a3c9 Use new method in more places that can benefit from it 2021-12-13 16:56:43 +09:00
bff02bedbf Rename APIScoreInfo to APIScore 2021-12-10 16:11:49 +09:00
a969fe3ef8 Add test coverage showing intended UX of user's volume levels being retained when unmuting 2021-12-08 13:37:47 +09:00
9033169177 Merge pull request #15951 from peppy/fix-failing-recorder-tests-w
Fix intermittent test failures in scenes using `SpectatorClient`
2021-12-06 18:40:27 +09:00
568364b604 Fix indentation 2021-12-06 17:38:57 +09:00
0d3d22d3e1 Update TestSceneReplayReocorder to be safer about disposal 2021-12-06 17:09:12 +09:00
50a5f52f92 Remove duplicated test scene (see TestSceeneReplayRecorder) 2021-12-06 17:09:11 +09:00
d58b85b381 Refactor TestScenSpectatorPlayback to properly clean up without async disposal 2021-12-06 17:09:11 +09:00
452fa93444 Merge branch 'master' into realm-integration/skins-rebase 2021-12-06 15:21:02 +09:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
f6a3709060 Store default skins to database 2021-11-29 18:28:25 +09:00
23146d59d1 Use ILive for current skin 2021-11-29 18:28:25 +09:00
f283770f34 Update mock RulesetInfo usage to set OnlineID instead of ID 2021-11-24 15:50:26 +09:00
b9923e5396 Remove subclassing of RulesetInfo 2021-11-22 16:39:17 +09:00
d7b178ea37 Update test scenes which should not handle key repeat 2021-11-18 13:13:36 +09:00
7c2e79f911 Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
62d670a3ca Update DifficultyCalculator to take an IWorkingBeatmap 2021-11-15 19:16:48 +09:00
5be22916bb Add test coverage against frequency ramp increasing between fail animation and fail screen 2021-11-14 14:41:17 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
dbdbfc4723 Add failing test case for PP counter not initially updating 2021-11-11 16:33:31 +01:00
9bad912dd0 Add failing test case 2021-11-11 13:22:06 +01:00
03a315b9f5 Fix missing beatmap in replay download test scene
Was causing nullrefs in `GetDisplayTitle()`.
2021-11-09 14:33:06 +01:00
74c37e248d Merge branch 'master' into master 2021-11-09 08:40:52 +01:00
78aef9ce86 Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-08 13:35:49 +09:00