bb3747ffc9
Fix beatmap search requests double-escaping
...
Closes #14008 .
2021-07-25 17:06:40 +09:00
ce30bd8cc7
Merge pull request #14003 from Game4all/localise-profile-overlay-header-stats
...
Localise profile overlay numeric statistics
2021-07-25 12:20:38 +09:00
48120faeb2
Fix inability to join a multiplayer room which has no password
2021-07-24 19:21:16 +09:00
ff3d38de6f
Localise accuracy display.
2021-07-23 22:37:08 +02:00
17168b8137
Fix authentication loss not handled correctly
...
This handles the case where on initial API connection, the server
responds with an `Unauthorized` response. It doesn't perform this same
checking/handling on every API request, which is probably what we want
eventually.
Opting to not address the full issue because I know this is going to be
a long one (see
05c50c0f6c/osu.Game/Online/API/APIAccess.cs (L233)
2021-07-23 19:03:19 +09:00
6dbdfcc70c
Fix room password not being percent-encoded in join request
2021-07-22 23:11:58 +02:00
57e5f5575a
Fix derived API request types firing success when they shouldn't
...
The usual case of `virtual`/`override` being dangerous when logic is
added to the base implementation. As such, I've removed this completely.
2021-07-22 14:23:27 +09:00
747c475b95
Merge pull request #13932 from peppy/fix-multiple-request-completion-states
...
Fix API request potentially firing failed events after completion
2021-07-21 15:11:03 +09:00
1e634d9db0
Adjust user beatmap sections on profile overlay to match web
2021-07-20 21:55:17 +02:00
b7c2d6b1ab
Merge branch 'master' into add-password-support
2021-07-19 22:23:09 +09:00
0a43e54dfc
Fix request failing due to parameters
2021-07-19 21:24:22 +09:00
a001e4aa16
Fix web request failing if password is null
2021-07-19 20:57:16 +09:00
80c2b1449b
Fix API request potentially firing failed events after completion
...
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.
This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.
Closes https://github.com/ppy/osu/issues/13632 .
2021-07-19 20:27:01 +09:00
2eec524f27
Fix password not copied from multiplayer client
2021-07-19 20:20:08 +09:00
2515785f93
Use room password to fill settings textbox
2021-07-19 20:03:32 +09:00
063f14da98
Update test room manager to not return passwords
2021-07-19 20:03:27 +09:00
3c028ce05c
Add IDeepCloneable interface and update existing CreateCopy methods to use it
2021-07-19 12:54:17 +09:00
125bd36ab1
Send password in request ctor directly
2021-07-13 14:27:07 +09:00
c5319c06c2
Add password attributes to CopyFrom to make testing work better
2021-07-12 18:54:07 +09:00
9f9d7f9125
Add remaining pieces of password flow (for osu-web join request)
2021-07-12 18:22:52 +09:00
f35d55c32f
Fix HasPassword not being in sync with Password value for client-side rooms
2021-07-12 15:49:19 +09:00
08c40938db
Add support for updating a room's password
2021-07-12 15:49:19 +09:00
5148069efe
Update signatures in line with no-overload methods (unsupported by signalr)
2021-07-12 15:49:19 +09:00
2ca11d458a
Add password to room settings and multiplayer lounge interface
2021-07-12 15:49:19 +09:00
6a74fde082
Add has_password flag and region post only parameters
2021-07-12 15:49:19 +09:00
4fd6f2101c
Add password textbox input
2021-07-12 15:49:19 +09:00
0db316d644
Add password scaffolding
2021-07-12 15:49:19 +09:00
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
546f55d341
Change profile section expansion to use dropdown sounds
2021-07-08 20:23:11 +09:00
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
31dbc7798b
Merge branch 'master' into linkify-metadata
2021-07-01 19:41:33 +09:00
ca0eaab8e2
Add test
2021-06-29 16:30:46 +09:00
7a86686f40
Make nullable
2021-06-29 16:30:40 +09:00
9132c42f87
Fix actions posted to the wrong channel
2021-06-29 15:58:07 +09:00
50c27d2635
Update usages of IHasTooltip in line with framework localisation changes
2021-06-25 19:10:04 +02:00
6fda5e569a
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-20 21:37:00 -07:00
9495f87f04
Remove redundant NotNull attributes in nullable classes
2021-06-17 16:07:32 +09:00
fc442713bb
Debounce schedule at base class
2021-06-14 14:26:40 +09:00
8dd48d48f6
Add support for song select leaderboard to handle newly imported scores
2021-06-14 14:20:23 +09:00
26312bf60a
Merge branch 'master' into chat-mention
2021-06-11 20:03:44 +09:00
8eab7df955
Move BindCollectionChanged out of async load
2021-06-11 17:51:58 +09:00
20759657de
Rename configuration variables and refactor lots more
2021-06-11 16:37:31 +09:00
3d645608eb
Remove nullability of DI dependencies and fix incorrect load order
2021-06-11 16:28:53 +09:00
139401a04a
Inline and refactor overly verbose MessageNotifier code
2021-06-11 16:27:31 +09:00
061e3d7f26
Move legacy ScoreInfo to be completely based on presence of classic mod
2021-06-08 18:00:09 +09:00
4925a7d59e
Minor code quality changes
2021-06-05 15:57:14 +02:00
5e44329e0b
Add DummyAPIAccess request handler
...
Make CreateChannelRequest.channel public
2021-06-05 14:43:26 +02:00
ce4bcda803
Use separate method for fetching channel objects
...
Resolves a pull request review
2021-06-05 14:02:48 +02:00
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention
2021-06-05 11:18:06 +02:00
b746fe7c03
Fix binding order
2021-06-05 11:03:49 +02:00
