Commit Graph

35091 Commits

Author SHA1 Message Date
f8e37af2e0 Merge pull request #20171 from peppy/beatmap-carousel-nrt
Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`
2022-09-07 17:15:00 +09:00
68c27522e7 Merge pull request #20158 from smoogipoo/taiko-geki-katu
Decode taiko Geki/Katu from legacy scores into `LargeBonus`
2022-09-07 17:06:42 +09:00
5b758afd09 Merge branch 'master' into taiko-geki-katu 2022-09-07 16:22:47 +09:00
824e68dab3 Fix VectorScale set to 0 still showing some sprites in storyboard
This implementation was matching the [framework side implementation of
scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976))
but I don't think it's required here.

I'm still not sure if the framework implementation is correct, but
removing it locally does seem to fix broken storyboard cases.

Closes https://github.com/ppy/osu/issues/20155.
2022-09-07 15:39:19 +09:00
dc71abdf56 Merge pull request #20144 from peppy/fix-notification-overlay-presence
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
f3bda4e040 Fix weird edge case of nullability in CarouselRoot
A bit unfortunately, but it's what we get for having ctor level bindings..
2022-09-07 14:27:25 +09:00
e18b524f8e Fix missing null checks on selectedBeatmap fields in BeatmapCarousel 2022-09-07 14:12:35 +09:00
241d33d415 Apply NRT to BeatmapCarousel 2022-09-07 14:07:53 +09:00
cb1d886c9c Add audio feedback for Esc/Back clearing text from a FocusedTextBox 2022-09-07 13:17:04 +09:00
90207b6032 Merge branch 'master' into feature/EditorDeleteDiff 2022-09-06 18:48:06 +03:00
7c0e99c5a8 Decode Geki/Katu from legacy taiko scores into LargeBonus 2022-09-07 00:12:34 +09:00
db15bd56e8 Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code 2022-09-06 18:12:47 +09:00
579e7e1f17 Fix deleting a difficulty not updating the beatmap set hash 2022-09-06 18:12:47 +09:00
a3de5f808e Fix typo in LoopStartTime addition 2022-09-06 17:46:03 +09:00
6e52dbb266 Update IsDisplayingToasts to check the flow count directly 2022-09-06 17:30:24 +09:00
677708c5e4 Rewrite logic using a list 2022-09-06 16:58:51 +09:00
d667f46830 Refactor alpha check to not overwrite sourced overrides with values from later commands 2022-09-06 16:41:32 +09:00
bea42d2862 Handle earliest-alpha-start-time logic in StoryboardSprite itself 2022-09-06 16:16:58 +09:00
a5e57b083c Remove EarliestDisplayTime's input to CommandStartTime 2022-09-06 16:16:58 +09:00
9e3228aa65 Fix completion notification not being posted if completion occurs during NotificationOverlay load 2022-09-06 04:07:49 +09:00
6296c971f8 Merge pull request #20136 from smoogipoo/fix-cancellation-perf
Improve performance when cancelling import with debugger attached
2022-09-05 22:03:50 +09:00
510972e3ad Avoid reference counting by using height calculation for IsPresent instead
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.

Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
f754686521 Remove necessity of AlwaysPresent for ProgressUpdate completion posting 2022-09-05 19:13:58 +09:00
0d4ee6bd80 Centralise ability to fetch all toast tray notifications (including animating ones) 2022-09-05 18:42:20 +09:00
eca7b8f988 Fix completion notifications not always showing as toasts 2022-09-05 18:39:11 +09:00
4fa6707bf0 Set all progress notifications to non-important 2022-09-05 18:29:35 +09:00
87e26e34b8 Merge pull request #20141 from peppy/fix-editor-timeline-sv-display
Fix incorrect slider length in timeline when non-default velocity is inherited from previous object
2022-09-05 17:51:25 +09:00
2bec8b82b3 Fix textbox sample playback potentially crashing if called before load 2022-09-05 16:26:41 +09:00
57954bb8f5 Enable nullability on TimelineHitObjectBlueprint 2022-09-05 14:50:43 +09:00
8cbd344330 Improve performance when cancelling import with debugger attached 2022-09-05 11:28:13 +09:00
07d4a025b0 Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency
Fix room status dropdown placement inconsistent between multiplayer and playlists
2022-09-05 11:19:56 +09:00
ff4a051c05 Merge branch 'master' into remove-dispose-updates 2022-09-03 16:14:50 +03:00
e8fa872f61 Fix room status dropdown position inconsistent on online-play screens 2022-09-03 16:14:21 +03:00
778d767a12 Revert disposal on SectionsContainer properties 2022-09-03 15:02:57 +03:00
4f18105e9d Ensure next beatmap selected matches the menu ordering 2022-09-02 17:57:00 +09:00
840d1c4cd5 Disable delete difficulty menu item when only one difficulty is present 2022-09-02 17:14:48 +09:00
9fd8067e11 Tidy up dialog and deletion flow 2022-09-02 17:07:09 +09:00
605108c938 Refactor/rename deletion method to read better 2022-09-02 16:59:01 +09:00
b388428e1c Merge branch 'master' into feature/EditorDeleteDiff 2022-09-02 16:48:38 +09:00
b10026993a Don't serialise has_replay 2022-09-02 16:41:53 +09:00
8c50ccc48e Fix incorrect specification in SectionsContainer 2022-09-02 16:37:39 +09:00
d80151756c Merge pull request #20070 from smoogipoo/replay-and-legacy-id
Add `has_replay` and `legacy_score_id` to `SoloScoreInfo`
2022-09-02 14:55:29 +09:00
23d5e8b286 Fix beat sync components stopping after beatmap change
Not an amazing fix, but it seems to work and would rather get this in
ASAP rather than trying to fix at a framework level.

Closes #20059.
2022-09-01 23:46:02 +09:00
7eaa4c5ccd Update new usages of Remove / RemoveInternal 2022-09-01 23:05:34 +09:00
c9dec473d3 Update virtual track logic to match framework changes 2022-09-01 23:05:07 +09:00
22c18d9a81 Update framework 2022-09-01 23:03:28 +09:00
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
e1e46ad7aa Merge pull request #20073 from peppy/fix-tournament-lookup
Fix tournament population failure when beatmap is not found on server
2022-09-01 22:44:53 +09:00