b30fba1430
emc attribute
2022-08-19 22:57:40 +10:00
fea31cc895
introduce effective misscount, accuracy rescale
2022-08-19 22:57:28 +10:00
7bf318541c
Reword comment to hopefully read better
2022-08-19 20:57:55 +09:00
c3c44c19cd
Use CompositeComponent
in various locations
2022-08-19 20:43:15 +09:00
41321521e5
Update resources
2022-08-19 20:40:05 +09:00
426c4c9bf7
Update framework
2022-08-19 20:39:53 +09:00
3f0da14065
Delay start operation by one frame to allow children to see initial start time
2022-08-19 17:39:51 +09:00
f3e1287f04
Remove redundant using statement
2022-08-19 16:19:45 +08:00
684efefb50
Add FirstHitObject as a property of encoding classes
2022-08-19 16:13:36 +08:00
a26de0a10f
Add HitType property to MonoStreak
2022-08-19 16:05:34 +08:00
51176e9577
Naming changes
2022-08-19 15:45:43 +08:00
5dcd4ce7c5
Naming changes
2022-08-19 15:31:03 +08:00
41408a3106
Add audio feedback for text selection
2022-08-19 15:51:27 +09:00
89eb0a4079
Added TestScene for slider splitting
2022-08-19 01:10:54 +02:00
4c24d8ed58
Improve string consistency
2022-08-19 03:17:05 +10:00
7add3a6950
ar var test
2022-08-18 19:00:54 +02:00
e7d4962128
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-19 01:50:14 +09:00
3eb1cda6aa
Reorganise call order of Start
/ Reset
to make more sense
2022-08-19 01:46:36 +09:00
15d49b0357
Update TestSceneSpectator
to user new assert style
2022-08-19 01:46:19 +09:00
3de35a1518
Update calculator and tests to match changes on clocks
2022-08-18 18:40:02 +02:00
1d774f3f12
Remove redundant ProcessFrame
calls
...
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
2022-08-19 01:39:02 +09:00
7bc96431a7
Remove unnecessary virtual
spec from GameplayClockContainer.Seek
2022-08-19 01:39:01 +09:00
0e228791c0
Remove unnecessary Reset
call in MultiSpectatorScreen
2022-08-19 01:39:01 +09:00
cc86909633
Increase lenience on TestSceneLeadIn
tests
...
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).
I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
bc851c174b
Merge pull request #19836 from peppy/split-offset-clock
...
Split `OffsetCorrectionClock` out of `MasterGameplayClockContainer`
2022-08-18 18:26:51 +02:00
4ad782b5a0
Merge branch 'master' into split-offset-clock
2022-08-18 17:52:45 +02:00
0f0b4fdfec
Merge pull request #19838 from peppy/test-scene-lead-in-updates
...
Update `TestSceneLeadIn` to use new assert style
2022-08-18 20:55:55 +09:00
2eba8650ca
Update TestSceneLeadIn
to use new assert style
2022-08-18 19:26:19 +09:00
43879633db
Ensure setting a StartTime
on a GameplayClockContainer
always resets to the new time
2022-08-18 18:54:10 +09:00
343efa1d11
Split OffsetCorrectionClock
out of MasterGameplayClockContainer
2022-08-18 18:54:10 +09:00
2c6fd1ec6e
Fix `GameplayClockContainer potentially resetting external seeks
2022-08-18 18:54:10 +09:00
728cd96508
Update TestSceneLeadIn
to use new assert style
2022-08-18 18:54:10 +09:00
bcc153f738
Add xmldoc and reorganise FramedBeatmapClock
2022-08-18 18:54:10 +09:00
6003afafc7
Use FramedBeatmapClock
in GameplayClockContainer
2022-08-18 18:54:10 +09:00
32e127a6fa
Add FramedBeatmapClock
...
Expose `IsCoupled` in `FramedBeatmapClock` for now to provide editor compatibility
2022-08-18 18:54:10 +09:00
fa167b1d12
Merge pull request #19779 from peppy/no-gameplay-clock
...
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
3e34959a6e
Merge pull request #19833 from smoogipoo/fix-backwards-asserts
...
Fix some backwards asserts
2022-08-18 18:42:23 +09:00
5d8d584afb
Fix some backwards asserts
2022-08-18 18:08:46 +09:00
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
...
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
8480703e0b
Merge pull request #19831 from peppy/fix-zero-length-taiko-spans
...
Fix taiko drum rolls with zero length being placeable in editor
2022-08-18 17:56:46 +09:00
ad28bfc9b2
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:18:11 +09:00
48fac9f8a5
Fix taiko drum rolls with zero length being placeable in editor
...
Addresses https://github.com/ppy/osu/discussions/19808 .
2022-08-18 16:50:36 +09:00
8d026eeeea
Merge pull request #19827 from smoogipoo/upgrade-analyser
...
Upgrade LocalisationAnalyser and disable warning
2022-08-18 16:35:34 +09:00
bb46f72f9e
Fix Pippidon
crash on empty beatmap conversion
2022-08-18 16:17:50 +09:00
b0a740071e
Centralise logging of failed ruleset loads
2022-08-18 16:14:38 +09:00
e0edaf996f
Test ruleset compatibility during initial startup to avoid runtime errors
...
As we continue to break the ruleset API, it makes more sense to
proactively check known changes and bail early during ruleset loading to
avoid a user experiencing a crash at a random point during execution.
This is a RFC and needs to be tested against known broken rulesets.
There might be some other calls we want to add in addition to the ones
I've listed.
2022-08-18 16:03:38 +09:00
e55b94d412
Also upgrade tools
2022-08-18 15:18:35 +09:00
40b1554fea
Change FindRepetitionInterval to start with one previous encoding
2022-08-18 14:12:03 +08:00
7512c126b7
Upgrade LocalisationAnalyser and disable warning
2022-08-18 15:08:24 +09:00
9735728cf6
Reverse conditionals to better define intent in addSourceClockAdjustments
2022-08-18 15:08:09 +09:00