Commit Graph

48480 Commits

Author SHA1 Message Date
f30894840c Update terminology to realm "instance" rather than "context"
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
bb54ad9ad8 Merge pull request #16547 from peppy/realm-stable-subscriptions
Fix realm subscriptions getting lost after a context recycle
2022-01-24 20:20:04 +09:00
94ad7abfd6 Merge pull request #16590 from peppy/realm-migrate-on-failure
Allow realm migration to run again if interrupted halfway
2022-01-24 20:19:52 +09:00
c3758047fd Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic
The editor doesn't currently propagate velocity to nested objects. We're
not yet sure whether it should or not. For now, let's just ignore nested
objects' `DifficultyControlPoints` for simplicity.

Note that this only affects osu! ruleset due to the pre-check on
`isOsuRuleset`.
2022-01-24 19:54:08 +09:00
deaff340d2 Add test coverage of saving velocity 2022-01-24 19:43:18 +09:00
948867898c ModeMultiplier rename 2022-01-24 11:38:52 +01:00
b396d55758 Merge branch 'master' into realm-stable-subscriptions 2022-01-24 19:01:49 +09:00
66c5d77d63 Allow realm migration to run again if interrupted halfway 2022-01-24 18:55:15 +09:00
9afa034296 Fix attempt to revive update thread realm context from non-update thread 2022-01-24 18:36:16 +09:00
b0919722ac Guard against potential exception while blocking realm 2022-01-24 18:25:48 +09:00
9ff9611296 Merge branch 'master' into realm-stable-subscriptions 2022-01-24 18:25:47 +09:00
37b74aafcc Merge pull request #16588 from peppy/dont-exit-screens-test-browser
Avoid adding "exit all screens" step when running tests interactively
2022-01-24 18:24:41 +09:00
e3083c2477 Fix copy pasted xmldoc 2022-01-24 18:05:30 +09:00
bf5bf8d1fd Rename dictionaries to match methods 2022-01-24 17:58:53 +09:00
f4e7211ef1 Add xmldoc for RegisterForNotifications 2022-01-24 17:52:36 +09:00
abf14f0982 Lock unregistration for sanity 2022-01-24 17:46:53 +09:00
52cd906af6 Move context retrieval inside lock 2022-01-24 17:45:31 +09:00
161a2a321e Remove bindable from ModeMultiplier 2022-01-24 09:07:07 +01:00
e22aea0613 Apply same fix to OsuGameTestScene 2022-01-24 17:05:49 +09:00
1e483ece32 Avoid adding "exit all screens" step when running tests interactively 2022-01-24 16:40:16 +09:00
5a12496873 Merge pull request #16571 from bdach/custom-meter
Add back editor support for non-standard time signatures
2022-01-24 16:09:47 +09:00
d7db6fa918 Merge branch 'master' into custom-meter 2022-01-24 15:46:44 +09:00
6581e8c2d3 Merge pull request #16549 from Susko3/LoginPanel-flag
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
cb319cebdb Refactor naming and add more comments to help understanding in RealmContextFactory subscription logic 2022-01-24 14:48:55 +09:00
40aa873190 Rename register methods to better explain their purpose 2022-01-24 14:37:36 +09:00
d7a9c5fd41 Add settings buttons to allow temporarily blocking realm access 2022-01-24 14:36:57 +09:00
997c13f643 Add locking over realmSubscriptionsResetMap for sanity 2022-01-24 13:36:51 +09:00
ed84ae0ac0 Adjust values to Bdach's refined taste 2022-01-24 00:42:43 +01:00
873d5bb104 Merge pull request #16586 from bdach/beatmap-path-tostring 2022-01-24 02:03:04 +03:00
838a9f69ed Fix saved beatmap filename depending on ToString() implementation 2022-01-23 20:28:30 +01:00
e236f5d604 Add failing test coverage for correct beatmap filename generation on save 2022-01-23 20:28:19 +01:00
00a6d4e51c Merge pull request #16545 from peppy/fix-intro-realm-usage
Fix `IntroScreen` retrieving and iterating all realm beatmap sets
2022-01-23 15:38:03 +01:00
bd748686fa Adjust spacing of time signature numerator input box 2022-01-23 15:21:32 +01:00
4e5a1f27a8 Initialise Simple{Triple,Quadruple} only once ever rather than create every time 2022-01-23 15:21:25 +01:00
351c766ea1 Fix one remaining instance of realm query as property 2022-01-23 23:20:03 +09:00
deb1670862 Use Array.Empty instead of constructed list 2022-01-23 23:18:50 +09:00
249f0f9697 Add more lengthy comment explaining cyclic avoidance
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-01-23 23:15:39 +09:00
0bbe703ffe Merge branch 'master' into fix-intro-realm-usage 2022-01-23 15:13:25 +01:00
5e7993c35a Post disposal to synchronisation context 2022-01-23 20:43:25 +09:00
0709a2ac9b Add test coverage of realm subscription scenarios 2022-01-23 20:28:13 +09:00
db86394355 Fix TestResources returning a test BeatmapSetInfo that can't be laoded directly into realm 2022-01-23 20:28:04 +09:00
e9e3e024a1 Update all usages of QueryAsyncWithNotifications to use new Register pathway 2022-01-23 20:28:04 +09:00
61cef42be9 Proof of concept realm subscriptions via Register 2022-01-23 20:28:04 +09:00
f39ff1eacb Add unregistration on blocking
This is the first part of the requirement of sending a `ChangeSet` event
to ensure correct state during blocking time
2022-01-23 20:27:57 +09:00
bd0eda7e90 Use method instead of property for realm query retrieval 2022-01-23 18:01:39 +09:00
70a120ea8a Add missing lock coverage when using subscriptionActions dictionary 2022-01-23 18:00:24 +09:00
a5493ce0d1 Fix incorrect nesting of statements causing completely broken logic 2022-01-23 17:51:32 +09:00
e4758c9dbb Mark LabelledTimeSignature as public 2022-01-23 10:14:37 +03:00
1ea5a2e6a7 Fix incorrect assert step name 2022-01-23 10:11:12 +03:00