Commit Graph

185 Commits

Author SHA1 Message Date
b19047b90b Fix skin editor component list having uneven padding 2023-02-03 16:55:51 +09:00
5d2e09137c Remove text padding in editor menu for now 2023-01-15 14:40:53 +03:00
78e562903d Localise part of editor 2023-01-15 01:50:47 +03:00
76eefc7573 Add support for localisation where it was missing 2023-01-15 01:46:11 +03:00
2365b065a4 Enable nullability for editor components 2023-01-12 18:07:54 +03:00
abca13eb6c Rewrite visualisation piece to bind once and without potential event leak 2023-01-07 14:40:15 +03:00
efdd557f3b Adjust binding logic 2023-01-01 19:45:23 +01:00
452ebddfd2 Adjust visual appearance of preview time part
- Use slightly different hue of green to distinguish from difficulty
  control points. The colour is still not ideal, but picking
  a distinctive enough hue is pretty hard.

- Place the preview time part at the bottom rather at the top.
  Not sure why it was at the top; not only could it overlap with the
  control points, but it also looked quite badly misaligned there
  when bookmarks were displayed at the bottom.
2023-01-01 19:42:55 +01:00
0e59b55a12 Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
23c485c763 readonly 2022-12-30 22:59:56 +09:00
a91da2284d safe way to pass bindable 2022-12-30 22:58:46 +09:00
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
79e27c2d9d PreviewTimePart will not show if preview time is -1 2022-12-16 10:44:07 +09:00
c164744064 Add ability to set preview time 2022-12-16 01:03:30 +09:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
b166e477c2 Merge branch 'master' into editor-background 2022-11-08 17:18:34 +09:00
fc191807c6 Fix velocity test failing with no audio device 2022-11-03 13:59:22 +09:00
c3eb0c6330 Merge branch 'master' into editor-background 2022-11-02 17:43:38 +09:00
21d68bfb84 Delete unused button 2022-10-28 16:40:21 +02:00
de881cc5cb useless #nullable disable 2022-10-24 23:17:28 +09:00
15f9697c9f Roughly update design of editor buttons 2022-10-13 16:57:25 +09:00
acf9ad1429 Apply nullability to EffectPointVisualisation 2022-07-29 23:26:38 +09:00
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
f71f6302fd Remove unnecessary null casts 2022-06-24 14:50:11 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
cd0e0fe70f Fix skin editor not accounting for aspect ratios in base-game sizing logic 2022-06-06 18:02:42 +09:00
e551a53601 Fix checkmarks not showing on editor stateful menu items 2022-05-26 21:45:30 -07:00
fb586fe0b2 Merge branch 'master' into editor-bottom-bar-new-design 2022-05-26 18:32:28 +09:00
7f4ea5d522 Use left alignment and remove hacky text positioning code 2022-05-26 18:12:28 +09:00
acd554d918 Update time info and add bpm 2022-05-25 23:54:59 +09:00
2c61a9d3d1 Update bottom bar components to new design language (mostly) 2022-05-25 23:54:59 +09:00
463b8130c8 Update editor screen switcher to match new design language 2022-05-25 22:31:27 +09:00
206f2ca208 Rename screen switcher control to be in line with naming expectations 2022-05-25 22:20:33 +09:00
c4cae7f677 Update EditorMenuBar to match new design language 2022-05-25 22:19:24 +09:00
ba1642a680 Allow section headers to wrap 2022-03-16 17:19:08 +09:00
a0a033520f Rider no add licence headers 2022-03-15 16:48:14 +09:00
4ab5d6e3f0 Remove unnecessary FillFlowContainer from section 2022-03-15 16:47:08 +09:00
9e476ced63 Add EditorSidebar component 2022-03-15 16:38:00 +09:00
f15b8781bb Move editor mode selector out of EditorMenuBar to allow for better reuse 2022-03-02 20:05:01 +09:00
5f5765d6a2 Reduce redundancy time range to create a bit more visual blending on the timeline 2022-01-19 14:57:01 +09:00
03ac91a3ee Consider all points in a group to meet redundancy check 2022-01-19 14:56:44 +09:00
93cd07f7fb Merge branch 'master' into summary-timeline-control-point-optimisation 2022-01-19 14:50:45 +09:00
566d341b1e Split conditions out for readability 2022-01-16 22:04:29 +09:00
565611ee00 Fix typo in inline comment 2022-01-15 23:57:20 +09:00
236fa6da7e Rename ControlPointVisualisation interface type to be less specific 2022-01-15 23:56:00 +09:00
c5cae4e3ee Rename methods and add xmldoc 2022-01-15 23:55:11 +09:00
64c499d9d6 Revert unintended temporary commenting (was used during benchmarking) 2022-01-15 15:24:30 +09:00
c64a919a9d Reduce number of redundant control points displayed on summary timeline
As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps
with too many control points (usually added via external automation
apps) could cause the lazer editor to grind to a halt.

The overheads here are mostly from the GL side. An eventual goal would
be to render this in a smarter way, rather than using thousands of
drawables. Until that, this optimisation should help reduce the overhead
by omitting control points in close proximity that are redundant for
display purposes.

I've tried to contain this in the display logic directly, with the goal
that it can be ripped out as fast as it was added. Certainly required
more changes than I hoped for, but I don't think it's too ugly.
2022-01-14 17:13:26 +09:00