Commit Graph

99 Commits

Author SHA1 Message Date
78e562903d Localise part of editor 2023-01-15 01:50:47 +03:00
2365b065a4 Enable nullability for editor components 2023-01-12 18:07:54 +03:00
abca13eb6c Rewrite visualisation piece to bind once and without potential event leak 2023-01-07 14:40:15 +03:00
efdd557f3b Adjust binding logic 2023-01-01 19:45:23 +01:00
452ebddfd2 Adjust visual appearance of preview time part
- Use slightly different hue of green to distinguish from difficulty
  control points. The colour is still not ideal, but picking
  a distinctive enough hue is pretty hard.

- Place the preview time part at the bottom rather at the top.
  Not sure why it was at the top; not only could it overlap with the
  control points, but it also looked quite badly misaligned there
  when bookmarks were displayed at the bottom.
2023-01-01 19:42:55 +01:00
0e59b55a12 Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
23c485c763 readonly 2022-12-30 22:59:56 +09:00
a91da2284d safe way to pass bindable 2022-12-30 22:58:46 +09:00
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
79e27c2d9d PreviewTimePart will not show if preview time is -1 2022-12-16 10:44:07 +09:00
c164744064 Add ability to set preview time 2022-12-16 01:03:30 +09:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
fc191807c6 Fix velocity test failing with no audio device 2022-11-03 13:59:22 +09:00
acf9ad1429 Apply nullability to EffectPointVisualisation 2022-07-29 23:26:38 +09:00
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
2c61a9d3d1 Update bottom bar components to new design language (mostly) 2022-05-25 23:54:59 +09:00
5f5765d6a2 Reduce redundancy time range to create a bit more visual blending on the timeline 2022-01-19 14:57:01 +09:00
03ac91a3ee Consider all points in a group to meet redundancy check 2022-01-19 14:56:44 +09:00
566d341b1e Split conditions out for readability 2022-01-16 22:04:29 +09:00
565611ee00 Fix typo in inline comment 2022-01-15 23:57:20 +09:00
236fa6da7e Rename ControlPointVisualisation interface type to be less specific 2022-01-15 23:56:00 +09:00
c5cae4e3ee Rename methods and add xmldoc 2022-01-15 23:55:11 +09:00
64c499d9d6 Revert unintended temporary commenting (was used during benchmarking) 2022-01-15 15:24:30 +09:00
c64a919a9d Reduce number of redundant control points displayed on summary timeline
As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps
with too many control points (usually added via external automation
apps) could cause the lazer editor to grind to a halt.

The overheads here are mostly from the GL side. An eventual goal would
be to render this in a smarter way, rather than using thousands of
drawables. Until that, this optimisation should help reduce the overhead
by omitting control points in close proximity that are redundant for
display purposes.

I've tried to contain this in the display logic directly, with the goal
that it can be ripped out as fast as it was added. Certainly required
more changes than I hoped for, but I don't think it's too ugly.
2022-01-14 17:13:26 +09:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
32b5a736c8 Add preview gameplay button to bottom editor bar 2021-11-11 17:12:21 +01:00
0dc1577f68 Split out control point visualisation logic and add special kiai duration handling 2021-04-15 18:42:30 +09:00
153ee25510 Update base specifications to a more sane default 2021-04-15 18:42:07 +09:00
bf5af3310a Update break colour to not look like kiai time 2021-04-15 17:04:11 +09:00
18e8682f39 Remove unused using statements 2021-04-15 17:01:25 +09:00
757475e6d4 Use correct representation colours 2021-04-15 16:39:20 +09:00
da6f9060fa Centre end circles to avoid visual gaps 2021-04-15 16:39:20 +09:00
73821beb1d Fix break display looking bad on very long beatmaps due to fixed corner radius 2021-04-15 16:39:20 +09:00
bc3b2af39d Add rounded corners to timeline ticks display 2021-04-15 15:29:22 +09:00
27e851c2ee Also adjust height 2021-04-13 16:43:29 +09:00
ebf97ff48f Update timeline ticks to use width as a differentiation method, rather than height 2021-04-13 16:29:35 +09:00
b489e92c9e Fix TimelineParts not using correct beatmap 2021-01-25 18:44:36 +09:00
04fa32bc34 Rename and add xmldoc for smooth seeking method 2021-01-15 16:14:21 +09:00
ddbd6df24d Unbind bindable lists for general safety 2020-11-07 20:59:57 +01:00
487a5ecdba Replace all usage of IBindableList.GetBoundCopy 2020-11-04 15:29:14 +09:00
5d888f687a Account for the width of points so they don't suddenly appear at timeline edges 2020-10-09 16:49:51 +09:00
9baf704942 Add local pooling to TimelineTickDisplay 2020-10-09 15:48:24 +09:00
fa742a2ef1 Update to consume framework fixes 2020-09-30 20:28:02 +09:00
5242f5648d Fix timeline control point display not updating with changes 2020-09-30 18:34:13 +09:00
cc9ae32811 Fix summary timeline not updating to new track length correctly 2020-09-24 21:05:29 +09:00
d18eb663b1 Add tweening seek support to EditorClock 2020-05-22 16:47:52 +09:00
dd09d7830d Cache and resolve editor clock as EditorClock in all cases 2020-05-22 16:44:06 +09:00