Commit Graph

38753 Commits

Author SHA1 Message Date
e19e8ff2a3 Rewrite FramedReplayInputHandler for robustness
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.

I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.

This commit fixes #6150.
2021-04-12 16:18:11 +09:00
42604afcdc Add binding for verify mode (and move enum entry to end) 2021-04-12 16:15:27 +09:00
8bf85d737c Change Metadata into a get property 2021-04-12 15:52:29 +09:00
78bbc8f5c8 Tidy some remaining code 2021-04-12 15:52:18 +09:00
8c31e96cdf Change some methods to get properties 2021-04-12 15:52:18 +09:00
f78239c7f2 Move enums out of nesting 2021-04-12 15:52:18 +09:00
3551322f1d Fix formatting of colour getter 2021-04-12 15:52:18 +09:00
257acf9cd8 Colour constants to private 2021-04-12 15:52:18 +09:00
136627b9ac Wrap xmldoc less and make a few fixes 2021-04-12 15:52:18 +09:00
1c553b5d48 Checker -> BeatmapVerifier 2021-04-12 15:29:05 +09:00
14bd5bdc77 Merge branch 'master' into verify-tab 2021-04-12 15:14:37 +09:00
5d942e92f3 Merge pull request #12374 from smoogipoo/fix-multi-test-failures
Fix multiplayer test failure
2021-04-12 14:39:41 +09:00
dd1925aaed Remove temporary input ignore 2021-04-12 14:29:27 +09:00
9be3163592 Merge branch 'master' into multiplayer-spectator-player-grid 2021-04-12 14:14:13 +09:00
995c244cee Remove alt-mousewheel bindings for volume adjustment
With the recent changes to the order of processing key bindings
(`GlobalAction`s are handled first), having the alt-wheel bindings in here causes a
regression as they are handled before `OnScroll` events.

Specifically, this means editor alt-scroll functionality no longer works
with the default bindings.

Removing the bindings fixes this, while also still allowing alt-wheel
adjustment of the volume via `VolumeControlReceptor`:

a2f50af424/osu.Game/Overlays/Volume/VolumeControlReceptor.cs (L21-L26)

In conjunction with the special case in `OsuScrollContainer`:

02d5b1352b/osu.Game/Graphics/Containers/OsuScrollContainer.cs (L103-L105)
2021-04-12 14:00:32 +09:00
4fcddfb44b Fix multiplayer test failure 2021-04-12 13:42:14 +09:00
e2470d757e Merge branch 'master' into legacy-spm-counter 2021-04-12 12:52:52 +09:00
d6d8ea5b6b Throw when getting a frame of an empty replay 2021-04-12 11:17:56 +09:00
fbd5195738 Extract mod setting value handling to utils class 2021-04-12 03:37:03 +03:00
b7e16c2fcc Remove Xamarin.Essentials package from main project 2021-04-11 15:51:58 -04:00
419fd4470c Reorder method declaration 2021-04-11 15:19:51 -04:00
cb947a3b27 Add expected output in test case rather than determining internally 2021-04-11 13:18:25 -04:00
07ee1b4d0b Make power status properties abstract 2021-04-11 13:18:25 -04:00
3d85dc11c6 Adjust documentation 2021-04-11 13:18:25 -04:00
2b947a44da Cache power status at base instead 2021-04-11 13:18:25 -04:00
18fb9f5ac9 Merge branch 'master' into mod-using-reference-equality 2021-04-11 19:48:55 +03:00
4853ac802c Merge pull request #12367 from Joehuu/lazy-flashlight
Add follow delay setting to osu! flashlight mod
2021-04-11 19:07:06 +09:00
1fd4cb8963 Merge branch 'master' into master 2021-04-11 10:19:16 +03:00
a42714540b Add follow delay setting to osu! flashlight mod 2021-04-10 23:04:15 -07:00
dac733cced Fix field name and accessibility 2021-04-10 15:49:57 +02:00
7d40b01722 Remove old todo 2021-04-10 15:18:15 +02:00
3289bb0379 Merge Check and BeatmapCheck
We're probably not going to need GeneralChecks or BeatmapsetChecks.

The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
747e0f00dc Improve table formatting 2021-04-10 13:10:05 +02:00
3a4f2e3d7e Show table even if no issues 2021-04-10 13:09:16 +02:00
c995eca029 Remove todo
Doesn't really matter in the end, as only one checker will run at a time in this case.
2021-04-10 13:05:24 +02:00
6d3cf78e4a Add issue selection
This mainly helps with keeping track of which issue was clicked, since doing so switches tab.
2021-04-10 13:04:39 +02:00
bc4f3351f3 Replace checks with realistic ones 2021-04-10 13:03:16 +02:00
b30e41b805 Fix comment; mode -> ruleset 2021-04-10 13:02:36 +02:00
d1007ff26a Move components to more appropriate spot 2021-04-10 13:02:22 +02:00
43174b708c Remove visibility settings
Can look into this later, not really important for a first iteration.
2021-04-10 12:58:40 +02:00
08311abc5e Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene 2021-04-10 00:00:21 -04:00
ab49e84d17 Merge pull request #12356 from peppy/update-framework
Update framework
2021-04-10 03:34:24 +09:00
b66ef2fdec Update framework 2021-04-10 02:14:28 +09:00
dfe3240b45 Merge pull request #12353 from nekodex/songselect-hoversamples
Add a hover sample type for SongSelect buttons
2021-04-10 01:45:47 +09:00
9aa30fb323 Merge pull request #11688 from Syriiin/diffcalc/dynamic-history
Implement dynamic previous hitobject retention for Skill class
2021-04-10 01:25:07 +09:00
affc878db9 Update resources 2021-04-10 01:03:15 +09:00
bfd3d0cce9 Implement custom enumerator for ReverseQueue to avoid allocations 2021-04-10 01:16:54 +10:00
8bd972c525 Merge pull request #12354 from nekodex/reduce-sample-pitch-randomisation
Reduce the randomised pitch range of hover sounds
2021-04-09 23:43:51 +09:00
ffacd38e57 Reduce the randomised pitch range of hover sounds 2021-04-09 23:03:14 +09:00
8a0da06e89 Add a hover sample type for SongSelect buttons 2021-04-09 23:00:40 +09:00