misskey-dev/summaly
1
0
Fork 0
mirror of https://github.com/misskey-dev/summaly.git synced 2025-05-15 18:47:35 +09:00
Code Issues Packages Projects Releases Wiki Activity

fix the syntax

Browse Source
This commit is contained in:
Kagami Sascha Rosylight 2023-03-11 15:08:29 +01:00
parent 5153305bdd
commit 1ea7059a20
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/general.ts
View File

@ -71,9 +71,10 @@ async function getOEmbedRich($: cheerio.CheerioAPI, pageUrl: string): Promise<OE
return null;
}
const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s+/g);
// TODO: This implementation only allows basic syntax of `allow`.
// Might need to implement better later.
const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s*;\s*/g).filter(s => s);
const safeList = [
'',
'autoplay',
'clipboard-write',
'fullscreen',

2
test/oembed/invalid/oembed-too-powerful2.json
View File

@ -1,6 +1,6 @@
{
"version": "1.0",
"type": "rich",
"html": "<iframe src='https://example.com/' allow='fullscreen camera'></iframe>",
"html": "<iframe src='https://example.com/' allow='fullscreen;camera'></iframe>",
"height": 300
}

2
test/oembed/oembed-allow-safelisted-features.json
View File

@ -1,6 +1,6 @@
{
"version": "1.0",
"type": "rich",
"html": "<iframe src='https://example.com/' allow='autoplay clipboard-write fullscreen encrypted-media picture-in-picture'></iframe>",
"html": "<iframe src='https://example.com/' allow='autoplay;clipboard-write;fullscreen;encrypted-media;picture-in-picture'></iframe>",
"height": 300
}