sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 22:56:36 +09:00
Code Issues Packages Projects Releases Wiki Activity

Ensure WorkingBeatmap is invalidated after update

Browse Source
This commit is contained in:
Dean Herbert
2022-06-20 19:25:18 +09:00
parent fe570d8052
commit 021b16f2f3
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Beatmaps/BeatmapUpdater.cs
View File

@ -16,13 +16,13 @@ namespace osu.Game.Beatmaps
/// </summary>
public class BeatmapUpdater
{
private readonly BeatmapManager beatmapManager;
private readonly IWorkingBeatmapCache workingBeatmapCache;
private readonly BeatmapOnlineLookupQueue onlineLookupQueue;
private readonly BeatmapDifficultyCache difficultyCache;
public BeatmapUpdater(BeatmapManager beatmapManager, BeatmapOnlineLookupQueue onlineLookupQueue, BeatmapDifficultyCache difficultyCache)
public BeatmapUpdater(IWorkingBeatmapCache workingBeatmapCache, BeatmapOnlineLookupQueue onlineLookupQueue, BeatmapDifficultyCache difficultyCache)
{
this.beatmapManager = beatmapManager;
this.workingBeatmapCache = workingBeatmapCache;
this.onlineLookupQueue = onlineLookupQueue;
this.difficultyCache = difficultyCache;
}
@ -48,17 +48,19 @@ namespace osu.Game.Beatmaps
foreach (var beatmap in beatmapSet.Beatmaps)
{
var working = beatmapManager.GetWorkingBeatmap(beatmap);
// Because we aren't guaranteed all processing will happen on this thread, it's very hard to use the live realm object.
// This can be fixed by adding a synchronous flow to `BeatmapDifficultyCache`.
var detachedBeatmap = beatmap.Detach();
beatmap.StarRating = difficultyCache.GetDifficultyAsync(detachedBeatmap).GetResultSafely()?.Stars ?? 0;
var working = workingBeatmapCache.GetWorkingBeatmap(beatmap);
beatmap.Length = calculateLength(working.Beatmap);
beatmap.BPM = 60000 / working.Beatmap.GetMostCommonBeatLength();
}
});
workingBeatmapCache.Invalidate(beatmapSet);
}
private double calculateLength(IBeatmap b)