sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 07:06:35 +09:00
Code Issues Packages Projects Releases Wiki Activity

Use DrawableSliderTail instead of DrawableSlider

Browse Source
This commit is contained in:
Alden Wu
2022-07-20 18:07:02 -07:00
parent 5cb0920cfb
commit 23fd514ca3
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game.Rulesets.Osu/Skinning/FollowCircle.cs
View File

@ -58,13 +58,14 @@ namespace osu.Game.Rulesets.Osu.Skinning
private void updateStateTransforms(DrawableHitObject drawableObject, ArmedState state)
{
// We only want DrawableSlider here. DrawableSliderTail doesn't quite work because its
// HitStateUpdateTime is ~36ms before DrawableSlider's HitStateUpdateTime (aka slider
// end leniency).
if (drawableObject is not DrawableSlider)
if (drawableObject is not DrawableSliderTail)
return;
using (BeginAbsoluteSequence(drawableObject.HitStateUpdateTime))
Debug.Assert(ParentObject != null);
// Use ParentObject instead of drawableObject because slider tail hit state update time
// is ~36ms before the actual slider end (aka slider tail leniency)
using (BeginAbsoluteSequence(ParentObject.HitStateUpdateTime))
{
switch (state)
{

4
osu.Game.Rulesets.Osu/Skinning/TickFollowCircle.cs
View File

@ -18,6 +18,8 @@ namespace osu.Game.Rulesets.Osu.Skinning
private void updateStateTransforms(DrawableHitObject drawableObject, ArmedState state)
{
// Fine to use drawableObject.HitStateUpdateTime even for DrawableSliderTail, since on
// stable, the break anim plays right when the tail is missed, not when the slider ends
using (BeginAbsoluteSequence(drawableObject.HitStateUpdateTime))
{
switch (state)
@ -28,7 +30,7 @@ namespace osu.Game.Rulesets.Osu.Skinning
break;
case ArmedState.Miss:
if (drawableObject is DrawableSlider or DrawableSliderTick or DrawableSliderRepeat)
if (drawableObject is DrawableSliderTail or DrawableSliderTick or DrawableSliderRepeat)
OnSliderBreak();
break;
}