sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 23:24:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10200 from peppy/fix-hit-object-container-unbinding

Browse Source 
Fix HitObjectContainer not correctly unbinding from startTime fast enough
This commit is contained in:
Dean Herbert
2020-09-23 21:17:31 +09:00
committed by GitHub
parent ea6e61e092 d6ae66384d
commit 26d1c4322d
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Rulesets/UI/HitObjectContainer.cs
View File

@ -43,10 +43,20 @@ namespace osu.Game.Rulesets.UI
return true;
}
protected override void Dispose(bool isDisposing)
{
base.Dispose(isDisposing);
unbindStartTimeMap();
}
public virtual void Clear(bool disposeChildren = true)
{
ClearInternal(disposeChildren);
unbindStartTimeMap();
}
private void unbindStartTimeMap()
{
foreach (var kvp in startTimeMap)
kvp.Value.bindable.UnbindAll();
startTimeMap.Clear();