sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-10 22:07:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add failing test case

Browse Source
This commit is contained in:
Bartłomiej Dach 2020-07-30 21:39:45 +02:00
parent 566c5310bf
commit 2df5fafea0
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
osu.Game.Tests/Gameplay/TestSceneHitObjectSamples.cs
View File

@ -82,12 +82,11 @@ namespace osu.Game.Tests.Gameplay
} }
/// <summary> /// <summary>
/// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the user skin when the beatmap does not contain the sample: /// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the user skin
/// normal-hitnormal2 /// (ignoring the custom sample set index) when the beatmap skin does not contain the sample:
/// normal-hitnormal /// normal-hitnormal
/// hitnormal /// hitnormal
/// </summary> /// </summary>
[TestCase("normal-hitnormal2")]
[TestCase("normal-hitnormal")] [TestCase("normal-hitnormal")]
[TestCase("hitnormal")] [TestCase("hitnormal")]
public void TestDefaultCustomSampleFromUserSkinFallback(string expectedSample) public void TestDefaultCustomSampleFromUserSkinFallback(string expectedSample)
@ -99,6 +98,23 @@ namespace osu.Game.Tests.Gameplay
AssertUserLookup(expectedSample); AssertUserLookup(expectedSample);
} }
/// <summary>
/// Tests that a hitobject which provides a custom sample set of 2 does not retrieve a normal-hitnormal2 sample from the user skin
/// if the beatmap skin does not contain the sample.
/// User skins in stable ignore the custom sample set index when performing lookups.
/// </summary>
[Test]
public void TestUserSkinLookupIgnoresSampleBank()
{
const string unwanted_sample = "normal-hitnormal2";
SetupSkins(string.Empty, unwanted_sample);
CreateTestWithBeatmap("hitobject-beatmap-custom-sample.osu");
AssertNoLookup(unwanted_sample);
}
/// <summary> /// <summary>
/// Tests that a hitobject which provides a sample file retrieves the sample file from the beatmap skin. /// Tests that a hitobject which provides a sample file retrieves the sample file from the beatmap skin.
/// </summary> /// </summary>
@ -183,7 +199,7 @@ namespace osu.Game.Tests.Gameplay
string[] expectedSamples = string[] expectedSamples =
{ {
"normal-hitnormal2", "normal-hitnormal2",
"normal-hitwhistle2" "normal-hitwhistle" // user skin lookups ignore custom sample set index
}; };
SetupSkins(expectedSamples[0], expectedSamples[1]); SetupSkins(expectedSamples[0], expectedSamples[1]);