Merge pull request #21751 from bdach/fix-mania-hold-note-crash

Fix crashes on quick-retrying when holding note in mania
This commit is contained in:
Dan Balasescu
2022-12-22 14:25:43 +09:00
committed by GitHub
2 changed files with 6 additions and 0 deletions

View File

@ -134,6 +134,9 @@ namespace osu.Game.Rulesets.Mania.UI
protected override void Dispose(bool isDisposing)
{
// must happen before children are disposed in base call to prevent illegal accesses to the hit explosion pool.
NewResult -= OnNewResult;
base.Dispose(isDisposing);
if (skin != null)

View File

@ -156,6 +156,9 @@ namespace osu.Game.Rulesets.Mania.UI
protected override void Dispose(bool isDisposing)
{
// must happen before children are disposed in base call to prevent illegal accesses to the judgement pool.
NewResult -= OnNewResult;
base.Dispose(isDisposing);
if (currentSkin != null)