sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 15:16:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

Don't unnecessarily expose properties

Browse Source
This commit is contained in:
Craftplacer
2020-02-03 23:03:27 +01:00
parent 835d4f25ff
commit 4eedd82032
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game/Online/Chat/MessageNotifier.cs
View File

@ -137,16 +137,14 @@ namespace osu.Game.Online.Chat
public PrivateMessageNotification(string username, Channel channel)
{
Icon = FontAwesome.Solid.Envelope;
Username = username;
Channel = channel;
Text = $"You received a private message from '{Username}'. Click to read it!";
this.username = username;
this.channel = channel;
Text = $"You received a private message from '{this.username}'. Click to read it!";
}
public string Username { get; }
private readonly string username;
public Channel Channel { get; }
public Action<PrivateMessageNotification> OnRemove { get; set; }
private readonly Channel channel;
public override bool IsImportant => false;
@ -159,7 +157,7 @@ namespace osu.Game.Online.Chat
{
notificationOverlay.Hide();
chatOverlay.Show();
channelManager.CurrentChannel.Value = Channel;
channelManager.CurrentChannel.Value = channel;
return true;
};
@ -172,10 +170,10 @@ namespace osu.Game.Online.Chat
{
Icon = FontAwesome.Solid.At;
Text = $"Your name was mentioned in chat by '{username}'. Click to find out why!";
Channel = channel;
this.channel = channel;
}
public Channel Channel { get; }
private readonly Channel channel;
public override bool IsImportant => false;
@ -188,7 +186,7 @@ namespace osu.Game.Online.Chat
{
notificationOverlay.Hide();
chatOverlay.Show();
channelManager.CurrentChannel.Value = Channel;
channelManager.CurrentChannel.Value = channel;
return true;
};