sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 08:49:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Refactor some incorrect/outdated terminology

Browse Source
This commit is contained in:
Dean Herbert
2021-09-06 21:30:15 +09:00
parent 3c7a34bdbd
commit 693ecdf62a
4 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Rulesets.Taiko/Mods/TaikoModHidden.cs
View File

@ -52,9 +52,8 @@ namespace osu.Game.Rulesets.Taiko.Mods
protected double MultiplierAt(HitObject obj) protected double MultiplierAt(HitObject obj)
{ {
double beatLength = controlPointInfo.TimingPointAt(obj.StartTime).BeatLength; double beatLength = controlPointInfo.TimingPointAt(obj.StartTime).BeatLength;
double speedMultiplier = obj.DifficultyControlPoint.SliderVelocity;
return speedMultiplier * TimingControlPoint.DEFAULT_BEAT_LENGTH / beatLength; return obj.DifficultyControlPoint.SliderVelocity * TimingControlPoint.DEFAULT_BEAT_LENGTH / beatLength;
} }
public override void ApplyToBeatmap(IBeatmap beatmap) public override void ApplyToBeatmap(IBeatmap beatmap)

2
osu.Game/Beatmaps/BeatmapDifficulty.cs
View File

@ -26,7 +26,7 @@ namespace osu.Game.Beatmaps
set => approachRate = value; set => approachRate = value;
} }
public double SliderMultiplier { get; set; } = 1; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA this needs to be renamed or removed or something. public double SliderMultiplier { get; set; } = 1;
public double SliderTickRate { get; set; } = 1; public double SliderTickRate { get; set; } = 1;
/// <summary> /// <summary>

2
osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs
View File

@ -31,7 +31,7 @@ namespace osu.Game.Beatmaps.ControlPoints
public override Color4 GetRepresentingColour(OsuColour colours) => colours.Lime1; public override Color4 GetRepresentingColour(OsuColour colours) => colours.Lime1;
/// <summary> /// <summary>
/// The speed multiplier at this control point. /// The slider velocity at this control point.
/// </summary> /// </summary>
public double SliderVelocity public double SliderVelocity
{ {

10
osu.Game/Rulesets/Edit/IPositionSnapProvider.cs
View File

@ -28,14 +28,14 @@ namespace osu.Game.Rulesets.Edit
/// <summary> /// <summary>
/// Retrieves the distance between two points within a timing point that are one beat length apart. /// Retrieves the distance between two points within a timing point that are one beat length apart.
/// </summary> /// </summary>
/// <param name="referenceObject"></param> /// <param name="referenceObject">An object to be used as a reference point for this operation.</param>
/// <returns>The distance between two points residing in the timing point that are one beat length apart.</returns> /// <returns>The distance between two points residing in the timing point that are one beat length apart.</returns>
float GetBeatSnapDistanceAt(HitObject referenceObject); float GetBeatSnapDistanceAt(HitObject referenceObject);
/// <summary> /// <summary>
/// Converts a duration to a distance. /// Converts a duration to a distance.
/// </summary> /// </summary>
/// <param name="referenceObject"></param> /// <param name="referenceObject">An object to be used as a reference point for this operation.</param>
/// <param name="duration">The duration to convert.</param> /// <param name="duration">The duration to convert.</param>
/// <returns>A value that represents <paramref name="duration"/> as a distance in the timing point.</returns> /// <returns>A value that represents <paramref name="duration"/> as a distance in the timing point.</returns>
float DurationToDistance(HitObject referenceObject, double duration); float DurationToDistance(HitObject referenceObject, double duration);
@ -43,7 +43,7 @@ namespace osu.Game.Rulesets.Edit
/// <summary> /// <summary>
/// Converts a distance to a duration. /// Converts a distance to a duration.
/// </summary> /// </summary>
/// <param name="referenceObject"></param> /// <param name="referenceObject">An object to be used as a reference point for this operation.</param>
/// <param name="distance">The distance to convert.</param> /// <param name="distance">The distance to convert.</param>
/// <returns>A value that represents <paramref name="distance"/> as a duration in the timing point.</returns> /// <returns>A value that represents <paramref name="distance"/> as a duration in the timing point.</returns>
double DistanceToDuration(HitObject referenceObject, float distance); double DistanceToDuration(HitObject referenceObject, float distance);
@ -51,7 +51,7 @@ namespace osu.Game.Rulesets.Edit
/// <summary> /// <summary>
/// Converts a distance to a snapped duration. /// Converts a distance to a snapped duration.
/// </summary> /// </summary>
/// <param name="referenceObject"></param> /// <param name="referenceObject">An object to be used as a reference point for this operation.</param>
/// <param name="distance">The distance to convert.</param> /// <param name="distance">The distance to convert.</param>
/// <returns>A value that represents <paramref name="distance"/> as a duration snapped to the closest beat of the timing point.</returns> /// <returns>A value that represents <paramref name="distance"/> as a duration snapped to the closest beat of the timing point.</returns>
double GetSnappedDurationFromDistance(HitObject referenceObject, float distance); double GetSnappedDurationFromDistance(HitObject referenceObject, float distance);
@ -60,7 +60,7 @@ namespace osu.Game.Rulesets.Edit
/// Converts an unsnapped distance to a snapped distance. /// Converts an unsnapped distance to a snapped distance.
/// The returned distance will always be floored (as to never exceed the provided <paramref name="distance"/>. /// The returned distance will always be floored (as to never exceed the provided <paramref name="distance"/>.
/// </summary> /// </summary>
/// <param name="referenceObject"></param> /// <param name="referenceObject">An object to be used as a reference point for this operation.</param>
/// <param name="distance">The distance to convert.</param> /// <param name="distance">The distance to convert.</param>
/// <returns>A value that represents <paramref name="distance"/> snapped to the closest beat of the timing point.</returns> /// <returns>A value that represents <paramref name="distance"/> snapped to the closest beat of the timing point.</returns>
float GetSnappedDistanceFromDistance(HitObject referenceObject, float distance); float GetSnappedDistanceFromDistance(HitObject referenceObject, float distance);