mirror of
https://github.com/osukey/osukey.git
synced 2025-08-03 14:46:38 +09:00
Merge pull request #3726 from smoogipoo/fix-taiko-lifetimes
Fix taiko proxies not receiving the correct lifetimes
This commit is contained in:
@ -31,7 +31,7 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
|
||||
RelativeSizeAxes = Axes.Both,
|
||||
Child = Content = new Container { RelativeSizeAxes = Axes.Both }
|
||||
},
|
||||
proxiedContent = new Container { RelativeSizeAxes = Axes.Both }
|
||||
proxiedContent = new ProxiedContentContainer { RelativeSizeAxes = Axes.Both }
|
||||
};
|
||||
}
|
||||
|
||||
@ -75,6 +75,12 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
|
||||
|
||||
public abstract bool OnPressed(TaikoAction action);
|
||||
public virtual bool OnReleased(TaikoAction action) => false;
|
||||
|
||||
private class ProxiedContentContainer : Container
|
||||
{
|
||||
public override double LifetimeStart => Parent?.LifetimeStart ?? base.LifetimeStart;
|
||||
public override double LifetimeEnd => Parent?.LifetimeEnd ?? base.LifetimeEnd;
|
||||
}
|
||||
}
|
||||
|
||||
public abstract class DrawableTaikoHitObject<TaikoHitType> : DrawableTaikoHitObject
|
||||
|
@ -31,6 +31,8 @@ namespace osu.Game.Skinning
|
||||
|
||||
public void Play() => channels?.ForEach(c => c.Play());
|
||||
|
||||
public override bool IsPresent => false; // We don't need to receive updates.
|
||||
|
||||
protected override void SkinChanged(ISkinSource skin, bool allowFallback)
|
||||
{
|
||||
channels = samples.Select(s =>
|
||||
|
Reference in New Issue
Block a user