Renamings.

This commit is contained in:
smoogipooo 2017-03-21 21:36:05 +09:00
parent ad74797cd4
commit d9524f692d
3 changed files with 20 additions and 19 deletions

View File

@ -3,7 +3,7 @@
namespace osu.Game.Modes.Taiko.Judgements namespace osu.Game.Modes.Taiko.Judgements
{ {
public enum TaikoScoreResult public enum TaikoHitResult
{ {
Good, Good,
Great Great

View File

@ -10,32 +10,32 @@ namespace osu.Game.Modes.Taiko.Judgements
/// <summary> /// <summary>
/// The maximum score value. /// The maximum score value.
/// </summary> /// </summary>
public const TaikoScoreResult MAX_SCORE = TaikoScoreResult.Great; public const TaikoHitResult MAX_SCORE = TaikoHitResult.Great;
/// <summary> /// <summary>
/// The score value. /// The score value.
/// </summary> /// </summary>
public TaikoScoreResult Score; public TaikoHitResult TaikoResult;
/// <summary> /// <summary>
/// The score value for the combo portion of the score. /// The score value for the combo portion of the score.
/// </summary> /// </summary>
public int ScoreValue => ScoreToInt(Score); public int ScoreValue => NumericResultForScore(TaikoResult);
/// <summary> /// <summary>
/// The score value for the accuracy portion of the score. /// The score value for the accuracy portion of the score.
/// </summary> /// </summary>
public int AccuracyScoreValue => AccuracyScoreToInt(Score); public int AccuracyScoreValue => NumericResultForAccuracy(TaikoResult);
/// <summary> /// <summary>
/// The maximum score value for the combo portion of the score. /// The maximum score value for the combo portion of the score.
/// </summary> /// </summary>
public int MaxScoreValue => ScoreToInt(MAX_SCORE); public int MaxScoreValue => NumericResultForScore(MAX_SCORE);
/// <summary> /// <summary>
/// The maximum score value for the accuracy portion of the score. /// The maximum score value for the accuracy portion of the score.
/// </summary> /// </summary>
public int MaxAccuracyScoreValue => AccuracyScoreToInt(MAX_SCORE); public int MaxAccuracyScoreValue => NumericResultForAccuracy(MAX_SCORE);
/// <summary> /// <summary>
/// Whether this Judgement has a secondary hit in the case of finishers. /// Whether this Judgement has a secondary hit in the case of finishers.
@ -43,38 +43,39 @@ namespace osu.Game.Modes.Taiko.Judgements
public bool SecondHit; public bool SecondHit;
/// <summary> /// <summary>
/// Computes the score value for the combo portion of the score. /// Computes the numeric score value for the combo portion of the score.
/// For the accuracy portion of the score (including accuracy percentage), see <see cref="AccuracyScoreToInt(TaikoScoreResult)"/>. /// For the accuracy portion of the score (including accuracy percentage), see <see cref="NumericResultForAccuracy(TaikoHitResult)"/>.
/// </summary> /// </summary>
/// <param name="result">The result to compute the score value for.</param> /// <param name="result">The result to compute the score value for.</param>
/// <returns>The int score value.</returns> /// <returns>The numeric score value.</returns>
protected virtual int ScoreToInt(TaikoScoreResult result) protected virtual int NumericResultForScore(TaikoHitResult result)
{ {
switch (result) switch (result)
{ {
default: default:
return 0; return 0;
case TaikoScoreResult.Good: case TaikoHitResult.Good:
return 100; return 100;
case TaikoScoreResult.Great: case TaikoHitResult.Great:
return 300; return 300;
} }
} }
/// <summary> /// <summary>
/// Computes the score value for the accuracy portion of the score. /// Computes the numeric score value for the accuracy portion of the score.
/// For the combo portion of the score, see <see cref="NumericResultForScore(TaikoHitResult)"/>.
/// </summary> /// </summary>
/// <param name="result">The result to compute the score value for.</param> /// <param name="result">The result to compute the score value for.</param>
/// <returns>The int score value.</returns> /// <returns>The numeric score value.</returns>
protected virtual int AccuracyScoreToInt(TaikoScoreResult result) protected virtual int NumericResultForAccuracy(TaikoHitResult result)
{ {
switch (result) switch (result)
{ {
default: default:
return 0; return 0;
case TaikoScoreResult.Good: case TaikoHitResult.Good:
return 150; return 150;
case TaikoScoreResult.Great: case TaikoHitResult.Great:
return 300; return 300;
} }
} }

View File

@ -50,7 +50,7 @@
<Compile Include="Beatmaps\TaikoBeatmapConverter.cs" /> <Compile Include="Beatmaps\TaikoBeatmapConverter.cs" />
<Compile Include="Beatmaps\TaikoBeatmapProcessor.cs" /> <Compile Include="Beatmaps\TaikoBeatmapProcessor.cs" />
<Compile Include="Judgements\TaikoJudgementInfo.cs" /> <Compile Include="Judgements\TaikoJudgementInfo.cs" />
<Compile Include="Judgements\TaikoScoreResult.cs" /> <Compile Include="Judgements\TaikoHitResult.cs" />
<Compile Include="TaikoDifficultyCalculator.cs" /> <Compile Include="TaikoDifficultyCalculator.cs" />
<Compile Include="Objects\Drawable\DrawableTaikoHit.cs" /> <Compile Include="Objects\Drawable\DrawableTaikoHit.cs" />
<Compile Include="Objects\TaikoHitObject.cs" /> <Compile Include="Objects\TaikoHitObject.cs" />