Commit Graph

32017 Commits

Author SHA1 Message Date
28ba437d24 Merge branch 'master' into sucess-rate-tooltip 2022-04-02 19:31:45 +02:00
beb8426d3b Save beatmap listing card size to game config 2022-04-02 18:36:49 +03:00
ced5be33e6 Display pass/play count in success rate percentage tooltip 2022-04-02 18:08:57 +03:00
6776c37bbc Merge pull request #17592 from peppy/skin-mutation-better-naming
Fix automatically created "(modified)" skins getting conflicting names
2022-04-01 21:25:10 +09:00
43d03f2825 Put ToArray call in correct place in brackets 2022-04-01 19:30:16 +09:00
01681ee874 Add missing ToArray call
Not sure where this went, was there in my original commit.
2022-04-01 16:19:02 +09:00
cabf6f501f Merge pull request #17594 from peppy/move-skin-component-error-handling
Move `SkinnableInfo` error handling to lower level
2022-04-01 16:04:00 +09:00
01829cf2d8 Move SkinnableInfo error handling to lower level
Handling was recently added to handle the usage in
`Skin.GetDrawableCompoent`, but it turns out this is also required for
`DrawableExtensions.ApplySkinnableInfo` which can throw in a similar
fashion.

Found while working on sprite support for the editor, where this becomes
an actual issue (ie. switching to a branch where the new sprite support
is not present can cause unexpected crashes).
2022-04-01 14:30:04 +09:00
88306a6180 Disable ability to select random skin from within the skin editor
Reasoning is explained in inline comment.

I knowingly only applied this to the shortcut key. It's still feasible a
user can choose the option from the skin dropdown while the editor is
open, but that's less of an issue (because a user won't get the same
compulsion that I get to mash the key, only to be greeted with 100 new
mutable skins created).
2022-04-01 14:22:32 +09:00
69d4f86122 Fix automatically created "(modified)" skins getting conflicting names
Applies the already tested and proven method that is used in the editor
to the mutable skin creation flow.
2022-04-01 14:11:55 +09:00
6b9f5812a5 Merge pull request #17579 from CenTdemeern1/clock-button
Make the toolbar clock feel more like a button
2022-04-01 13:12:48 +09:00
10f15f2bdb Merge pull request #17559 from bdach/mod-overlay/sheared-toggle
Implement sheared toggle button
2022-04-01 13:06:22 +09:00
338a21f4f0 Merge pull request #17581 from CenTdemeern1/remove-bpm-slider
Remove BPM slider
2022-04-01 11:59:16 +09:00
86d262a355 Merge branch 'ppy:master' into clock-button 2022-03-31 23:08:30 +02:00
1c7b259f8e Merge branch 'master' into mod-overlay/sheared-toggle 2022-03-31 22:20:20 +02:00
e180db145d Add constructor argument to facilitate fixed width/autosizing 2022-03-31 22:19:08 +02:00
b3896257ca Move shear amount to constant 2022-03-31 22:09:03 +02:00
e14d5b8adb Remove unused using directives 2022-03-31 21:20:30 +02:00
a6875383fc Rebind SaveState() to bpmTextEntry 2022-03-31 21:06:05 +02:00
bdb21b17f7 Fix my code according to the changes @bdach requested 2022-03-31 20:39:26 +02:00
52d723aaa6 Remove BPM slider 2022-03-31 20:11:07 +02:00
c64a90b39e Remove a newline to comply with codefactor 2022-03-31 17:21:50 +02:00
f1aa60c0f1 Make the clock feel more like a button 2022-03-31 16:26:53 +02:00
0a34ce2509 Increase font weight for runtime clock
Fonts this small are required to be `SemiBold` by design guidelines.
Somehow missed this.
2022-03-31 19:07:30 +09:00
bc4d6a3ace Merge pull request #17570 from peppy/fix-settings-textbox-focus
Focus focus not being transferred correctly to parent settings panel on exiting nested panel
2022-03-31 18:07:51 +09:00
ef5e37c47a Fix multiplayer sounds playing too much after gameplay
Regressed in https://github.com/ppy/osu/pull/15936.

Closes #17295.
2022-03-31 16:18:28 +09:00
ad14b7cac5 Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations
Remove ScoreInfo allocations in multiplayer leaderboard
2022-03-31 15:48:14 +09:00
726b49fdf3 Focus focus not being transferred correctly to parent settings panel on exiting nested panel
Seemingly harmless schedule delay ommission meant that the textbox may
not be in a state it can handle the incoming focus event. Regressed in
https://github.com/ppy/osu/pull/14345#discussion_r690697501.
2022-03-31 15:24:21 +09:00
e8a295a61b Add test coverage of textbox focus in settings panels when switching between nested panels 2022-03-31 15:24:21 +09:00
36c02573a8 Fix osu! logo being clicked when exiting via cmd-q on initial state 2022-03-30 21:26:30 -07:00
9c19ae1df8 Remove no longer necessary ruleset field 2022-03-31 06:40:38 +03:00
6e94a9780b Remove ScoreInfo allocations in multi leaderboard 2022-03-31 12:23:00 +09:00
e0d434b89f Remove unused using statement 2022-03-31 11:34:32 +09:00
0cac935939 Shorten class name of ModCreatedReplayUser 2022-03-31 11:34:23 +09:00
2c1ccc7d36 Update obsolete message to match targeted developers' use case
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-03-31 11:33:26 +09:00
234bec45cc Remove unnecessary logging 2022-03-31 11:32:00 +09:00
6874cdf0c8 Remove unnecessary public prefix in interface method 2022-03-31 01:50:46 +03:00
3ac0da2da3 Implement sheared toggle button 2022-03-30 22:50:21 +02:00
436dec68c9 Use provided extension method instead of reimplementing locally 2022-03-30 22:04:54 +02:00
83bae81095 Fill out ICreateReplayData xmldocs 2022-03-30 22:04:54 +02:00
9621a7f9cb Merge branch 'master' into fix-autoplay-mod-user-id 2022-03-30 21:41:45 +02:00
0f144f6801 Merge branch 'master' into fix-countdown-refresh 2022-03-30 16:26:12 +03:00
b60c253831 Merge pull request #17556 from peppy/fix-multiplayer-unobserved
Fix `MultiplayerMatchSongSelect` potentially attempting to exit when not the current screen
2022-03-30 21:10:11 +09:00
671386ba6c Fix MultiplayerMatchSongSelect potentially attempting to exit when not the current screen 2022-03-30 20:36:12 +09:00
cb1ee05539 Merge pull request #17555 from peppy/remove-source-from-wedge
Remove song source from main wedge display
2022-03-30 18:57:25 +09:00
f9f6248101 Simplify string bindings 2022-03-30 17:59:45 +09:00
bc0b982102 Remove song source from main wedge display
This was definitely added at someone's request, since I wouldn't have
put it here. But it's displayed below in the details section already and
also not displayed in the updated "wedge" in the new design.

See https://github.com/ppy/osu/discussions/17537 for discussion.
2022-03-30 17:59:40 +09:00
99f141d396 Merge pull request #17546 from frenzibyte/autoplay-cinema-incompatibility
Mark both "Autoplay" and "Cinema" mods as mutually exclusive
2022-03-30 16:41:07 +09:00
bd3c401363 Merge pull request #17550 from smoogipoo/fix-score-display-race
Fix scores sometimes shown with incorrect scoring mode
2022-03-30 16:05:28 +09:00
975883da5c Move all usages of client.realm filename to a single const 2022-03-30 13:34:48 +09:00