Commit Graph

35978 Commits

Author SHA1 Message Date
f6c376c090 Minor refactoring 2022-11-03 20:29:27 +09:00
f75c4ba95f Update resources 2022-11-03 20:27:44 +09:00
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
cdb3494418 Merge pull request #20765 from Feodor0090/comment-report
Implement comments reporting
2022-11-03 20:09:00 +09:00
486515ed90 Merge pull request #20758 from frenzibyte/maintain-common-mod-selection
Maintain selection of common mods when switching rulesets
2022-11-03 20:08:32 +09:00
59bbd9c460 Fix some components using wrong sample set 2022-11-03 17:47:49 +09:00
f1c17129eb Add support for 'disabled' sample variation to HoverClickSounds 2022-11-03 17:47:49 +09:00
c48c9ecb6d Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons
Improve clickable area of beatmap card icon buttons
2022-11-03 15:47:08 +09:00
e336d486a6 Merge pull request #21093 from peppy/auto-skip-multiple-times
Fix automated skip not skipping more than once when required
2022-11-03 15:46:56 +09:00
56ef519cc2 Move PopoverContainer into OnlineOverlay to ensure correct colours 2022-11-03 15:43:06 +09:00
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
20dd405c2b Merge branch 'master' into maintain-common-mod-selection 2022-11-03 15:32:40 +09:00
07bfac40fa Adjust padding to avoid overlap with card border when expanded 2022-11-03 14:03:28 +09:00
66a6084d3f Scale in the background fill alongside the icon 2022-11-03 14:03:19 +09:00
fc191807c6 Fix velocity test failing with no audio device 2022-11-03 13:59:22 +09:00
df9f49eef2 Move hover layer behind icon
Looked bad on the "already downloaded" state where the icon becomes
black.
2022-11-03 13:56:07 +09:00
fb0bc597a0 Merge branch 'master' into improve-beatmap-card-buttons 2022-11-03 13:53:29 +09:00
4154be6cda Adjust auto-skip to skip multiple times if necessary 2022-11-03 13:52:29 +09:00
aef3c7918c Add total skip count to SkipOverlay 2022-11-03 13:52:24 +09:00
cb51fc7384 Merge pull request #21071 from peppy/fix-multiple-import-notifications
Fix multiple notifications arriving for imports in edge cases
2022-11-02 16:54:56 +09:00
db34f238c0 Fix inverted condition 2022-11-02 15:47:30 +09:00
e5f53b1ad8 Use Interlocked.Exhange() instead
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
22f662a076 Merge pull request #21070 from peppy/standardise-visual-settings-ui-components
Standardise "Visual Settings" components to fix mismatched paddings and labels
2022-11-02 14:53:00 +09:00
e761c0395d Fix multiple notifications arriving for imports in edge cases 2022-11-02 14:47:56 +09:00
4dabb1aa9c Merge pull request #20990 from smoogipoo/socket-client
Generalise `HubClientConnector` into `SocketClientConnector`
2022-11-02 14:17:36 +09:00
37300ba9e2 Standardise "Visual Settings" components to fix mismatched paddings and labels 2022-11-02 14:01:57 +09:00
30800c9252 Add/adjust xmldocs 2022-11-02 13:16:34 +09:00
e59c8b7d24 Use IDisposable instead 2022-11-02 11:49:04 +09:00
c9108ce41b Rename StartAsync -> ConnectAsync 2022-11-02 11:44:16 +09:00
46d1713e28 Rename Socket* -> PersistentEndpoint* 2022-11-02 11:43:22 +09:00
9f031b55a1 Merge branch 'master' into fix-directory-selector-breadcrumb 2022-11-01 22:28:13 +09:00
e104242864 Update framework 2022-11-01 22:28:06 +09:00
ac554c644d Merge branch 'master' into fix-slider-sv-snap 2022-11-01 13:19:46 +01:00
5621db8a2e Merge pull request #21052 from peppy/fix-control-point-info
Fix control points not being cloned when running beatmap conversion
2022-11-01 21:04:49 +09:00
f014acfc8d Fix DrawableHitObject.AccentColour not being updated if object entry is not attached 2022-11-01 19:34:53 +09:00
978d15955c Fix control points not being cloned when running beatmap conversion
Closes #20994.

I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.

I've tested using the scenario in the linked issue.

I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
d15585153d Fix breadcrumb display in directory selector overlapping new "show hidden" button
Closes #21034.
2022-11-01 17:07:59 +09:00
8280605e92 Fix notch toggle not applying correctly after restart 2022-11-01 16:31:09 +09:00
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
706adfb28c Improve messaging when ruleset load fails 2022-11-01 13:57:34 +09:00
8a37649097 Merge branch 'master' into socket-client 2022-10-31 16:00:14 +09:00
9ea2bd84bd Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class
Reuse function in the timeline class
2022-10-30 23:49:02 +09:00
1035b5fb19 Fix hold to pause button not working when HUD is hidden 2022-10-30 21:38:45 +09:00
a753369d3e Reuse function TimeAtPosition() and PositionAtTime(). 2022-10-30 17:21:50 +08:00
d56786b5ff Fix toolbar visual bug when toggling clock displays 2022-10-29 15:25:16 -07:00
71d87489ab Merge branch 'master' into safe-area-toggle 2022-10-29 13:19:44 +02:00
f775741d65 Merge branch 'master' into fix-filename-char-filtering 2022-10-29 12:42:10 +02:00
87fc5be562 Merge branch 'master' into improve-argon-bananas 2022-10-29 12:09:24 +02:00
9df96aab38 Remove local popover containers 2022-10-28 22:17:45 +03:00