05a2d7fbfe
Merge pull request #16591 from peppy/fix-editor-slider-velocity-saving
...
Don't include nested hit objects' `DifficultyControlPoints` in legacy encoder logic
2022-01-25 14:50:09 +09:00
bfa521bdd2
Merge pull request #16593 from peppy/realm-clean-up
...
Clean up realm naming
2022-01-25 14:33:53 +09:00
b2114bd2f0
Merge pull request #16601 from peppy/fix-storage-migration-test-failures
...
Fix `TestMigration` failing due to changes in realm migration logic
2022-01-25 14:33:35 +09:00
8adf65d2ac
Merge pull request #16602 from peppy/restore-missing-files-on-import
...
During import if files are found to be missing, ensure they are restored
2022-01-25 14:31:53 +09:00
a5c76a9647
Fix a few more cases of "context" terminology usage
2022-01-25 13:56:47 +09:00
bbcc149e2e
During import if files are found to be missing, ensure they are restored
...
This is one step closer to sanity in terms of physical files. As per the
comment I have left in place, we really should be checking file sizes or
hashes, but to keep things simple and fast I've opted to just cover the
"missing file" scenario for now.
Ran into this when testing against a foreign `client.realm` by:
- Noticing a beatmap doesn't load
- Deleting said beatmap
- Downloading via beatmap overlay
- Beatmap is restored but still doesn't work
Note that I've kept the logic where this will undelete an existing
import rather than create one from fresh, as I think that is beneficial
to the user (ie. it will still keep any linked scores on restore).
2022-01-25 13:44:54 +09:00
7d63999eef
Merge pull request #16473 from mk56-spn/Liswiera-FL-changes
...
Add method of adjusting flashlight radius in flashlight mod
2022-01-25 13:16:39 +09:00
d7342880f5
Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
2022-01-25 13:09:48 +09:00
e23b10e6a5
Update remaining cases of clashing variable name in realm.Run(realm..
2022-01-25 13:04:05 +09:00
3e5c9e8436
Fix cases of Access instead of Realm
2022-01-25 12:58:15 +09:00
2d34831b5f
Fix TestMigration failing due to changes in realm migration logic
...
Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true .
2022-01-25 12:54:40 +09:00
8c3fbb6eb4
Merge branch 'master' into Liswiera-FL-changes
2022-01-24 21:32:36 +01:00
2375420d4c
Tweak allowable ranges of size multiplier
2022-01-24 21:32:31 +01:00
4a13c93ca7
Disallow zero size multiplier in flashlight implementations
2022-01-24 21:03:03 +01:00
a227af75ed
Simplify flashlight parameter passing flow
2022-01-24 21:03:02 +01:00
5874475dff
Extract DefaultFlashlightSize to base flashlight class
2022-01-24 21:03:02 +01:00
a7c0d507ce
Rename flashlight settings to be more accurate
2022-01-24 21:03:02 +01:00
da771044a7
Merge branch 'master' into realm-clean-up
2022-01-24 19:15:31 +01:00
d544c52f3c
Merge pull request #16548 from peppy/music-controller-less-population
...
Remove pointless initial `MusicController` beatmap set population
2022-01-24 19:12:56 +01:00
3bc86ee68f
Merge branch 'master' into music-controller-less-population
2022-01-24 20:44:37 +09:00
f30894840c
Update terminology to realm "instance" rather than "context"
...
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
bb54ad9ad8
Merge pull request #16547 from peppy/realm-stable-subscriptions
...
Fix realm subscriptions getting lost after a context recycle
2022-01-24 20:20:04 +09:00
94ad7abfd6
Merge pull request #16590 from peppy/realm-migrate-on-failure
...
Allow realm migration to run again if interrupted halfway
2022-01-24 20:19:52 +09:00
c3758047fd
Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic
...
The editor doesn't currently propagate velocity to nested objects. We're
not yet sure whether it should or not. For now, let's just ignore nested
objects' `DifficultyControlPoints` for simplicity.
Note that this only affects osu! ruleset due to the pre-check on
`isOsuRuleset`.
2022-01-24 19:54:08 +09:00
deaff340d2
Add test coverage of saving velocity
2022-01-24 19:43:18 +09:00
948867898c
ModeMultiplier rename
2022-01-24 11:38:52 +01:00
b396d55758
Merge branch 'master' into realm-stable-subscriptions
2022-01-24 19:01:49 +09:00
66c5d77d63
Allow realm migration to run again if interrupted halfway
2022-01-24 18:55:15 +09:00
9afa034296
Fix attempt to revive update thread realm context from non-update thread
2022-01-24 18:36:16 +09:00
b0919722ac
Guard against potential exception while blocking realm
2022-01-24 18:25:48 +09:00
9ff9611296
Merge branch 'master' into realm-stable-subscriptions
2022-01-24 18:25:47 +09:00
37b74aafcc
Merge pull request #16588 from peppy/dont-exit-screens-test-browser
...
Avoid adding "exit all screens" step when running tests interactively
2022-01-24 18:24:41 +09:00
e3083c2477
Fix copy pasted xmldoc
2022-01-24 18:05:30 +09:00
bf5bf8d1fd
Rename dictionaries to match methods
2022-01-24 17:58:53 +09:00
f4e7211ef1
Add xmldoc for RegisterForNotifications
2022-01-24 17:52:36 +09:00
abf14f0982
Lock unregistration for sanity
2022-01-24 17:46:53 +09:00
52cd906af6
Move context retrieval inside lock
2022-01-24 17:45:31 +09:00
161a2a321e
Remove bindable from ModeMultiplier
2022-01-24 09:07:07 +01:00
e22aea0613
Apply same fix to OsuGameTestScene
2022-01-24 17:05:49 +09:00
1e483ece32
Avoid adding "exit all screens" step when running tests interactively
2022-01-24 16:40:16 +09:00
5a12496873
Merge pull request #16571 from bdach/custom-meter
...
Add back editor support for non-standard time signatures
2022-01-24 16:09:47 +09:00
d7db6fa918
Merge branch 'master' into custom-meter
2022-01-24 15:46:44 +09:00
6581e8c2d3
Merge pull request #16549 from Susko3/LoginPanel-flag
...
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
cb319cebdb
Refactor naming and add more comments to help understanding in RealmContextFactory subscription logic
2022-01-24 14:48:55 +09:00
40aa873190
Rename register methods to better explain their purpose
2022-01-24 14:37:36 +09:00
d7a9c5fd41
Add settings buttons to allow temporarily blocking realm access
2022-01-24 14:36:57 +09:00
997c13f643
Add locking over realmSubscriptionsResetMap for sanity
2022-01-24 13:36:51 +09:00
ed84ae0ac0
Adjust values to Bdach's refined taste
2022-01-24 00:42:43 +01:00
873d5bb104
Merge pull request #16586 from bdach/beatmap-path-tostring
2022-01-24 02:03:04 +03:00
