Commit Graph

40407 Commits

Author SHA1 Message Date
ccb83ef3a3 Fix checkbox not being updated 2021-02-22 15:47:47 +09:00
adf2dc36c9 Fix PlaylistResults tests performing delays in real-time when headless 2021-02-22 15:43:58 +09:00
c99e152fe4 Merge pull request #11866 from peppy/update-framework
Update framework
2021-02-22 15:31:26 +09:00
fde026d443 Remove redundant interface specification 2021-02-22 14:54:48 +09:00
cdbf8de29d Update other tests which can benefit from using a shorter beatmap 2021-02-22 14:53:32 +09:00
541237ef16 Use a shorter test beatmap for tests which need to run to completion 2021-02-22 14:48:04 +09:00
63dd55c92c Add missing methods from updated audio component interface implementation 2021-02-22 14:18:52 +09:00
e2c5dded7f Update framework 2021-02-22 14:14:36 +09:00
ca92ad715a Add test 2021-02-22 13:32:54 +09:00
8d463987dd Fix being able to select incompatible freemods 2021-02-22 13:24:24 +09:00
bc8e67ad7c Merge pull request #11834 from peppy/perform-from-subscreen-support
Add the ability for PerformFromMenuRunner to inspect nested screen stacks
2021-02-22 12:24:08 +09:00
8037b101cb Merge branch 'master' into perform-from-subscreen-support 2021-02-22 11:55:51 +09:00
33985d9e7c Rewrite scaling bounds check to behave more intuively 2021-02-21 18:11:32 +01:00
2c6f92d12f Move bounds check from moveSelection to HandleMovement 2021-02-21 17:38:50 +01:00
3e98d7621a Merge pull request #11842 from Susko3/android-export-activity 2021-02-21 15:25:44 +01:00
b8090c1638 Merge branch 'master' into android-export-activity 2021-02-21 14:28:17 +01:00
562a4cefdb Simplify HandleScale by extracting methods 2021-02-21 12:12:32 +01:00
323e4ac26b Refactor catch Movement skill to not require explicit clockrate usage
In catch, rate adjustment mods do not only affect the timings of hitobjects, but also the speed of the player's catcher.

This catcher speed change has an impact on difficulty which is currently accounted for by using the clockrate directly in calculations.

Semantically this is a bad idea because clockrate adjustments are supposed to be fully accounted for in DifficultyHitObjects, but passing clockrate here for the purpose of being used as catcher speed doesn't make much sense, especially since it is copied in every DifficultyHitObject despite being the same value.

It makes more sense to account for this catch specific impact by handling rate adjustment mods in a catch specific way, or more specifically in a Movement skill specific way.
2021-02-21 18:24:30 +11:00
0b8009938a Prevent selection from breaking playfield bounds when scaling 2021-02-21 00:14:39 +01:00
cc4c5f72d8 Move logic to keep selection in bounds into it's own method 2021-02-21 00:14:39 +01:00
9a7fe4056a Merge pull request #11848 from peppy/update-framework
Update framework
2021-02-20 20:26:21 +09:00
66643a97b0 Add a list of mods to Skill class
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
417bb07b36 Update tests with fixed diffcalc values 2021-02-20 20:23:49 +11:00
442347df8e Fix clockrate adjusted difficulty calculations bug in strain decay
When starting a new section, the starting strain value was calculated using the unadjusted timing value, meaning decay curves were essentially being stretched or squashed according to the clockrate.

This caused incorrect strain peaks for any section where the peak occurs at the start of the section (none of the objects in the section added enough strain after decay to exceed the starting strain).

This bug caused star ratings with clockrates above 1 to be lower than they should and below 1 to be higher than they should.
2021-02-20 20:23:49 +11:00
303c6bcda7 Merge pull request #11846 from Syriiin/diffcalc/tests/add-clockrate-tests
Add tests for clockrate adjusted difficulty calculations
2021-02-20 17:41:38 +09:00
3b7ebfa2ac Update framework 2021-02-20 17:17:31 +09:00
23ce5e7077 Merge pull request #11844 from peppy/fix-exit-from-player
Fix support for instant exit if pausing is not allowed in the current game mode
2021-02-20 17:01:33 +09:00
9d229a5ec2 Add tests for clockrate adjusted difficulty calculations 2021-02-20 16:27:58 +11:00
38a2124921 Support instant exit if pausing is not allowed in the current game mode 2021-02-20 14:26:50 +09:00
d2ec151c67 Add failing test for pausing when pause support is disabled 2021-02-20 14:20:13 +09:00
32556b1898 add Exported = true to Activity manifest 2021-02-20 02:32:44 +01:00
5eee46074c Ensure the current screen is current when a sub screen is found as the target 2021-02-19 19:45:29 +09:00
52372fe50d Merge pull request #11713 from peppy/fix-error-exit-during-results-transition
Fix a potential crash when exiting play during the results screen transition
2021-02-19 18:39:21 +09:00
9fc57b2145 Merge pull request #11832 from peppy/leaderboard-compact-mode
Show compact leaderboard during gameplay to reduce distractions
2021-02-19 18:17:46 +09:00
362e4802f7 Add the ability for PerformFromMenuRunner to inspect nested screen stacks 2021-02-19 17:58:04 +09:00
f6c279ab00 Add assert ensuring player resumed properly 2021-02-19 11:45:45 +03:00
fe5e45ea81 Move gameplay cursor outside instead and fix potential failure 2021-02-19 11:43:33 +03:00
0771154dd2 Make PauseCooldownActive protected and expose on test class 2021-02-19 11:42:30 +03:00
ddd1dcff88 Attempt pausing every single frame 2021-02-19 11:33:26 +03:00
82cc06ca57 Fix new logic not considering fail overlay correctly 2021-02-19 17:26:54 +09:00
52ebe34347 Update TestScenePause exit from fail test to actually fail 2021-02-19 17:26:26 +09:00
4c214b74ce Merge branch 'master' into fix-error-exit-during-results-transition 2021-02-19 17:13:55 +09:00
b8c1e8ed7a Merge pull request #11708 from frenzibyte/multiplayer-participant-rank
Display user global rank for multiplayer room participants
2021-02-19 16:57:30 +09:00
e4d3c91ff4 Merge pull request #11819 from peppy/update-framework
Update implementation of AdjustableAudioComponents in line with framework changes
2021-02-19 16:57:03 +09:00
781379826b Merge pull request #11793 from peppy/playlists-freemod-support
Add "free mod" user mod selection support to the playlists system
2021-02-19 16:56:21 +09:00
9d02f589fe Compact leaderboard during gameplay 2021-02-19 16:51:39 +09:00
4436585aa4 Keep attempting to pause gameplay while window not active 2021-02-19 10:46:32 +03:00
772471a6d8 Add failing test case 2021-02-19 10:46:31 +03:00
691cfa5bc3 Add expanded/compact display modes for GameplayLeaderboard 2021-02-19 16:46:30 +09:00
43c35c5118 Show local user in test scene 2021-02-19 15:15:31 +09:00