Commit Graph

34258 Commits

Author SHA1 Message Date
07ee36a4ef Simplify code 2020-11-24 17:18:19 +08:00
9a3dd12f30 Move to debug settings 2020-11-18 18:15:56 +08:00
dcaebd2621 Add license text 2020-11-17 21:39:29 +08:00
809338a280 Init Import screen 2020-11-17 20:19:12 +08:00
bcf6974e18 Merge pull request #10831 from bdach/hold-note-fade
Add back fade effect to legacy hold notes
2020-11-17 15:27:10 +09:00
d7b6e4a32d Merge pull request #10867 from smoogipoo/refactor-user-request
Refactor user caching to improve readability and fix threadsafety issues
2020-11-17 14:20:45 +09:00
cb3280af7c Merge branch 'master' into hold-note-fade 2020-11-17 13:49:28 +09:00
009d666241 Use dictionary to avoid linq overhead 2020-11-17 10:57:11 +09:00
21f29e28e2 Add clarification comment 2020-11-16 20:36:56 +01:00
e88920442c Use HitStateUpdateTime instead 2020-11-16 20:01:10 +01:00
eba17ecab2 Merge pull request #10868 from smoogipoo/add-back-initiallifetimeoffset
Add back removed InitialLifetimeOffset usage in DrawableHitObject
2020-11-16 19:30:15 +01:00
72a8734f93 Merge branch 'master' into add-back-initiallifetimeoffset 2020-11-16 18:54:37 +01:00
585322c893 Merge pull request #10871 from smoogipoo/fix-ball-tint
Fix slider ball tint not working
2020-11-17 01:58:33 +09:00
f177792915 Merge pull request #10873 from smoogipoo/remove-parent-dho-pooling
Remove ability to pool DHOs in parent playfields
2020-11-17 01:55:13 +09:00
f5e12b9d7c Adjust TestScenePlayerLoader for safety 2020-11-16 23:53:54 +09:00
e8dbc190f1 Remove ability to pool DHOs in parent playfields 2020-11-16 23:30:24 +09:00
4cf6aca873 Fix slider ball tint not working 2020-11-16 22:40:25 +09:00
cead67d512 Add back removed InitialLifetimeOffset removal 2020-11-16 21:49:29 +09:00
85b0f71467 Handle duplicate user IDs within the same batch 2020-11-16 21:17:43 +09:00
87bf168718 Use queue instead of list 2020-11-16 20:52:51 +09:00
1b1f4c9c09 Refactor user request to fix threadsafety issues 2020-11-16 20:35:22 +09:00
163f5cafb9 Merge pull request #10865 from ekrctb/tasks-json-restore 2020-11-16 20:08:09 +09:00
16d25c5022 Adjast readme for the removed VSCode restore task 2020-11-16 19:25:36 +09:00
a53b5ef8b9 Remove --no-restore from VSCode build tasks 2020-11-16 19:22:08 +09:00
08a127eedc Merge pull request #10862 from peppy/fix-currentskininfo-thread-safety
Move skin deletion logic to OsuGameBase to promote thread safety
2020-11-16 18:41:46 +09:00
a98327f0c5 Merge branch 'master' into fix-currentskininfo-thread-safety 2020-11-16 17:55:22 +09:00
09298139e1 Merge pull request #10844 from bdach/spinner-rotation-tracker-state
Fix rotation tracker state not being reset on drawable spinner re-use
2020-11-16 17:10:40 +09:00
709370c69b Move schedule call outwards 2020-11-16 16:49:31 +09:00
9a7fdb2b7e Move skin deletion logic to OsuGameBase to promote thread safety
`CurrentSkinInfo` is used in multiple places expecting thread safety,
while ItemRemoved events are explicitly mentioning they are not thread
safe. As SkinManager itself doesn't have the ability to schedule to the
update thread, I've just moved the logic to `OsuGameBase`. We may want
to move the current skin bindable out of the manager class in the
future to match things like `BeatmapManager`.

Closes https://github.com/ppy/osu/issues/10837.
2020-11-16 16:43:19 +09:00
d8c9db860a Merge pull request #10860 from ekrctb/dotnet-tool-inspectcode
Use `dotnet tool` for InspectCode build script
2020-11-16 16:25:01 +09:00
86ef73c587 Merge pull request #10830 from Joehuu/consistent-tournament-strings
Make tournament strings more consistent
2020-11-16 16:20:49 +09:00
6706840b54 Merge pull request #10853 from bdach/add-to-legacy-conversion-tests 2020-11-16 15:22:04 +09:00
b20898a1ac Use dotnet tool for InspectCode build script 2020-11-16 14:57:52 +09:00
a4c17906b4 Make comment a bit more explicit 2020-11-16 14:52:18 +09:00
baed1573dc Merge pull request #10838 from nbvdkamp/fix-quick-delete-crash 2020-11-16 14:42:52 +09:00
3dbd7d5654 Merge pull request #10856 from bdach/reset-transforms-on-return-to-pool
Clear DrawableHitObject transforms on return to pool
2020-11-16 14:40:38 +09:00
7169dc9173 Add extra step checking slider deletion on second click 2020-11-16 14:06:37 +09:00
7b79b9b9c1 Merge branch 'master' into fix-quick-delete-crash 2020-11-16 13:54:54 +09:00
0ea75450d4 Merge pull request #10850 from nbvdkamp/clamp-editor-movement
Clamp selection movement instead of refusing to move on playfield borders
2020-11-16 12:46:48 +09:00
399a1a16a0 Refactor beginClickSelection in a slightly different way 2020-11-15 21:06:47 +01:00
337311c323 Remove redundant type specification 2020-11-15 20:52:58 +01:00
1f0945d4de Simplify accesses via ChildrenOfType() 2020-11-15 20:52:33 +01:00
4e77800b98 Rename & simplify property 2020-11-15 20:51:35 +01:00
9c0a0031d6 Clear existing transforms on DHO return to pool 2020-11-15 19:50:22 +01:00
42de4437cc Add failing test case 2020-11-15 19:43:42 +01:00
c77ec3e905 Fix slider control point quickdelete test 2020-11-15 17:42:52 +01:00
67db278864 Merge pull request #10841 from bdach/fix-spectator-preview-crash
Add support for previewing tracks on spectator screen
2020-11-16 01:09:37 +09:00
1db303b159 Revert beginClickSelection logic 2020-11-15 16:54:48 +01:00
6b38bb9d76 Add test coverage for new ownerless behaviour 2020-11-15 16:38:25 +01:00
83727a2e85 Add quick-delete tests 2020-11-15 16:06:29 +01:00