Commit Graph

47792 Commits

Author SHA1 Message Date
07fc772c24 Merge branch 'master' into slider-paste-parsing-failures-2 2022-01-12 19:06:36 +01:00
6b7896ec69 Merge pull request #16434 from peppy/fix-being-playing-test-failures
Fix test failures due to double `BeginPlaying` calls
2022-01-13 02:43:42 +09:00
2212bea17f Fix test failures due to double BeginPlaying calls 2022-01-13 01:34:29 +09:00
017f5a9b9b Merge pull request #16430 from smoogipoo/less-harsh-mania-hp
Fix mania requiring PERFECTs to maintain HP
2022-01-12 19:07:13 +09:00
c97db5a863 Merge pull request #16431 from peppy/skin-hash-repopulation
Fix skin hash repopulation not working since realm migration
2022-01-12 19:03:56 +09:00
8c8c5f4c33 Fix skin hash repopulation not working since realm migration 2022-01-12 18:32:51 +09:00
4106ebf881 Fix mania requiring PERFECTs to maintain HP 2022-01-12 18:29:23 +09:00
5d868c41d4 Merge pull request #16330 from peppy/mouse-button-disable-disables-touch
Allow "disable mouse button" setting to apply to touch as well
2022-01-12 17:40:43 +09:00
52e240230b Merge branch 'master' into mouse-button-disable-disables-touch 2022-01-12 17:14:39 +09:00
c534a27ee7 Merge pull request #16425 from frenzibyte/update-macos-version-limit
Update macOS minimum supported version in line with .NET 5
2022-01-12 17:11:25 +09:00
c8641389af Update macOS minimum supported version in line with .NET 5 2022-01-12 11:08:12 +03:00
2e34887999 Merge pull request #16423 from peppy/realm/manual-compact
Add button to compact realm on demand
2022-01-12 16:23:00 +09:00
a82606cf5c Merge pull request #16407 from smoogipoo/fix-mania-normalised-scroll-speed
Fix calculation of most common beat length for mania scroll speed
2022-01-12 15:23:22 +09:00
11e07c1137 Add button to compact realm on demand
In general we're doing things correctly so the realm file shouldn't
expand (unless mass deletions are made from it), but this is a nice way
to manually confirm the behaviour.

Sometimes if using realm studio with osu! running, for instance, the
realm file size can blow out of proportion. This will recover from such
cases.

Note that calling `RealmFactory.Compact` itself is not enough, as it
will fail unless all instances of the realm have been closed.
2022-01-12 15:22:36 +09:00
06a5b89071 Merge pull request #16264 from bdach/beatmap-background-with-storyboard-stopping
Fix main menu background with storyboard stopping after entering and exiting song select
2022-01-12 14:37:42 +09:00
d8c52740cb Merge pull request #16354 from bdach/slider-snapping
Apply slider snapping to current beat divisor more liberally to match user expectations
2022-01-12 11:18:18 +09:00
80ccff9068 Remove no longer necessary guards against default control points
The subscription in which the guards were present was moved from
constructor to `ApplyDefaults()`, and at that point neither the sample
control point or the difficulty point can be the default point, because
there are explicit paths that overwrite those with blank points in the
same methods, prior to the subscription's registration.

The only worry would be that someone would set the default point on the
object themselves, but at that point that is most likely programmer
error anyhow.
2022-01-11 22:14:47 +01:00
76d5225bb9 Rewrite storyboard clock management in slightly different way 2022-01-11 22:00:04 +01:00
970e0cc85a Merge branch 'master' into beatmap-background-with-storyboard-stopping 2022-01-11 21:39:49 +01:00
7a25fe79b7 Fix sample control point time being calculated before defaults applied
In editor contexts, the `StartTimeBindable` subscription in `HitObject`
was firing before defaults were applied, which in the case of sliders
manifested in an infinite end time. `ApplyDefaults()` also did not
always set the time of the control point to the correct value, which
matters when the beatmap is encoded.

Ensure that the control points receive the correct time values during
default application, and only register the `StartTimeBindable` change
callback after defaults have been successfully applied.
2022-01-11 21:38:59 +01:00
e91d3dd8b4 Add failing test for incorrect sample control point time after paste 2022-01-11 21:34:22 +01:00
c328b26de1 Merge pull request #16414 from r00ster91/patch-1 2022-01-11 21:58:08 +03:00
82722cd804 Merge branch 'master' into patch-1 2022-01-11 21:31:13 +03:00
81f24a54a0 Merge pull request #16413 from smoogipoo/improve-blur-quality
Improve quality of beatmap background blurs
2022-01-12 00:11:44 +09:00
a8c3fdd383 Update outdated OpenTabletDriver FAQ links 2022-01-11 16:11:07 +01:00
60e42bf45e Add lenience to fix test failures 2022-01-11 23:01:17 +09:00
e6368fd6b2 Merge branch 'master' into fix-mania-normalised-scroll-speed 2022-01-11 21:24:32 +09:00
906e700b60 Improve quality of beatmap background blurs 2022-01-11 21:22:16 +09:00
01a3cf3849 Merge pull request #16412 from smoogipoo/fix-chatlink-test
Fix incorrect action returned for wiki links in DEBUG mode
2022-01-11 20:52:08 +09:00
ef66ec4622 Also fix MessageFormatter tests 2022-01-11 17:55:43 +09:00
3cb5f43f77 Fix incorrect action returned for wiki links in DEBUG mode 2022-01-11 17:46:49 +09:00
269df08fc9 Make ChatLink tests into proper unit test methods 2022-01-11 17:42:02 +09:00
892374b50b Merge pull request #16411 from peppy/update-framework
Update framework
2022-01-11 16:09:42 +09:00
070903f5e6 Merge pull request #16409 from smoogipoo/fix-most-common-beatlength
Ensure first control point starts at 0 in most common beat length calculation
2022-01-11 15:16:58 +09:00
797d3f5d65 Update framework 2022-01-11 15:09:51 +09:00
38c32d5c3f Merge branch 'master' into fix-most-common-beatlength 2022-01-11 14:49:00 +09:00
38a51b9ce0 Add comment 2022-01-11 13:54:12 +09:00
81fed4c6bf Use time=0 as for the first control point 2022-01-11 12:55:17 +09:00
a09563a7d9 Fix calculation of most common beat length for mania scroll speed 2022-01-11 11:00:30 +09:00
261b8ecad6 Merge pull request #16405 from smoogipoo/fix-pp-counter-underflow
Fix PP counter underflow with SpunOut mod
2022-01-11 10:55:47 +09:00
b88a65166e Fix pp counter underflow with SpunOut mod 2022-01-11 10:22:16 +09:00
90558f809f Merge branch 'master' into slider-snapping 2022-01-10 22:42:16 +09:00
e333831c45 Merge pull request #16371 from bdach/angle-of-rotation-display
Add tooltip with relative rotation in degrees to rotation handles
2022-01-10 22:19:50 +09:00
9756c0ab5c Merge pull request #16309 from peppy/async-deadlock-safety
Apply osu! side fixes for usage of `Task.Wait` and `Task.Result`
2022-01-10 16:39:33 +09:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
928023fabb Merge pull request #16362 from bdach/multiplayer-wrong-ruleset
Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset
2022-01-10 15:10:27 +09:00
5aaf5953f4 Merge pull request #16393 from peppy/detach-already-detached
Add mention to detach methods of only running once
2022-01-10 13:42:50 +09:00
c2843249e8 Merge pull request #16359 from peppy/fix-legacy-score-decoer-test
Fix `LegacyScoreDecoderTest` incorrectly comparing unset beatmap IDs
2022-01-10 13:10:58 +09:00
6f18db2136 Merge pull request #16390 from peppy/fix-filter-matching-tests
Update `FilterMatchingTest` and filter code to use ruleset's `OnlineID`
2022-01-10 13:10:51 +09:00
d072f1d08d Add mention to detach methods of only running once 2022-01-10 13:09:26 +09:00