65b4b198a4
Merge branch 'master' into export
2023-05-06 20:12:53 +02:00
e808a47811
Fix delegate leak
2023-05-05 20:33:27 +02:00
f536238554
Use shorter copy
2023-05-05 20:30:50 +02:00
34b19dd6f4
Merge branch 'master' into slider-velocity-inspector
2023-05-05 20:20:16 +02:00
b7a287869a
Add display of beatmap slider velocity when adjusting
2023-05-05 15:57:38 +09:00
cc70d89bf9
Move editor inspector classes out of ruleset namespace
2023-05-05 15:57:38 +09:00
560f71ef53
Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions
...
Closes https://github.com/ppy/osu/issues/23210 .
Ballparked the fix to work down to the lowest resolution we support. The
previous number (`2.5f`) was also likely ballparked so the fix seems in
line with expectations.
I don't want to put too much thought into this because the design of
this screen is likely going to change in the mean time anyway.
2023-05-05 14:29:04 +09:00
fa3f42ba75
Merge pull request #23386 from peppy/fix-osu-logo-input-handling
...
Extend input handling of osu! logo to full border area
2023-05-03 17:48:51 +02:00
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
444f66b0ee
Move to base class for added safety
2023-05-03 18:46:30 +09:00
cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
5757eb7529
Update a few more instances of 0.96f scale constants
2023-05-03 18:20:12 +09:00
453143813f
Extend input handling of osu! logo to full border area
...
This is the easiest way to make this happen. It does mean the pink area
is being drawn behind the white border, but I haven't found a scenario
where this is noticeable.
Closes #4217 .
2023-05-03 14:57:57 +09:00
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
8a536c1cdb
Fix non-block namespace usage
2023-05-02 15:09:24 +09:00
1dc34ee25d
fix infinite repeat count when adjusting length of 0 length slider
2023-05-01 15:48:54 +02:00
608fa3cc73
Merge remote-tracking branch 'upstream/master' into sample-control-points
2023-04-30 19:47:03 +02:00
607a04ae73
Fix the issue
2023-04-29 10:29:33 +09:00
c44f71a737
remove all regular usage of DifficultyControlPoint
2023-04-26 17:55:38 +02:00
87ca0f5335
Update SamplePointPiece.cs
2023-04-26 13:45:58 +02:00
5ec8ecb11b
Merge pull request #23309 from peppy/key-counters-fix
...
Fix key counters counting during break time
2023-04-25 21:15:12 +02:00
e4b64bdc3e
clean up code stuff
2023-04-25 19:06:29 +02:00
755ad25dbe
clean code
2023-04-25 18:27:20 +02:00
c23a7b014e
add missing }
2023-04-25 18:17:07 +02:00
065464d90c
Fixed DifficultyPointPiece
2023-04-25 18:12:53 +02:00
14af2063e5
Merge pull request #23247 from peppy/round-editor-rotation
...
Always round editor rotation to integer values
2023-04-25 21:43:44 +09:00
6b4032e34b
Add missing binding of IsCounting with contained counters
2023-04-25 21:37:19 +09:00
0a861ffcee
Restructure key counters to use a common flow
2023-04-25 21:37:19 +09:00
7630958633
Stop using Drawable.Name to convey actual UI information
2023-04-25 20:24:36 +09:00
dd2c289ce9
Remove pointless default value
2023-04-25 20:22:12 +09:00
d8b4db3a13
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-25 19:54:31 +09:00
9f4b1f0f24
Always round editor rotation to integer values
2023-04-20 14:30:01 +09:00
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
f0c8a3202b
Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology
2023-04-10 23:22:15 -07:00
52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting
2023-04-11 09:04:02 +09:00
f80de08f24
Adjust BeatmapSetsChanged xmldoc
...
Co-Authored-By: Dean Herbert <pe@ppy.sh >
2023-04-10 11:28:23 -07:00
c7dea71793
Use existing BeatmapSetsChanged action
2023-04-10 11:26:18 -07:00
73bd0feef5
Fix incorrectly implemented localisation
2023-04-10 15:03:33 +02:00
6fec476147
Simplify snap implementation
2023-04-10 14:55:30 +02:00
7f5b99c91b
Fix song select beatmap difficulty count not updating when deleting
2023-04-09 22:12:51 -07:00
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export
2023-04-09 15:02:47 +09:00
8d2e852ffd
Fix overbearing key down handling
2023-04-08 22:30:36 +09:00
a1fc4def1d
Remove redundant method override
2023-04-08 22:18:07 +09:00
3c4a25e53f
Fix tooltip text not resetting when ending an editor rotation
2023-04-08 14:28:52 +02:00
580d5745c0
Add "(snapped)" to the tooltip when snap-rotating in the editor
2023-04-08 14:15:49 +02:00
f72dd86b42
Fix code quality issues and avoid updating bindable twice per operation
2023-04-08 10:40:36 +09:00
c827c2810b
Improve editor selection rotation value wrapping
...
This fixes two issues the previous algorithm had:
1. A half-turn rotation used to show up as -180°.
2. Rotating more than 180° in one drag event would overwhelm it
and cause the value to go outside its range.
This comes at the cost of a negligible performance hit,
since a division (modulo) is performed instead of just addition/subtraction.
2023-04-08 01:30:29 +02:00
f1de560d57
Snap editor selection rotation when holding shift
2023-04-08 01:30:29 +02:00
0c71fa1bbd
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-06 23:39:57 +09:00
