Commit Graph

35052 Commits

Author SHA1 Message Date
ec5fd7ac1d Remove possible 'System.NullReferenceException' 2022-08-24 03:42:16 -04:00
adea29c106 Fix test failures 2022-08-24 03:37:33 -04:00
8f4a2b4936 Separate passed/failed states from calling EndGameplay 2022-08-24 10:36:13 +03:00
b24513038c Add popupdialog button to copy url 2022-08-24 03:35:19 -04:00
a8867d4245 Merge branch 'master' into add-date-created-sort 2022-08-24 03:23:27 -04:00
6344b87b14 Merge branch 'master' into copyexternalurl-user 2022-08-24 03:12:00 -04:00
7f9246637a Simplify MultiSpectatorScreen hierarchy construction 2022-08-24 16:08:48 +09:00
edd50dc05b Add profile url context menu to user container 2022-08-24 03:07:03 -04:00
7c1fc4814e Remove unused CreateMasterGameplayClockContainer method 2022-08-24 16:03:38 +09:00
871365bbb0 Inline ReadyToStart action binding for added safety 2022-08-24 16:03:38 +09:00
6c50f618a3 Don't use bindable flow for masterState 2022-08-24 16:03:38 +09:00
683d49c608 Move MasterClockState handling in to SpectatorSyncManager 2022-08-24 16:03:38 +09:00
d33d705684 Make WaitingOnFrames non-bindable 2022-08-24 16:03:38 +09:00
d05d8aeb22 Simplify interface implementations 2022-08-24 16:03:38 +09:00
2f5be6efca Tidy up ProcessFrame and privatise const 2022-08-24 16:03:38 +09:00
b564c34dbc Don't process master clock (is a noop) 2022-08-24 16:03:38 +09:00
2fa8b61f3c Handle completion user state updates during spectating 2022-08-24 10:02:21 +03:00
7e5086c8d7 Fix spectator client not handling multiple watch calls properly 2022-08-24 10:02:21 +03:00
b4eede61fb Use readonly instead of get-only 2022-08-24 15:28:18 +09:00
0b271fe4b3 Fix incorrect IsRunning value 2022-08-24 15:27:31 +09:00
b6254a1f25 Remove unnecessary casting 2022-08-24 15:23:31 +09:00
a86fc6f248 Change running state of SpectatorPlayerClock using IsRunning 2022-08-24 15:17:56 +09:00
0c9a4ec13c Don't expose MasterClock in SpectatorClockSyncManager 2022-08-24 15:13:08 +09:00
995e6664b6 Rename spectator clock sync classes 2022-08-24 15:13:08 +09:00
31f657fe01 Remove ISpectatorPlayerClock interface
Too many levels of redirection.

One interface with one implementation is not useful, IMO.
2022-08-24 15:12:57 +09:00
882dd93942 Remove ISyncManager interface
Too many levels of redirection.

One interface with one implementation is not useful, IMO.
2022-08-24 15:12:57 +09:00
22963ab951 Fix multiplayer spectator getting stuck 2022-08-24 15:12:57 +09:00
c9f364d6a0 Document why beatLength can be NaN 2022-08-24 02:10:19 -04:00
ec31f37ff7 Accept MasterGameplayClockContainer rather than generic clock 2022-08-24 14:51:14 +09:00
85fbe7abca Fix multiplayer spectator getting stuck 2022-08-24 13:11:53 +09:00
c1ced85b5e Move GenerateTicks to LegacyDifficultyControlPoint and remove support for NaN slider velocity support for other rulesets (at least for now) 2022-08-23 14:07:18 -04:00
3cedd1cd1c Merge branch 'master' into add-date-created-sort 2022-08-23 12:00:30 -04:00
c840977acb Fix filtering potentially not running after new items added 2022-08-23 20:42:20 +09:00
29fed0c4a3 Avoid setting the source clock until gameplay is ready to start
Without this change, the audio track may audibly seek during load
proceedings.
2022-08-23 18:34:17 +09:00
ec61a94dc9 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-23 17:36:06 +09:00
db004c9d9f Fix collection dropdown potentially overwriting value change with schedule hotfix 2022-08-23 17:33:53 +09:00
fbe8de2757 Disable the GetHashCode warning instead of using bindables 2022-08-23 00:57:25 -04:00
553897f2f0 Remove AddClock method to CreateManagedClock 2022-08-23 13:52:43 +09:00
1191b6c080 Remove unused Source_Set implementation on ISpectatorPlayerClock 2022-08-23 13:44:41 +09:00
a81672f3dc Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator 2022-08-22 23:31:24 -04:00
8f708c1dcf Turn GenerateTicks into a bindable to pass code quality tests 2022-08-22 22:43:44 -04:00
9f08c474ca Treat NaN slider velocity timing points as 1.0x but without slider ticks 2022-08-22 21:58:38 -04:00
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
55f1b43329 Removed check 2022-08-22 13:41:36 -04:00
c59298f0ce Enable NRT 2022-08-22 21:55:04 +09:00
489e172a76 Simplify track start/stop/paused tracking 2022-08-22 19:43:18 +09:00
5d3d8681d4 Invert creation of clocks in multi spectator 2022-08-22 19:14:06 +09:00
22072ee16a Include framework configuration in sentry output 2022-08-22 17:03:30 +09:00
c86a75aa5f Update OsuConfigManager in line with ConfigManager logging changes 2022-08-22 17:03:20 +09:00
bcab7aea26 Merge branch 'master' into add-date-created-sort 2022-08-22 04:02:46 -04:00