Commit Graph

37385 Commits

Author SHA1 Message Date
09e5e2629a Add user beatmap availability property 2021-01-03 05:48:49 +03:00
8bb84570df Introduce beatmap availability structure 2021-01-03 05:48:49 +03:00
0e0cb94ed5 testing (#2)
* Catch multiplayer client-related unobserved exceptions better

Silencing an exception from a task continuation requires accessing
`task.Exception` in any way, which was not done previously if
`logOnError` was false.

To resolve without having to worry whether the compiler will optimise
away a useless access or now, just always log, but switch the logging
level. The unimportant errors will be logged as debug and therefore
essentially silenced on release builds (but could still be potentially
useful in debugging).

* move SkinnableHealthDisplay

Similar components are in osu.Game.Screens.Play.HUD while this is not

* Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson

Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases)
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.AspNetCore.SignalR.Client from 3.1.9 to 3.1.10

Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases)
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.1 to 3.3.2

Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.1...v3.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Keep SignalR at last working version on iOS

* Allow signalr to retry connecting when connection is closed without an exception

* Bump InspectCode tool to 2020.3.2

* Disable "merge sequential patterns" suggestions

As they were considered to be detrimental to code readability.

* Replace using static with explicit nested reference

This seems to be an inspectcode bug, as the code is correct and
compiles, but let's just work around it for now.

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Co-authored-by: mcendu <nathandu@outlook.com>
Co-authored-by: Dean Herbert <pe@ppy.sh>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2021-01-03 03:20:25 +01:00
4266c67bb6 Remove duplicated code path in switch. 2021-01-02 19:19:55 +01:00
324f80d994 Fix merge conflicts. 2021-01-02 19:14:10 +01:00
8511112e28 Merge pull request #11380 from bdach/unobserved-exceptions-pt-2
Catch multiplayer client-related unobserved exceptions better
2021-01-02 23:36:49 +09:00
f8fe22df8f Merge pull request #11344 from Susko3/master
Fix file and share associations on Android
2021-01-02 22:44:12 +09:00
26b2a065bc Add deprecation warning ignore with explanation 2021-01-02 14:26:31 +01:00
e2de5bb8f9 Fix the beatmap carousel not returning to centre correctly after resizing window 2021-01-02 22:05:41 +09:00
6c3ccaddbf Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.3.1 to 3.3.2
Bumps [Microsoft.CodeAnalysis.FxCopAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.1...v3.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-02 12:51:41 +00:00
33d8d60717 Merge pull request #11401 from peppy/fix-signalr-reconnect
Allow signalr to retry connecting when connection is closed without an exception
2021-01-02 21:50:29 +09:00
9ab1091281 Merge branch 'master' into fix-signalr-reconnect 2021-01-02 13:18:02 +01:00
8d8e6d7bba Merge pull request #11404 from bdach/bump-inspectcode 2021-01-02 13:17:34 +01:00
924af58f5b Replace using static with explicit nested reference
This seems to be an inspectcode bug, as the code is correct and
compiles, but let's just work around it for now.
2021-01-02 12:25:59 +01:00
18ac97ca56 Disable "merge sequential patterns" suggestions
As they were considered to be detrimental to code readability.
2021-01-02 12:21:53 +01:00
66bd847b45 Bump InspectCode tool to 2020.3.2 2021-01-02 11:53:06 +01:00
72a6ca7755 Allow signalr to retry connecting when connection is closed without an exception 2021-01-02 16:47:00 +09:00
a96478e799 Merge pull request #11399 from bdach/dependency-updates
Update dependencies
2021-01-02 14:27:52 +09:00
fa73d0172e Keep SignalR at last working version on iOS 2021-01-02 00:11:24 +01:00
cecb05f83e Merge branch 'dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.2' into dependency-updates 2021-01-02 00:10:52 +01:00
30cebe7579 Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-3.1.10' into dependency-updates 2021-01-01 21:25:10 +01:00
c3b59a84bc Merge branch 'dependabot/nuget/Microsoft.NET.Test.Sdk-16.8.3' into dependency-updates 2021-01-01 21:23:38 +01:00
22264f2ffe Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-3.1.10' into dependency-updates 2021-01-01 21:22:38 +01:00
6cd838fd4b Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.1 to 3.3.2
Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.1...v3.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-01 17:55:04 +00:00
652b0ccd8f Bump Microsoft.AspNetCore.SignalR.Client from 3.1.9 to 3.1.10
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases)
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-01 17:54:11 +00:00
0fd2e368c1 Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-01 17:53:41 +00:00
7441cfd94e Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/aspnet/AspNetCore) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases)
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-01 17:53:29 +00:00
988f9b98a1 Split button mods updating to private method 2021-01-01 16:16:00 +03:00
c1a1e3acc5 Revert drive-by changes 2021-01-01 15:40:40 +03:00
a031c8e0b6 Apply documentation suggestions
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-01 15:34:09 +03:00
ee664ad571 Add test coverage 2021-01-01 03:47:18 +03:00
2ce9599957 Copy selected mods properties into overlay's buttons 2021-01-01 03:47:13 +03:00
b4df2d6d43 Add method for copying properties from another mod 2021-01-01 03:46:09 +03:00
faed776112 Merge pull request #11382 from mcendu/move-health-meter 2020-12-31 22:39:49 +09:00
79755e1826 Merge branch 'master' into master 2020-12-31 14:36:16 +01:00
1e02f450a6 Merge branch 'master' into move-health-meter 2020-12-31 13:59:37 +01:00
17abe90c27 move SkinnableHealthDisplay
Similar components are in osu.Game.Screens.Play.HUD while this is not
2020-12-31 20:23:13 +08:00
7d9a61fbc1 Handle unobserved exceptions from ready button properly 2020-12-31 11:57:13 +01:00
2d279350ad Catch multiplayer client-related unobserved exceptions better
Silencing an exception from a task continuation requires accessing
`task.Exception` in any way, which was not done previously if
`logOnError` was false.

To resolve without having to worry whether the compiler will optimise
away a useless access or now, just always log, but switch the logging
level. The unimportant errors will be logged as debug and therefore
essentially silenced on release builds (but could still be potentially
useful in debugging).
2020-12-31 11:39:42 +01:00
ec75efe124 Merge pull request #11379 from peppy/fix-perform-from-menu-nullref
Fix PerformFromMenuRunner failing if CurrentScreen is null
2020-12-31 19:10:21 +09:00
1b1447eb35 Merge branch 'master' into fix-perform-from-menu-nullref 2020-12-31 10:33:05 +01:00
00c6703c51 Inline complete method as well
For better guarantees that `finalAction` is actually called on the same
screen that `checkCanComplete()` was (uses result of one
`getCurrentScreen()` call throughout instead of calling multiple times).
2020-12-31 10:27:42 +01:00
f9196ae976 Fix PerformFromMenuRunner failing if CurrentScreen is null 2020-12-31 16:36:20 +09:00
6ebb267c66 Merge pull request #11346 from bdach/fix-changelog-regression
Fix changelog header staying dimmed after build show
2020-12-31 16:15:25 +09:00
8e7877a2a7 Merge branch 'master' into master 2020-12-30 23:36:39 +01:00
9b40334830 Merge pull request #1 from Susko3/fix-android-file-associations
Remove duplicate application/octet-stream
2020-12-30 23:35:36 +01:00
eb64e6bf4d Remove duplicate application/octet-stream 2020-12-30 23:35:07 +01:00
f800448c87 Move game start logic to a higher level 2020-12-30 18:15:48 +01:00
d34609b98e Rename On{ToggleReady -> ReadyClick} 2020-12-30 16:29:36 +01:00
dd87478690 Add helper IsHost property to Client 2020-12-30 16:29:19 +01:00