Commit Graph

50197 Commits

Author SHA1 Message Date
1393e3628b Invert operands for better readability 2022-04-03 15:24:00 +02:00
Ame
35629e9be8 General fix for ToolbarButton toggle repetition 2022-04-02 20:45:00 +02:00
Ame
0f94616890 Make overlay shortcuts able to be toggled instead of repeatable 2022-04-02 19:41:15 +02:00
e2f1183e7d Merge pull request #17615 from frenzibyte/beatmap-panel-size-config
Store beatmap listing card size in game configuration
2022-04-02 19:30:21 +02:00
b815f685fc Flip viaConfig conditional branch 2022-04-02 19:28:33 +03:00
8534dd3463 Simplify TestCase attributes to one Values attribute
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-04-02 19:24:16 +03:00
beb8426d3b Save beatmap listing card size to game config 2022-04-02 18:36:49 +03:00
c4635f3c03 Add failing test case 2022-04-02 18:36:32 +03:00
9d236c503d Merge pull request #17609 from CenTdemeern1/toolbar-clock-tests
Add test coverage for toolbar clock mode cycling
2022-04-02 15:46:57 +02:00
c103cee1d5 Need to commit the second half again because my Git UI messed up 2022-04-02 04:53:47 +02:00
a1baced777 Change behavior of the display mode test
I remembered to run InspectCode this time, all good
2022-04-02 04:45:21 +02:00
ee9696855b Remove hover test 2022-04-02 04:41:05 +02:00
245e452d41 Remove redundant typecast I accidentally left in (Thanks InspectCode) 2022-04-02 04:31:43 +02:00
95ccac50d4 Add display mode changing test
Yup this is gonna fail horribly
2022-04-02 04:26:16 +02:00
9350f6f5f8 Add spaces around commas in Vector2 construction 2022-04-02 02:59:07 +02:00
dc744f18ff Trim whitespace 2022-04-02 02:43:51 +02:00
6685c97147 mainContainer -> toolbarClock 2022-04-02 02:43:44 +02:00
b07152a119 Initial attempt at writing a test for the toolbarClock
I'll add more once I know if this code passes review or not
2022-04-02 02:35:37 +02:00
6776c37bbc Merge pull request #17592 from peppy/skin-mutation-better-naming
Fix automatically created "(modified)" skins getting conflicting names
2022-04-01 21:25:10 +09:00
43d03f2825 Put ToArray call in correct place in brackets 2022-04-01 19:30:16 +09:00
9d93cffbb2 Merge pull request #17490 from frenzibyte/improve-bug-issue
Apply minor changes to the issue report template
2022-04-01 17:04:28 +09:00
fc3ebe9b51 Reword log retrieval steps on mobile platforms
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-04-01 10:40:16 +03:00
01681ee874 Add missing ToArray call
Not sure where this went, was there in my original commit.
2022-04-01 16:19:02 +09:00
cabf6f501f Merge pull request #17594 from peppy/move-skin-component-error-handling
Move `SkinnableInfo` error handling to lower level
2022-04-01 16:04:00 +09:00
c294819128 Merge pull request #17593 from peppy/disable-random-skin-in-skin-editor
Disable ability to use random skin shortcut from within the skin editor
2022-04-01 16:03:50 +09:00
01829cf2d8 Move SkinnableInfo error handling to lower level
Handling was recently added to handle the usage in
`Skin.GetDrawableCompoent`, but it turns out this is also required for
`DrawableExtensions.ApplySkinnableInfo` which can throw in a similar
fashion.

Found while working on sprite support for the editor, where this becomes
an actual issue (ie. switching to a branch where the new sprite support
is not present can cause unexpected crashes).
2022-04-01 14:30:04 +09:00
88306a6180 Disable ability to select random skin from within the skin editor
Reasoning is explained in inline comment.

I knowingly only applied this to the shortcut key. It's still feasible a
user can choose the option from the skin dropdown while the editor is
open, but that's less of an issue (because a user won't get the same
compulsion that I get to mash the key, only to be greeted with 100 new
mutable skins created).
2022-04-01 14:22:32 +09:00
69d4f86122 Fix automatically created "(modified)" skins getting conflicting names
Applies the already tested and proven method that is used in the editor
to the mutable skin creation flow.
2022-04-01 14:11:55 +09:00
0a86bf6fb1 Merge pull request #17588 from peppy/aim-assist-rename
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
2022-04-01 14:04:30 +09:00
4c8f427ad3 Merge pull request #17589 from peppy/tournament-scene-manager-key-bindings
Add ability to switch between most common tournament scenes using key bindings
2022-04-01 14:04:21 +09:00
6b9f5812a5 Merge pull request #17579 from CenTdemeern1/clock-button
Make the toolbar clock feel more like a button
2022-04-01 13:12:48 +09:00
10f15f2bdb Merge pull request #17559 from bdach/mod-overlay/sheared-toggle
Implement sheared toggle button
2022-04-01 13:06:22 +09:00
de625125d6 Rename magnetised mod attraction strength property to match new naming 2022-04-01 13:03:48 +09:00
ea672745b0 Add ability to switch between most common tournament scenes using key bindings 2022-04-01 12:44:49 +09:00
a987cda30d Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
As proposed in https://github.com/ppy/osu/discussions/17375.
2022-04-01 12:15:52 +09:00
338a21f4f0 Merge pull request #17581 from CenTdemeern1/remove-bpm-slider
Remove BPM slider
2022-04-01 11:59:16 +09:00
912b6ae8ff Merge pull request #17194 from hlysine/extract-random-mod-logic-2
Extract the hit object positioning logic of random mod to a separate class
2022-04-01 11:28:53 +09:00
058350dfd8 Fix failing test due to incorrect sizing specification 2022-04-01 10:53:16 +09:00
86d262a355 Merge branch 'ppy:master' into clock-button 2022-03-31 23:08:30 +02:00
d5b0c0ba8c Merge pull request #17575 from peppy/runtime-clock-weight
Increase font weight for runtime clock
2022-03-31 22:30:08 +02:00
1c7b259f8e Merge branch 'master' into mod-overlay/sheared-toggle 2022-03-31 22:20:20 +02:00
e180db145d Add constructor argument to facilitate fixed width/autosizing 2022-03-31 22:19:08 +02:00
b3896257ca Move shear amount to constant 2022-03-31 22:09:03 +02:00
48df34d0a8 Merge branch 'master' into runtime-clock-weight 2022-03-31 21:24:45 +02:00
e14d5b8adb Remove unused using directives 2022-03-31 21:20:30 +02:00
a6875383fc Rebind SaveState() to bpmTextEntry 2022-03-31 21:06:05 +02:00
bdb21b17f7 Fix my code according to the changes @bdach requested 2022-03-31 20:39:26 +02:00
52d723aaa6 Remove BPM slider 2022-03-31 20:11:07 +02:00
c64a90b39e Remove a newline to comply with codefactor 2022-03-31 17:21:50 +02:00
f1aa60c0f1 Make the clock feel more like a button 2022-03-31 16:26:53 +02:00