Commit Graph

43767 Commits

Author SHA1 Message Date
15aa0458bc Use PausableSkinnableSound instead 2021-08-26 17:15:36 +09:00
ec85d7f356 Remove unused helper method 2021-08-26 17:15:23 +09:00
982c4eff14 Merge branch 'master' into taiko-drum-refacor 2021-08-26 17:13:14 +09:00
dc16883681 Merge pull request #14511 from peppy/score-processor-enum-getvalue-overhead-reduction
Avoid `Enum.GetValues` allocation overhead in each score population pass
2021-08-26 10:39:11 +03:00
2f26d270a3 Merge branch 'master' into score-processor-enum-getvalue-overhead-reduction 2021-08-26 09:55:09 +03:00
fb732785d6 Merge pull request #14509 from peppy/replay-frame-comparison-array-overhead-reduction
Avoid unnecessary array/LINQ operations when replay frames have no action changes
2021-08-26 09:54:36 +03:00
b0bab4fda6 Merge branch 'master' into replay-frame-comparison-array-overhead-reduction 2021-08-26 09:30:58 +03:00
10f80ddd90 Merge pull request #14508 from peppy/follow-point-lifetime-entry-bind-overhead-reduction
Avoid unnecessary unbind operations when constructing `FollowPointLifetimeEntry`
2021-08-26 09:29:28 +03:00
b9ea984c36 Remove redundant default value 2021-08-26 08:18:58 +03:00
e32933eb54 Avoid Enum.GetValues in each score population pass 2021-08-26 13:37:53 +09:00
f4199958d9 Avoid unnecessary array/LINQ operations when replay frames have no action changes 2021-08-26 13:03:50 +09:00
69064c1938 Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry 2021-08-26 12:35:31 +09:00
f02b6b3657 Merge pull request #14494 from frenzibyte/editor-quick-mode-switch-crash
Fix editor crashing when quickly switching between screens
2021-08-25 23:43:32 +09:00
3ad0b529fb Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms 2021-08-25 17:14:52 +03:00
c32168c61f Add failing test case 2021-08-25 17:03:34 +03:00
7e6e2a7e29 Remove unused assignment 2021-08-25 17:39:06 +09:00
fd78d0440b Update missed conditional 2021-08-25 17:00:32 +09:00
ccfff50c6f Apply fixes in line with issues found during testing
I was trying to be too smart with caching, but if the `Play` method was
not called often enough it would have a recent reference. Unfortunately
this requires a separate query to `Entries`, but is also a special case
(no future hitobjects).

This also removes the time-based checks (result status alone should be
all we care about).
2021-08-25 16:56:44 +09:00
fc85ae0e34 Add test coverage 2021-08-25 16:56:44 +09:00
ef2b5e1c51 Tidy up variable names and unused resolved properties 2021-08-25 16:56:44 +09:00
8e0a04c4e5 Update taiko InputDrum to use new trigger logic 2021-08-25 16:56:44 +09:00
a1936b141b Refactor base class to allow correct usage in taiko drum 2021-08-25 16:56:44 +09:00
681215e5b5 Rewrite object lookup to use previous entry regardless
This changes the fallback logic to always prefer the previous resolved
lifetime entry rather than fallback to the first entry ever. I think
this is more correct in all cases.

Also rewrites the inline comments to hopefully be easier to parse.
2021-08-25 16:56:44 +09:00
4a294d4de4 Optimise fallback logic to reduce lookups to bare minimum 2021-08-25 16:56:44 +09:00
6aa894e55e Split out separate component 2021-08-25 16:56:44 +09:00
d5fcc5f762 Merge pull request #14485 from peppy/fix-mania-hold-note-input-gobbling
Fix osu!mania hold notes eating input whenever on screen
2021-08-25 15:35:20 +09:00
10cdb1c963 Merge pull request #14484 from peppy/user-events-in-participant-list
Add ability to handle user join/leave/kick events in `MultiplayerComposite`s
2021-08-25 15:14:28 +09:00
351015357c Merge branch 'master' into user-events-in-participant-list 2021-08-25 14:39:26 +09:00
6a1cf12763 Merge pull request #14480 from bdach/countdown-beatmap-info
Add countdown settings to beatmap info
2021-08-25 14:38:34 +09:00
e1ab3434ed Add ability to handle user join/leave/kick events in MultiplayerComposites 2021-08-25 14:37:14 +09:00
ca527262e3 Merge branch 'master' into countdown-beatmap-info 2021-08-25 08:30:27 +03:00
414457ba57 Add basic xmldoc explaining CountdownOffset 2021-08-25 13:24:52 +09:00
6fcbf81995 Merge pull request #14284 from LeNitrous/activity-on-multiplayer-screens
Update Discord user status for multiplayer/playlists
2021-08-25 11:22:26 +09:00
acc27fc79c Add test case for countdown in encode-decode stability test 2021-08-24 22:04:56 +02:00
a6c2cbd2e5 Add countdown settings to beatmap info model 2021-08-24 21:55:10 +02:00
e503182a8d Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00
6252b8aa42 Fix hold notes handling all input ever 2021-08-24 19:08:04 +09:00
4289773371 Merge pull request #14476 from smoogipoo/fix-hud-test-failure-2
Fix gameplay HUD load not always completing if initially hidden
2021-08-24 17:18:40 +09:00
568a8ee97e Merge branch 'master' into fix-hud-test-failure-2 2021-08-24 16:54:48 +09:00
3f0f820653 Add comment explaining reasoning for override 2021-08-24 16:54:19 +09:00
08f757a584 Merge pull request #14474 from smoogipoo/fix-multi-crash
Fix crash when entering multiplayer gameplay
2021-08-24 16:20:18 +09:00
6a916a264f Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
ea98ce1b39 Merge pull request #14465 from peppy/improve-stable-skin-import
Improve skin stable import behaviour to better handle similar skins
2021-08-24 16:08:15 +09:00
9f17c38e36 Fix hud overlay components being blocked from load 2021-08-24 15:18:27 +09:00
342f2d756d Fix test not working intermittently 2021-08-24 15:18:05 +09:00
16c0f3d5b4 Merge pull request #14272 from gagahpangeran/pinned-comment
Add pinned comment section in comment container
2021-08-24 15:11:49 +09:00
a5f6c287ea Split out pinned comment content to only be constructed when required 2021-08-24 14:43:28 +09:00
4bbc98737f Fix english in test steps 2021-08-24 14:39:03 +09:00
8cd972a9fe Merge branch 'master' into pinned-comment 2021-08-24 14:37:31 +09:00
aba9688a6b Merge pull request #14475 from frenzibyte/improve-beatmap-info-wedge
Update beatmap info wedge text on mod change without full refresh
2021-08-24 14:27:36 +09:00