Commit Graph

272 Commits

Author SHA1 Message Date
a3cc0d23b3 Fix typo in xmldoc 2023-02-11 16:26:32 +01:00
6d876fdb9a Automatically select the closest timing point on entering the timing screen 2023-02-10 17:48:56 +09:00
03e623d1d2 Move ControlPointList to own file 2023-02-10 17:37:31 +09:00
78adaa9b03 Enable nullability for timing screen 2023-01-14 02:23:21 +03:00
e90c698e62 Fix WCD does not take into account start time of control points 2023-01-06 16:35:39 +03:00
c6e2104ec2 Refresh waveforms instead of recreating the whole component 2023-01-06 03:46:49 +03:00
f25439e359 Move track change subscription to LoadComplete 2022-12-23 01:54:49 +03:00
f2e8776529 Bind to clock instead of music controller 2022-12-22 15:35:53 +03:00
a18ece8610 Listen for track reload in timing screen 2022-12-22 01:24:23 +03:00
bbf023cf68 Fix incorrect culture used when parsing timeline popup textbox content 2022-12-01 16:12:29 +09:00
2a3b24d058 Avoid need for implicit null casting 2022-11-30 14:21:04 +09:00
0659c84341 Rename method to be more in line with project naming 2022-11-30 14:17:49 +09:00
7dbf379351 Don't use verbatim string literals 2022-11-29 18:22:07 +00:00
218c04c174 Code quality 2022-11-27 03:23:08 +00:00
3c56b9c93a Add OnRowSelected event to EditorTable 2022-11-27 02:47:54 +00:00
792334a190 Move Control Group timing data into it's own component 2022-11-27 02:47:02 +00:00
b6d7bec240 Remove #nullable disabled from EditorTable and it's derived classes 2022-11-27 02:45:56 +00:00
1a914d0df7 Remove #nullable disable from TimingScreen 2022-11-27 02:43:22 +00:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
30f9cc46a7 Protect offset and bpm adjustments from null selection too 2022-11-23 17:25:43 +01:00
d146f86511 Fix crash when hitting 'T' to tap timing while no timing point is selected 2022-11-23 15:39:56 +09:00
4b0ba86bd0 Identify scrolling rulesets using temporary DrawableRuleset instances 2022-11-20 04:12:52 +03:00
2e3af97892 Remove unused using 2022-11-19 12:13:36 +03:00
290369db47 Hide scroll speed slider on rulesets which don't support it 2022-11-19 06:42:27 +03:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
97fcf8cec9 Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo 2022-06-23 04:02:24 +09:00
950551f4fd Fix metronome arm being stuck white when paused 'close enough' to center 2022-06-22 15:33:42 +09:00
a40ad6f784 Add slight transform when resetting arm from almost-zero 2022-06-21 15:07:35 +09:00
82c4d855d4 Rename sample variable to be easier to discern from other fields 2022-06-21 15:05:17 +09:00
16a9e18815 Adjust timing of latch to be more in sync with visuals 2022-06-21 15:02:53 +09:00
7b46d38318 Move colour fade back to where it was 2022-06-21 15:02:43 +09:00
3b79c632f5 Merge branch 'master' into new-metronome-sfx 2022-06-21 14:58:58 +09:00
42701757c3 Fix latch reset logic 2022-06-21 14:52:57 +09:00
72c0fc3fec Merge pull request #18753 from frenzibyte/prevent-mistimed-metronome-beats
Fix metronome playing mistimed beat sounds on editor clock resume
2022-06-21 13:48:42 +09:00
046b848bcd Split group selection to separate method 2022-06-21 12:53:06 +09:00
9763a58392 Change to use ReferenceEquals 2022-06-21 12:05:52 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
ca287d0936 Fix group deselected when table is recreated 2022-06-20 16:56:19 +09:00
a922ea9b01 Fix selection by directly comparing control points
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
3902dc64f0 Fix adjusting offset via button seeking to timing point's offset unexpectedly
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.

Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051.
2022-06-19 01:35:45 +09:00
204348f327 Fix metronome playing mistimed beat sounds on editor clock resume 2022-06-18 04:49:44 +03:00
8a1d11fefb Cancel previous metronome sound playback on pause 2022-06-18 04:07:21 +03:00
1f78a4fadd New audio feedback for metronome 2022-06-17 16:56:09 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
c30644328c Fix timing adjustment repeat buttons firing one change per repeat invocation 2022-06-14 19:21:02 +09:00
776e7c0c71 Work around performance issues 2022-06-13 15:45:08 +09:00
fcf51a6f51 Merge pull request #18530 from peppy/add-cloen-button
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
debd1a59b0 Merge pull request #18539 from frenzibyte/repeating-button-behaviour
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
1c738e22ae Merge pull request #18523 from peppy/tap-button
Add tap for BPM button
2022-06-03 18:11:10 +09:00