Commit Graph

59846 Commits

Author SHA1 Message Date
16c624fb61 Ensure static banana samples are not mutated 2023-05-03 13:02:37 +09:00
90d98cd329 remove constructor argument from Banana 2023-05-02 12:41:39 +02:00
d2d81bb82c remove redundant zero check in sv calculation 2023-05-02 12:29:11 +02:00
2e018c8b06 Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:47 +02:00
c2ad8c2320 Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:30 +02:00
8a536c1cdb Fix non-block namespace usage 2023-05-02 15:09:24 +09:00
e3c384c6b5 Merge branch 'master' into sample-control-points 2023-05-02 14:38:39 +09:00
5da78098ad Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id
Reset online ID on locally modifying beatmap
2023-05-02 12:41:23 +09:00
0b048979f4 Merge pull request #23361 from OliBomby/distance-snap
Enable 'Use current' distance snap when exactly on a hit object
2023-05-02 12:21:57 +09:00
436ebdcfcb Fix beatmap leaderboard test failure
Because the online info reset (which includes online ID reset) was
happening after encoding,
`TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
started failing, as the hash no longer matched expectations after the
first save of the map.
2023-05-01 19:44:15 +02:00
cf5211aec9 Enable current distance snap when exactly on a hit object 2023-05-01 19:22:52 +02:00
1fb4c814f4 Remove no longer needed API call mocking
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.

This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
f470b2c9cc Always reset online info when saving local beatmap 2023-05-01 18:17:45 +02:00
8ab3a87b13 Add failing test case covering online ID reset on save
This test scene passes at e58e1151f3 and
fails at current master, due to an inadvertent regression caused by
e72f103c17.

As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
8c21fddb5e remove all redundancies from encoded control points 2023-05-01 16:53:38 +02:00
8302bb1f37 dont encode custom sample bank for objects without legacy samples 2023-05-01 14:56:29 +02:00
27cfadca16 add sample info to Banana and SpinnerBonusTick 2023-05-01 14:54:06 +02:00
cef9f73d34 dont assign custom sample bank and volume to hitobjects in non-mania gamemodes
this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject
2023-05-01 12:31:27 +02:00
5c066c40b1 Merge pull request #23342 from peppy/cursor-ripples
Implement cursor ripples
2023-05-01 10:34:04 +02:00
d98aa60efc Merge branch 'master' into cursor-ripples 2023-05-01 09:37:50 +02:00
ff29189e89 Add custom cursor-ripple to cover skinnability in test 2023-05-01 09:33:37 +02:00
0a70734331 Adjust ripple size with cursor scale (including CS) 2023-05-01 14:43:49 +09:00
5cbfefbcb4 Adjust metrics of default ripple to match stable default better 2023-05-01 13:29:50 +09:00
b8ae508639 Fix incorrect starting scale for ripples 2023-05-01 13:09:00 +09:00
2a94757154 Make sure the first object you place has bank and volume 2023-05-01 00:49:01 +02:00
608fa3cc73 Merge remote-tracking branch 'upstream/master' into sample-control-points 2023-04-30 19:47:03 +02:00
41d4894aa3 add min and max value to SliderVelocity 2023-04-30 19:32:24 +02:00
4a0ff046ae pass new hitobject properties through beatmap converters 2023-04-30 19:20:42 +02:00
139a1d7e6d fix legacy encoder writing sample info while not writing node samples 2023-04-30 17:46:47 +02:00
79f3cfec91 fix 0 velocity juicestream 2023-04-30 16:43:26 +02:00
e7a478ce9c Update convert-samples-expected-conversion.json 2023-04-30 16:04:03 +02:00
1eb2e35dff fix ticks not being generated by default 2023-04-30 16:03:58 +02:00
72b472a756 Change default scaling and add note about legacy cursor-ripple scale 2023-04-30 14:48:03 +09:00
6a62949fcd Fix positioning and rewinding support for ripples 2023-04-30 14:48:03 +09:00
c994adfc22 Add pooling support for ripples 2023-04-30 14:48:03 +09:00
a4ae9e409b Implement ripples (legacy and default) 2023-04-30 14:48:03 +09:00
b39a9d816e Add basic structural requirements for cursor ripples 2023-04-30 14:48:03 +09:00
83111223e0 fix null sample 2023-04-30 01:08:52 +02:00
a6e780a1b9 Update CheckMutedObjectsTest.cs 2023-04-29 23:52:30 +02:00
92efd04f31 fix sample of drumroll ticks being bankless 2023-04-29 23:52:24 +02:00
ffcc8e91b2 fix legacy parser incorrectly assigning sample info for sliders 2023-04-29 23:51:49 +02:00
6a04708a7e Merge pull request #23332 from peppy/fix-exclusive-fullscreen-detection
Fix exclusive fullscreen notice showing false positives for new renderers
2023-04-29 15:30:04 +02:00
646d4965b9 Merge branch 'master' into fix-exclusive-fullscreen-detection 2023-04-29 14:39:34 +02:00
119687cf6e Merge pull request #23329 from rltn/clickable-country-name-in-profile
Clickable country name in profile
2023-04-29 14:19:13 +09:00
8df5410946 Merge pull request #23333 from Cootz/add-events-for-loading-screen
Fix editor potentially leaving a dangling beatmap if exiting during load too fast
2023-04-29 11:57:24 +09:00
602a276884 Merge branch 'master' into add-events-for-loading-screen 2023-04-29 11:05:45 +09:00
2643100644 Add xmldoc to new test mentioning failure rate and general purpose 2023-04-29 11:05:10 +09:00
32f8c674f4 Extract beatmap retrieval method for more legibility 2023-04-29 11:01:29 +09:00
a6f0186112 Improve legibility and code quality of new test 2023-04-29 10:51:56 +09:00
428b5fad3c Rename test scene to explicitly mention navigation testing 2023-04-29 10:51:56 +09:00