Commit Graph

56221 Commits

Author SHA1 Message Date
8a73831115 Add MP lobby 'warning' SFX for the final seconds of countdown 2022-04-07 13:12:33 +09:00
4432a93d09 Fix replay button being disabled when available locally but not online 2022-04-06 20:43:56 -07:00
edb556643e Add failing replay button enabled test asserts 2022-04-06 20:43:56 -07:00
c997d0fcf0 Merge pull request #17631 from bdach/mod-overlay/full-screen
Implement basic layout & behaviour of new mod select screen
2022-04-07 10:23:49 +09:00
4c20e67478 Merge pull request #17683 from huoyaoyuan/remove-outdated
Remove some outdated packages
2022-04-07 10:13:15 +09:00
c440d89ef9 Merge pull request #17678 from peppy/get-virtual-time-length
Change `WorkingBeatmap.GetVirtualTrack` to use length provided by `BeatmapInfo`
2022-04-07 09:32:59 +09:00
4b3569ea79 Merge pull request #17576 from peppy/fix-multiplayer-unobserved
Centralise exception handling of `MultiplayerClient` calls
2022-04-07 09:09:55 +09:00
c1693e4387 Use LegacySkinPlayerTestScene instead of reimplementing 2022-04-07 00:13:56 +03:00
4f928232ee Merge pull request #17677 from peppy/fix-multiplayer-match-song-select-realm
Fix dangerous realm operation in `TestSceneMultiplayerMatchSongSelect`
2022-04-06 22:28:57 +02:00
bcb9eef082 Merge branch 'master' into fix-multiplayer-match-song-select-realm 2022-04-06 21:58:12 +02:00
ec4f1bcbc8 Remove outdated NETCore packages. 2022-04-06 19:18:18 +08:00
43724f477a Remove outdated NU1701 warning. 2022-04-06 19:14:00 +08:00
2c8fcadb97 Merge pull request #17679 from peppy/ensure-intro-is-protected
Ensure intro beatmap has protected flag set
2022-04-06 19:06:41 +09:00
c42ef43faa Ensure intro beatmap has protected flag set
In cases this isn't set, the beatmap has likely entered a bad state.

Closes https://github.com/ppy/osu/issues/17659.
2022-04-06 16:46:53 +09:00
065bb60324 Remove unused using statements 2022-04-06 16:05:11 +09:00
c2b2d443ed Add more comprehensive assert output to try and discern CI issues 2022-04-06 15:31:12 +09:00
2b8a5833dd Fix back-to-front conditional check 2022-04-06 15:13:02 +09:00
d17890ca9a Replace a couple more local test beatmap cases which can instead use TestResources methods 2022-04-06 15:04:15 +09:00
552ec5282f Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo
A lot of tests are using test resources that populate the length field,
but do not populate hitobjects. The general expectation is that
components should be using the cached length in cases where hitobjects
are not relevant, but `GetVirtualTrack` was doing its own local
calculation.

This could cause tests to fail due to `MusicController` changing track
in the background.
2022-04-06 14:51:15 +09:00
220d7bc6db Fix dangerous realm operation in TestSceneMultiplayerMatchSongSelect
The import process was running on the async load thread, but then
accessed from the access thread later on. This seemed to somehow pass
fine in headless runs, but would fail on visual test execution
(specifically on `TestBeatmapConfirmed()`).
2022-04-06 14:01:41 +09:00
f795f77cf9 Add missing newline 2022-04-06 14:00:54 +09:00
a3695c7e97 Merge branch 'master' into fix-spectator-seeks 2022-04-06 12:58:43 +09:00
c540810943 Merge branch 'master' into fix-multiplayer-unobserved 2022-04-06 11:33:10 +09:00
01da3924cc Simplify IsCurrentScreen check to only apply to relevant call 2022-04-06 11:32:35 +09:00
ce70957fbf Remove redundant code 2022-04-06 02:38:56 +03:00
ec5ad995f8 Reorder taiko playfield elements to fix hit explosion Z-ordering 2022-04-06 02:37:57 +03:00
e4f6e842b0 Expose input drum SkinnableDrawable in InputDrum for width consumption
This is probably not a good way to approach this, but I'm unsure about
any other way.
2022-04-06 02:35:00 +03:00
55c56c03a5 Propagate legacy input drum size to main piece 2022-04-06 02:34:07 +03:00
16f626fb64 Add legacy classic taiko player test scene 2022-04-06 01:21:19 +03:00
2525ec0d18 Switch 24H toggle from UI settings to language settings 2022-04-05 17:07:58 -04:00
3408f2bbe0 Merge branch 'master' into taiko-target-classic-position 2022-04-05 23:22:46 +03:00
9d475f7b33 Add config in settings for forcing 24H time, determines default off CurrentCulture 2022-04-05 16:21:28 -04:00
9c91e6d8f5 Merge branch 'master' into mod-overlay/full-screen 2022-04-05 21:29:40 +02:00
74706f72e6 Add 12-hour display setting (TODO add toggle) 2022-04-05 15:10:55 -04:00
ac799aaf7a Add missing newline 2022-04-05 19:25:47 +09:00
32daf64a31 Use newly exposed framework helper function to find closest parent 2022-04-05 19:24:34 +09:00
631aa2a6ec Remove left padding to allow left-most column to exist further to the.. left 2022-04-05 18:44:25 +09:00
54715885af Adjust animation metrics slightly 2022-04-05 18:41:01 +09:00
7a1820e6bb Fix multiplier display resetting transformations 2022-04-05 18:40:48 +09:00
9fdeb20537 Animate individual ModColumns during togle of oerlay 2022-04-05 18:27:34 +09:00
901032bfa2 Animate multiplier display 2022-04-05 18:25:27 +09:00
6b0392f990 Merge pull request #17597 from peppy/skin-editor-import-at-cursor
Import new skin editor sprites to the cursor location
2022-04-05 18:09:00 +09:00
7623f3b90b Merge branch 'master' into skin-editor-import-at-cursor 2022-04-05 17:39:11 +09:00
2b59f76b2d Merge pull request #17596 from peppy/skin-editor-sprites
Allow importing sprites into a skin via drag-and-drop
2022-04-05 17:38:58 +09:00
497e5e3a36 Slightly adjust scroll handling and also apply to ModSettingsContainer 2022-04-05 17:19:33 +09:00
a408776734 Limit FillFlow of columns to applicable direction 2022-04-05 17:15:05 +09:00
388322cd61 Speed up customisation panel toggle a bit 2022-04-05 16:56:24 +09:00
58e9147b12 Simplify and better comment nested scroll conditionals 2022-04-05 16:48:25 +09:00
2ec15a1ebe Fix lookup through transformers 2022-04-05 16:47:15 +09:00
f156cb797d Improve nested scroll behaviour 2022-04-05 16:46:09 +09:00