Commit Graph

661 Commits

Author SHA1 Message Date
3268a75f05 Remove intermediate container to fix tests 2021-05-03 17:35:56 +09:00
839ac968a9 Fix tooltips displaying for hidden SelectionHandler content 2021-05-03 17:28:24 +09:00
4cfa858dc4 Fix tooltips displaying for hidden SelectionHandler content 2021-05-03 15:37:15 +09:00
01984de9c7 Use existing GetStateFromSelection helper function 2021-05-03 15:13:32 +09:00
8c9cfb6301 Remove unsafe access to Composer.HitObjects 2021-05-03 14:28:35 +09:00
b83aa0bd76 Avoid LINQ in update 2021-05-02 06:21:14 +03:00
0aa17e7c95 Rewrite selection box computation logic with RectangleF's helper methods 2021-05-02 02:51:06 +03:00
07fe99025f Use bounding box of blueprint for computing selection box area 2021-05-02 02:36:40 +03:00
9c62c90cfc Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates
Until now, the implementation of the overrides in `SelectionBlueprint`
have been confusing to the point where I would just implement by
trial-and-error (or copying from an existing implementation). This was
due to a combination of using "object" space coordinates
(ie. the thing the `Blueprint` is operating on) and screen-space coordinates.

This change switches all event related coordinates to screen-space,
which is how we already handle rotation/scale operations. With the
introduction of other editor types where the related objects are
drawables, this also makes a lot more sense.
2021-04-29 16:10:42 +09:00
e0906daebf Change one remaining instance of incorrect terminology in xmldoc 2021-04-28 13:49:41 +09:00
4c9e94da2b Move context menu logic to base class 2021-04-28 13:43:16 +09:00
532ec40395 Remove unnecessary newline 2021-04-28 12:04:48 +09:00
43772f4303 Remove duplicated call to initially select blueprint 2021-04-28 12:03:41 +09:00
e4f2e0131c Rename AllowDeselection to better match use case 2021-04-28 12:02:55 +09:00
a9a5809e94 Fix incorrect xmldoc in MoveSelectionEvent 2021-04-28 11:46:52 +09:00
d0be8f9fb3 Remove one more out-of-date comment 2021-04-28 11:45:36 +09:00
bc455005a5 Fix incorrect coordinate space mention in xmldoc 2021-04-28 11:44:50 +09:00
61d4eb1777 Remove unnecessary and out-of-place xmldoc 2021-04-28 11:44:19 +09:00
aa1cb65eaa Rename region to be more inclusive 2021-04-28 11:42:22 +09:00
42255f8d33 Rename and xmldoc selection completed method 2021-04-27 19:01:29 +09:00
7ec5ea1eb5 Remove hitobject terminology from base classes 2021-04-27 19:01:29 +09:00
ff06a27a12 Revert changes to OnBlueprint methods and handle select-on-addition locally 2021-04-27 19:01:29 +09:00
f97b14a20a Fix binding direction of selected items 2021-04-27 19:01:29 +09:00
dd3d8e5d03 Make SelectionHandler abstract to ensure things get implemented 2021-04-27 19:01:29 +09:00
32416e4e31 Move model selection handling to base SelectionHandler class 2021-04-27 19:01:29 +09:00
eac139ca0e Allow BlueprintContainer to perform movement without an ISnapProvider 2021-04-27 19:01:29 +09:00
f2e56bd306 Refactor editor selection/blueprint components to be generic 2021-04-27 19:01:29 +09:00
485da47d89 Revert "Inherit VisibilityContainer and make duration constant protected"
This reverts commit c58ef4230d. Uhh, how did I push this..
2021-04-26 01:41:42 +03:00
b252485e1a Remove protected expose of HandlingMouse setter
Regardless of `OnDragEnd()`, `OnMouseUp()` will still be called resetting the value of that state back.
2021-04-25 20:13:23 +03:00
7390a12e4b SelectionBoxDragHandleDisplay -> SelectionBoxDragHandleContainer 2021-04-25 20:03:15 +03:00
c58ef4230d Inherit VisibilityContainer and make duration constant protected 2021-04-25 20:03:15 +03:00
79e2b232d8 Improve English
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-04-25 19:26:53 +03:00
a8c460f7df Replace separated top-centered rotation button with rotation drag handles 2021-04-25 10:17:36 +03:00
77f7d4c963 Add composite managing display of selection box drag handles 2021-04-25 10:17:36 +03:00
ab71782674 Use colour fade transform for selection box controls
To become harminous with the fade transforms of the rotation control
2021-04-25 10:14:31 +03:00
62bcc5f76d Add property for tracking whether control is during operation 2021-04-25 10:14:31 +03:00
206fc94b8c Add rotation drag handle component 2021-04-24 08:00:36 +03:00
4bfa9cd6b6 Change inheritance of selection box buttons to base control instead 2021-04-24 08:00:29 +03:00
decd8803bc Abstract base appearence and hover update from drag handles 2021-04-24 07:45:53 +03:00
a5364b224f Add simple key based time nudging support to editor 2021-04-22 18:47:04 +09:00
1884c18a2c Ignore movement operations which have no offset 2021-04-22 18:12:03 +09:00
0825fc57a9 Move foreground colour helper into OsuColour 2021-04-19 18:24:48 +02:00
97573fb11d Merge branch 'master' into combo-colours-display 2021-04-19 18:21:57 +02:00
a8027d87b6 Fix unreadable colour hex code text due to low contrast
Logic is shared with the timeline blueprints which also have the same
problem of displaying text on top of a combo colour.

Slightly modified the formula. Seems to yield better results on a
subjective check.
2021-04-18 20:44:55 +02:00
cfc7664094 Use full path 2021-04-18 21:05:23 +09:00
e76565dbc5 Fix selection box not displaying after pasting a selection in the editor
Closes #12471.
2021-04-18 20:28:39 +09:00
d9d50f0e88 Add border showing selected blueprints in timeline 2021-04-16 18:16:22 +09:00
3c8e2b8b32 Merge branch 'master' into fix-potential-deselection-crash 2021-04-16 16:27:47 +09:00
d3acbcced7 Merge pull request #12437 from peppy/fix-editor-placement-commit-false
Fix placement blueprints not being correctly removed after a rolled back placement
2021-04-16 16:25:05 +09:00
c59906e925 Fix an occasional crash when deleting a HitObject via internal means 2021-04-16 15:55:33 +09:00