Commit Graph

661 Commits

Author SHA1 Message Date
96652e07cd Merge branch 'master' into zero-spinner-slider 2021-02-05 09:40:55 -05:00
5061231e59 Switch to beat length 2021-02-05 09:39:14 -05:00
b489e92c9e Fix TimelineParts not using correct beatmap 2021-01-25 18:44:36 +09:00
04095cd5b9 Merge branch 'master' into fix-editor-scroll-interruption 2021-01-21 17:46:18 +09:00
9eb74e86ed Apply comment suggestion
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-21 17:40:15 +09:00
5ee3a5f230 Use AlmostEquals 2021-01-20 13:00:25 -05:00
ce3c2f07dc Fix zero length spinners and sliders 2021-01-20 12:19:52 -05:00
831c06a3c7 Expose and consume boolean covering whether an ongoing smooth seek is running 2021-01-15 16:14:38 +09:00
04fa32bc34 Rename and add xmldoc for smooth seeking method 2021-01-15 16:14:21 +09:00
ed78be825f Fix editor timeline not snapping on non-precise wheel scroll
For wheel input with precision, we still prefer exact tracking for now.
May change this in the future based on feedback from mappers, but it
makes little sense to do non-snapped scrolling when input is coming from
a non-precise source.
2021-01-15 15:47:42 +09:00
423c6158e1 Highlight timeline drag area when hovered for better visibility 2020-12-21 18:10:11 +09:00
d1be7c23d9 Increase height of timeline drag area 2020-12-21 18:09:56 +09:00
d11d754715 Increase size of circle display on timeline 2020-12-21 18:09:37 +09:00
f1878eff63 Use yet another solution leveraging padding 2020-12-18 23:45:42 +01:00
122250f454 replace drag cirle function with dictionary 2020-12-18 10:45:23 -05:00
9079d33412 X before Y for sanity 2020-12-18 11:20:21 +09:00
44f4ed4fd3 Fix spacing 2020-12-18 11:19:40 +09:00
a0235a06e6 update comment 2020-12-17 19:40:21 -05:00
a01ed1827a Align the drag circles on the selction box in the editor to be on the center of the border 2020-12-17 19:34:16 -05:00
7d2b77cdbd improve selection box rotation UX 2020-12-13 07:58:58 -05:00
71a121389b Merge pull request #11033 from smoogipoo/immutable-hit-samples
Make HitSampleInfo immutable
2020-12-02 14:44:26 +09:00
94a8784e04 Allow editor change handler to be null 2020-12-01 20:08:31 +01:00
190c6ef45e Fix timeline not updating ticks correctly after arbitrary timing control point changes 2020-12-01 16:44:08 +09:00
5760e1c1fc Make HitSampleInfo immutable 2020-12-01 15:37:51 +09:00
c17d67bc7d Merge branch 'master' into editor-beat-snap-always 2020-11-30 18:34:38 +09:00
7edbba58f7 Avoid updating hitobjects unnecessarily for start time changes
This was firing regardless of whether the start time was changed, such
as where beat snap provided the same time the object already has.

The case where a change actually occurs is already handled by
EditorBeatmap (see `startTimeBindables`), so it turns out this local
handling is not required at all.
2020-11-27 16:31:06 +09:00
741902f1b3 Merge pull request #10971 from smoogipoo/fix-timeline-combo-colour
Fix timeline blueprints sometimes not receiving combo colours
2020-11-26 19:47:21 +09:00
da6bccc812 Apply beat snap if positional snap doesn't give a time result 2020-11-26 19:20:51 +09:00
91592cf32d Expose EditorClock for consumption 2020-11-26 19:20:39 +09:00
9811c46e35 Rename application method to better describe what it actually does 2020-11-26 19:16:18 +09:00
e53f849aa0 Completely separate combo colours from DHOs 2020-11-26 18:14:25 +09:00
f562854feb Fix timeline objects sometimes not receiving combo colours 2020-11-26 17:22:22 +09:00
0ddeff648d Fix incorrect index lookup on non-ordered selections 2020-11-25 17:25:54 +09:00
c9a41f9dae Make all objects in selection candidates for spatial snapping
Closes #10898.
2020-11-24 17:35:54 +09:00
f00c23b4a0 Add comment + xmldoc 2020-11-18 13:37:15 +09:00
783c172b5d Make sealed and cleanup comparator 2020-11-18 13:33:22 +09:00
58c8184ad7 Define blueprint order similarly to hitobjects 2020-11-17 22:56:31 +09:00
7b79b9b9c1 Merge branch 'master' into fix-quick-delete-crash 2020-11-16 13:54:54 +09:00
399a1a16a0 Refactor beginClickSelection in a slightly different way 2020-11-15 21:06:47 +01:00
1db303b159 Revert beginClickSelection logic 2020-11-15 16:54:48 +01:00
8a78d408db Add more missed null checks 2020-11-14 15:52:12 +01:00
610ed99ae3 Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
4d2bc790fd Fix crash on shift+right-click deleting objects 2020-11-14 13:20:16 +01:00
0219aff7bc Add timeline visible range adjustment 2020-11-13 17:10:29 +09:00
3957697c48 Add pooling support to the editor 2020-11-13 17:08:20 +09:00
4ef2e9548c Pass HitObjectComposer to BlueprintContainer via ctor 2020-11-13 16:59:37 +09:00
de6fcd1792 Fix BlueprintContainer triggering assert when left and right mouse button are pressed together 2020-11-10 17:16:28 +09:00
a012105dac Fix editor quick delete being triggerable from left mouse button
Closes https://github.com/ppy/osu/issues/10629.
2020-11-10 16:54:37 +09:00
ddbd6df24d Unbind bindable lists for general safety 2020-11-07 20:59:57 +01:00
ea2fd831ab Merge branch 'master' into editor-slider-control-point-quick-delete 2020-11-05 00:38:42 +09:00