Commit Graph

38516 Commits

Author SHA1 Message Date
1884c18a2c Ignore movement operations which have no offset 2021-04-22 18:12:03 +09:00
d2ee5fcd85 Merge pull request #12438 from smoogipoo/fix-initial-spectator-state-callback
Fix OnUserBeganPlaying not being invoked if already watching
2021-04-22 17:17:02 +09:00
daafa41dc1 Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-22 16:22:04 +09:00
68807a90ec Merge pull request #12448 from smoogipoo/gcc-abstraction
Make GameplayClockContainer abstract and add MasterGameplayClockContainer
2021-04-22 16:20:52 +09:00
5a6a6a4742 Merge pull request #12525 from peppy/update-framework
Update framework
2021-04-22 15:59:17 +09:00
60b702549d Update framework 2021-04-22 14:20:49 +09:00
ebfe9cbe23 Merge pull request #12516 from peppy/update-framework
Update framework
2021-04-21 18:06:00 +09:00
deeb9e3765 Update framework 2021-04-21 17:27:00 +09:00
cf55383fff Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry
Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject
2021-04-21 17:08:21 +09:00
452f282e2c Merge pull request #12513 from peppy/tablet-rotated-preview
Show tablet preview with physical tablet counter-rotated for supplied user area
2021-04-21 16:46:09 +09:00
31c5fb350f Merge branch 'master' into gcc-abstraction 2021-04-21 16:33:36 +09:00
fb848f7544 Rename to MasterGameplayClock 2021-04-21 16:33:14 +09:00
ab2a8b5c89 Fix initial rotation not being set 2021-04-21 16:12:09 +09:00
eb20865c02 Show tablet preview with physical tablet counter-rotated for supplied user area selection
Closes https://github.com/ppy/osu/issues/12399.

Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).
2021-04-21 15:55:15 +09:00
3fbeadf318 Deprecate old overload of Apply 2021-04-21 14:32:37 +09:00
73d3da1687 Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 11:32:01 +09:00
6164902eba Merge pull request #12510 from smoogipoo/fix-wiggle-slider-tails
Fix slider tails wiggling independently
2021-04-21 11:30:13 +09:00
e454037d82 Add to comment 2021-04-21 10:32:13 +09:00
397df41570 Merge pull request #12507 from peppy/fix-cursor-position-rotated
Fix click-to-resume cursor location being incorrect when playfield is transformed
2021-04-21 10:29:35 +09:00
9d423201ed Fix slider tails wiggling independently 2021-04-21 10:29:18 +09:00
be71b383f5 Merge pull request #12506 from peppy/fix-mod-customisation-input-blocking-padding
Fix mod settings blocking input outside its visible area
2021-04-21 10:11:35 +09:00
44ff08cce4 Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."
This reverts commit 67fcfd9d
2021-04-21 10:02:50 +09:00
67fcfd9dbc Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 09:48:16 +09:00
e80c3c317a Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry
"Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.
2021-04-21 09:23:23 +09:00
a2afa38a3f Merge branch 'master' into fix-mod-customisation-input-blocking-padding 2021-04-20 19:41:25 +02:00
881043bc5d Fix failing test after mod settings layout changes
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.

Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
4910d8f56c Fix click-to-resume cursor location being incorrect when playfield is transformed
Closes #12501.
2021-04-21 00:12:49 +09:00
26430e3cb5 Merge pull request #12492 from Naxesss/bg-audio-quality-checks
Add background and audio checks
2021-04-21 00:10:32 +09:00
7fc450c620 Fix mod settings blocking input outside its visible area
Closes #12502.
2021-04-20 23:42:56 +09:00
4cc3321d54 Fix potential doubling of events 2021-04-20 21:20:08 +09:00
a9e4a0ed50 Fix potentially starting play when finished
The UserFinishedPlaying event may trigger before the event is subscribed
to by SpectatorScreen. For such cases, an extra check is done to make
sure the user is _actually_ playing.
2021-04-20 21:19:08 +09:00
156a518068 Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-20 21:16:05 +09:00
e9dfa2860a Add xmldoc note about path being relative 2021-04-20 13:44:06 +02:00
d7a81471c8 Add xmldoc to GetPathForFile 2021-04-20 13:40:38 +02:00
86772869da Merge pull request #12498 from peppy/barrel-roll-faster-spin
Allow faster roll speed selection in "Barrel Roll" mod
2021-04-20 20:39:45 +09:00
1edda5878c Merge pull request #12499 from peppy/barrel-roll-keep-numbers-aligned
Keep hitcircles aligned with view in "Barrel Roll" mod
2021-04-20 20:39:17 +09:00
65efb7ca4e Merge pull request #12497 from peppy/remove-catch-hyperdash-glow-fade
Remove catcher fade during hyperdash
2021-04-20 20:36:17 +09:00
3e1b6b3b34 Simplify verifier run call args
Uses the resolved working beatmap instead of resolving it every time.

Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
6a1e4ff99f Add file hash to file presence test
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
5262d94e21 Fix wrong assert in offscreen test 2021-04-20 13:21:57 +02:00
c5d6b6ea8d Fix tests failing intermittently
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.

The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
ac0ed72d04 Keep hitcircles aligned with view in "Barrel Roll" mod 2021-04-20 18:36:11 +09:00
f144661c31 Fix storyboard sample test scene 2021-04-20 18:26:30 +09:00
ec080fcb32 Move seekOffset back to MasterGameplayClockContainer 2021-04-20 18:25:46 +09:00
f11b068dee Allow faster roll speed selection in "Barrel Roll" mod 2021-04-20 18:22:58 +09:00
ddf1b560f3 Remove catcher fade during hyperdash
Closes https://github.com/ppy/osu/issues/12472.
2021-04-20 18:18:51 +09:00
3932f6c3e3 Merge pull request #12496 from smoogipoo/fix-pre-seek-sample-lifetime
Fix storyboard samples not getting a lifetime end if initially seeked past
2021-04-20 18:07:15 +09:00
a683e5ec34 Seek using local method 2021-04-20 17:40:11 +09:00
97fb90d9f4 Move clock processing to base.Seek() 2021-04-20 17:35:59 +09:00