18e5081523
Fix test failures
2021-02-05 00:42:38 +09:00
65d45ec74c
Unschedule cancellation
2021-02-03 20:50:22 +09:00
90ba8ae234
Don't part room if join task was cancelled
2021-01-30 23:39:01 +01:00
c3ba92f057
Set canceled result in scheduleAsync
...
Was holding up the task completion source, and in consequence,
potentially the entire task chain.
2021-01-30 16:13:50 +01:00
9ab1ad25eb
Merge branch 'master' into fix-leave-room-race-2
2021-01-30 13:41:04 +01:00
fec3bd898e
Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash
2021-01-30 13:34:00 +01:00
6a1387191a
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-30 13:01:52 +01:00
44e88f09e5
Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure
...
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
2021-01-29 18:58:00 +01:00
16f3d1815f
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
...
It turns out the SQLite API isn't smart enough to handle nullables
directly, so we need to help it out a bit.
Stops the following from being thrown:
```
System.InvalidOperationException: Value must be set.
at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
at
at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
stmt) = 3 at
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
behavior)
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
at
osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
set, BeatmapInfo beatmap) in
/Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
166 = 166
```
2021-01-29 19:53:57 +09:00
cd8ef5373d
Merge pull request #11622 from peppy/remove-unobserved-exception-handling
...
Remove all usage of CatchUnobservedExceptions
2021-01-29 19:31:07 +09:00
d52376cc17
Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust
...
Add scroll speed adjustment to taiko's DifficultyAdjust mod
2021-01-29 19:25:17 +09:00
18e6afbec0
Ensure the item is present before trying to select it
2021-01-29 19:17:12 +09:00
1ce383fc20
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-29 19:16:20 +09:00
37ef5c7072
rename SliderVelocity to ScrollSpeed
2021-01-29 15:04:55 +06:00
a61444690e
Remove all usage of CatchUnobservedExceptions
...
This should no longer be required with the recent framework side change
that stops a game from crashing on unobserved exceptions
(https://github.com/ppy/osu-framework/pull/4171 ).
2021-01-29 16:32:29 +09:00
c3aec3bfe4
Revert test changes to test original class/scope
...
Importantly, this removes the call to CatchUnobservedExceptions(), which was
outright incorrect (awaiting on the wrong task as a result) in the
original test code.
2021-01-29 16:20:26 +09:00
1ec305e10d
Update TaskChain to use ContinueWithSequential internally
...
It turns out we may still want to use TaskChain for its locking
behaviour, so I've made it internally use the refactored version I
implemented, while keeping the general structure.
2021-01-29 16:19:46 +09:00
449f883be1
add SV multiplier adjustment to TaikoModDifficultyAdjust
2021-01-29 11:48:51 +06:00
4c4770bf4b
Merge pull request #11618 from vltspr/catch-auto-fix
...
Fix Catch autoplay rewinding on instantaneous hits
2021-01-29 12:17:46 +09:00
d168de0ae3
Formatting
2021-01-29 03:03:23 +01:00
da4c207a73
Fix the ctb auto mod speedup in some occasions
2021-01-29 02:53:26 +01:00
1d76cfe585
Merge pull request #11615 from peppy/ios-signalr-use-json
2021-01-29 00:04:16 +01:00
0f1d72e073
Merge branch 'master' into ios-signalr-use-json
2021-01-28 23:28:49 +01:00
c592c80a07
Merge pull request #11616 from peppy/fix-ios-beatmap-cache-lookups
...
Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
2021-01-28 23:17:54 +01:00
386f9f7842
Fix typos in comments
2021-01-28 22:36:07 +01:00
8afd1bce21
Merge branch 'master' into fix-ios-beatmap-cache-lookups
2021-01-28 22:33:58 +01:00
34f8e4b672
Merge pull request #11613 from bdach/order-attribute-move
...
Remove game-local enum `[Order]` attribute
2021-01-29 00:41:43 +09:00
87e23d22cf
Merge pull request #11611 from frenzibyte/fix-package-downgrade
...
Fix dotnet run/publish with runtime specified not working again
2021-01-29 00:18:27 +09:00
a616688a47
Update framework
2021-01-28 23:55:03 +09:00
c3d4044017
Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
2021-01-28 16:53:56 +09:00
90a82f986b
Fallback to using json for signalr communication if JIT is unavailable
2021-01-28 16:20:19 +09:00
2c08ce05fa
Remove game-local enum [Order] attribute
...
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
63f057a525
Fix dotnet run/publish with runtime specified not working again
2021-01-27 20:45:52 +03:00
15e455231e
Merge pull request #11610 from peppy/update-framework
...
Update framework
2021-01-27 23:56:08 +09:00
45395cb5e8
Update framework
2021-01-27 23:00:14 +09:00
a30aecbafe
Comment and add xmldoc
2021-01-27 20:01:21 +09:00
fcfb0d52c2
Proposal to use extension method instead of TaskChain class
2021-01-27 19:50:16 +09:00
3b6c82bb03
Merge pull request #11607 from peppy/add-messagepack
...
Switch spectator and multiplayer to use more efficient MessagePack protocol
2021-01-27 13:50:45 +09:00
7d06af916c
Merge branch 'master' into add-messagepack
2021-01-27 13:00:46 +09:00
248989b3eb
wip
2021-01-27 01:20:50 +09:00
085115cba5
Make threading even more thread safe
2021-01-26 22:49:01 +09:00
8c3b0a3167
Fix TaskChain performing the action in-line, add test
2021-01-26 22:47:37 +09:00
67014018fc
Merge pull request #11589 from MiraiSubject/osu-mod-icon-fallbacks
...
Allow tournament client to use default mod icons if custom icons are not present
2021-01-26 19:57:21 +09:00
81ab82fafe
Tidy up nesting
2021-01-26 19:16:38 +09:00
64a3c712aa
Rename class and add xmldoc
2021-01-26 19:15:19 +09:00
a5f3418e56
Avoid tooltip display
2021-01-26 19:11:19 +09:00
fedcbf79fa
Merge pull request #11572 from EVAST9919/comment-pill
...
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
bd86b535db
Merge pull request #11605 from frenzibyte/fix-beatmap-listing-2
...
Fix beatmap listing placeholder disappearing on second time display
2021-01-26 18:28:42 +09:00
15885c17af
Remove unused usings
2021-01-26 18:07:43 +09:00
468dfbecbe
Merge branch 'master' into fix-beatmap-listing-2
2021-01-26 17:56:37 +09:00
