Commit Graph

59820 Commits

Author SHA1 Message Date
1a04be15c7 Fix fade in delay for first slider end circle being incorrect when snaking disabled 2023-05-02 16:27:17 +09:00
e3c51b9652 Add ability to toggle snaking in slider test scene 2023-05-02 16:26:56 +09:00
4a97c2c105 Merge pull request #23038 from cdwcgt/scale-background-dim
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
ce4a6c38a0 Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
1e4a628cb1 Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
57f48e0703 Start colour black to ensure initial appear transition doesn't look silly 2023-05-02 14:33:57 +09:00
ab4f66fad3 Minor readability refactors 2023-05-02 14:31:39 +09:00
7a840e1d82 Remove unnecessary TransferValue spec 2023-05-02 14:29:26 +09:00
7efaa299bd Merge branch 'master' into scale-background-dim 2023-05-02 14:24:54 +09:00
736be6a73b Refactor slightly for readability 2023-05-02 14:11:16 +09:00
e808e7316b Mark delegate value unused and add comment to avoid future regression 2023-05-02 13:29:30 +09:00
5da78098ad Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id
Reset online ID on locally modifying beatmap
2023-05-02 12:41:23 +09:00
0b048979f4 Merge pull request #23361 from OliBomby/distance-snap
Enable 'Use current' distance snap when exactly on a hit object
2023-05-02 12:21:57 +09:00
436ebdcfcb Fix beatmap leaderboard test failure
Because the online info reset (which includes online ID reset) was
happening after encoding,
`TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
started failing, as the hash no longer matched expectations after the
first save of the map.
2023-05-01 19:44:15 +02:00
cf5211aec9 Enable current distance snap when exactly on a hit object 2023-05-01 19:22:52 +02:00
1fb4c814f4 Remove no longer needed API call mocking
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.

This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
f470b2c9cc Always reset online info when saving local beatmap 2023-05-01 18:17:45 +02:00
8ab3a87b13 Add failing test case covering online ID reset on save
This test scene passes at e58e1151f3 and
fails at current master, due to an inadvertent regression caused by
e72f103c17.

As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
5c066c40b1 Merge pull request #23342 from peppy/cursor-ripples
Implement cursor ripples
2023-05-01 10:34:04 +02:00
d98aa60efc Merge branch 'master' into cursor-ripples 2023-05-01 09:37:50 +02:00
ff29189e89 Add custom cursor-ripple to cover skinnability in test 2023-05-01 09:33:37 +02:00
0a70734331 Adjust ripple size with cursor scale (including CS) 2023-05-01 14:43:49 +09:00
5cbfefbcb4 Adjust metrics of default ripple to match stable default better 2023-05-01 13:29:50 +09:00
b8ae508639 Fix incorrect starting scale for ripples 2023-05-01 13:09:00 +09:00
7cedbca9be Merge branch 'master' into multiplier-doesnt-update-with-preset-mod 2023-04-30 17:36:00 +02:00
2e3daf0a54 Fix leak of ModSettingChangeTracker instances
The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can
in some instances run recursively. This is most heavily leaned on in
scenarios where `SelectedMods` is updated by an external component. In
such cases, the mod select overlay needs to replace the mod instances
received externally with mod instances which it owns, so that the changes
made on the overlay can propagate outwards.

This in particular means that prior to this commit, it was possible to
encounter the following scenario:

	modSettingChangeTracker?.Dispose();
	updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
	                               // therefore causing a recursive call

		modSettingChangeTracker?.Dispose();
		// inner call continues
		modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

	// outer call continues
	modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

This leaks one `modSettingChangeTracker` instance from the inner call,
which is never disposed.

To avoid this, move the disposal to the same side of the recursion that
the creation happens on, changing the call pattern to:

	updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
	                               // therefore causing a recursive call

		modSettingChangeTracker?.Dispose();
		// inner call continues
		modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

	modSettingChangeTracker?.Dispose();
	// outer call continues
	modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);

which, while slightly wasteful, does not cause any leaks.

The solution is definitely suboptimal, but addressing this properly
would entail a major rewrite of the mod instance management in the mods
overlay, which is probably not the wisest move to make right now.
2023-04-30 17:31:41 +02:00
d35355970f Add test case covering failure scenario 2023-04-30 17:23:45 +02:00
72b472a756 Change default scaling and add note about legacy cursor-ripple scale 2023-04-30 14:48:03 +09:00
6a62949fcd Fix positioning and rewinding support for ripples 2023-04-30 14:48:03 +09:00
c994adfc22 Add pooling support for ripples 2023-04-30 14:48:03 +09:00
a4ae9e409b Implement ripples (legacy and default) 2023-04-30 14:48:03 +09:00
b39a9d816e Add basic structural requirements for cursor ripples 2023-04-30 14:48:03 +09:00
6a04708a7e Merge pull request #23332 from peppy/fix-exclusive-fullscreen-detection
Fix exclusive fullscreen notice showing false positives for new renderers
2023-04-29 15:30:04 +02:00
646d4965b9 Merge branch 'master' into fix-exclusive-fullscreen-detection 2023-04-29 14:39:34 +02:00
119687cf6e Merge pull request #23329 from rltn/clickable-country-name-in-profile
Clickable country name in profile
2023-04-29 14:19:13 +09:00
8df5410946 Merge pull request #23333 from Cootz/add-events-for-loading-screen
Fix editor potentially leaving a dangling beatmap if exiting during load too fast
2023-04-29 11:57:24 +09:00
602a276884 Merge branch 'master' into add-events-for-loading-screen 2023-04-29 11:05:45 +09:00
2643100644 Add xmldoc to new test mentioning failure rate and general purpose 2023-04-29 11:05:10 +09:00
32f8c674f4 Extract beatmap retrieval method for more legibility 2023-04-29 11:01:29 +09:00
a6f0186112 Improve legibility and code quality of new test 2023-04-29 10:51:56 +09:00
428b5fad3c Rename test scene to explicitly mention navigation testing 2023-04-29 10:51:56 +09:00
d9b3c97179 Fix testing 2023-04-29 10:29:33 +09:00
c5357d30ab Add test 2023-04-29 10:29:33 +09:00
607a04ae73 Fix the issue 2023-04-29 10:29:33 +09:00
2d6c0d2900 use of Child instead of Children 2023-04-28 19:24:07 +03:00
6929be49b7 Change condition for exclusive fullscreen notice to only show when using the correct renderer
This avoids the notice showing when running on windows, but using the
newer renderers (where the underlying logic hasn't been tested properly
and can result in false-positives).

Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more
correct implementation.
2023-04-28 22:36:30 +09:00
4b0ee392f6 add OsuHoverContainer 2023-04-28 05:48:54 +03:00
17730f05bc remove UpdateableCountryText 2023-04-28 05:47:05 +03:00
6308bef0c8 Merge pull request #23325 from sw1tchbl4d3r/taiko_aspect_limit
Fix extreme aspect ratios in taiko
2023-04-28 09:39:53 +09:00
4d144cd5b5 clearing the code 2023-04-28 02:06:13 +03:00