202a603d72
Merge branch 'master' into distance-snap-grid-current-tiume
2022-05-07 08:49:30 +02:00
dd63657dfb
Merge pull request #18065 from huoyaoyuan/code-style
...
Enforce code style analysis shipped with .NET SDK
2022-05-07 14:58:19 +09:00
2dd9899cd7
Merge pull request #18126 from bdach/mod-overlay/fix-broken-mod-reference-logic
...
Fix several issues with new mod select reference replacement logic
2022-05-07 14:36:05 +09:00
34237fd05e
Merge pull request #18125 from frenzibyte/fix-overlay-horizontal-offset-overlays
...
Fix side overlay offset not affecting fullscreen overlays
2022-05-07 14:02:22 +09:00
ce14fddcb2
Use above-1 offset instead for more correct feeling parallax
2022-05-07 14:02:07 +09:00
71758390b5
Fix time based distance grid alpha not correctly accounting for distance spacing multiplier
2022-05-07 13:37:36 +09:00
8c73ed7207
Fix sequence equality check not using reference comparison
2022-05-06 21:47:04 +02:00
621f746789
Do not modify selected mods through panel state change during external update
2022-05-06 21:47:04 +02:00
c199b8fcb6
Simplify state management in ModColumn
...
Bad sign when you can't follow your own code.
All of the various state changing methods were flattened into one
because it was too hard to follow what was calling what and why.
2022-05-06 21:46:16 +02:00
380cd1e036
Add test coverage for lack of customisation on free mod select
2022-05-06 21:35:22 +02:00
8080f784fd
Apply offset by a factor of 0.8x from screen offset
2022-05-06 22:20:09 +03:00
049fed42e2
Fix side overlay offsetting not affecting fullscreen overlays
2022-05-06 21:42:20 +03:00
723fce8174
Move inverting value to happen outside clamp
...
Looks to have no effect, but makes sense to happen outside instead.
2022-05-06 18:54:13 +03:00
d78f1d158d
Use GetEndTime() instead of StartTime
...
Companion to
246479bf34
2022-05-06 18:51:35 +03:00
112496204d
Make nested class private
2022-05-06 18:50:28 +03:00
404798395c
Merge pull request #18120 from peppy/fix-toolbox-expansion
...
Fix user-contracted toolbox groups in editor incorrectly expanding on hover
2022-05-06 18:44:09 +03:00
3077d398ef
Merge branch 'master' into distance-snap-grid-current-tiume
2022-05-06 18:20:22 +03:00
1409f8ca96
Merge branch 'master' into fix-toolbox-expansion
2022-05-06 18:00:01 +03:00
bda57dd970
Merge pull request #18122 from bdach/mod-overlay/leftover-mod-area-border
...
Remove leftover border thickness spec in mod settings area
2022-05-06 23:58:35 +09:00
f222affe88
Merge branch 'master' into fix-toolbox-expansion
2022-05-06 17:54:14 +03:00
a7c7fc745b
Merge pull request #18103 from peppy/distance-snapping-test
...
Fix distance snapping grid providing incorrect time values for non-1.0x spacing
2022-05-06 17:53:44 +03:00
144d33f0d2
Merge branch 'master' into distance-snapping-test
2022-05-06 17:29:27 +03:00
9961545147
Merge pull request #18121 from peppy/editor-drag-box
...
Fix editor drag box visuals
2022-05-06 15:52:26 +02:00
c533c93ffd
Remove leftover border thickness spec in mod settings area
...
Was never supposed to be there, it was a vestige of a previous design
iteration that went by unnoticed.
2022-05-06 15:34:49 +02:00
56fa5c9db1
Merge branch 'master' into editor-drag-box
2022-05-06 15:22:39 +02:00
29a3ab7e7a
Halve drag box padding
...
Allows the drag box borders to collapse in on themselves to a single
line if the drag selection has zero width or height.
2022-05-06 15:21:35 +02:00
b119726b28
Reword test step
2022-05-06 15:38:38 +03:00
e527574ede
Merge branch 'master' into fix-toolbox-expansion
2022-05-06 13:47:36 +02:00
19297375e2
Update tests to reflect new expected behaviour
2022-05-06 13:47:13 +02:00
98eab9668d
Merge pull request #18119 from bdach/mod-overlay/broken-hover
...
Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select
2022-05-06 20:42:33 +09:00
fad1f727bb
Fix editor drag box visuals
2022-05-06 20:34:44 +09:00
e9d52aa954
Remove not-accessed field
2022-05-06 13:09:37 +02:00
a915b7333c
Remove unused using directive
2022-05-06 13:08:54 +02:00
cfcd64873c
Merge pull request #18069 from peppy/exit-multiplayer-is-dangerous
...
Make exiting multiplayer a dangerous operation, requiring hold
2022-05-06 20:00:41 +09:00
839f9373b2
Merge branch 'master' into exit-multiplayer-is-dangerous
2022-05-06 12:57:13 +02:00
3e75e7184a
Merge pull request #18118 from peppy/fix-toolbox-expand-coi
...
Fix toolbox expand being interrupted by gaps between groups
2022-05-06 12:47:02 +02:00
88c190f3e3
Change colour denoting expanded state to be gray rather than yellow
...
I always found the yellow colour very non-descript in this case. Gray
seems to work better?
2022-05-06 19:45:17 +09:00
b432885e5f
Tidy up ordering of SettingsToolboxGroup
2022-05-06 19:39:09 +09:00
59add66632
Remove unnecessary autosize workaround (was fixed long ago)
2022-05-06 19:39:00 +09:00
949e30c4b4
Remove auto-expansion of individual toolbox groups when parent expanding container expands
2022-05-06 19:36:41 +09:00
08fd0ea086
Fix click-to-return container still handling hover when inactive
2022-05-06 12:28:53 +02:00
c6bc6be128
Fix toolbox expand being interrupted by gaps between groups
2022-05-06 19:06:40 +09:00
daed42513e
Fix outdated test asserts
2022-05-06 18:44:25 +09:00
8f217d1e97
Add failing test case for broken hover behaviour
2022-05-06 11:37:50 +02:00
69592722f8
Highlight distance snap grid rings that are close to the current time value
2022-05-06 18:30:46 +09:00
09139ef9f4
Merge pull request #18116 from peppy/guest-is-system-user
...
Mark `GuestUser` as system user via `Id` for now
2022-05-06 18:13:03 +09:00
118e58888b
Rename incorrectly named variable (radius is not diameter)
2022-05-06 17:51:51 +09:00
319867f73c
Mark GuestUser as system user via Id for now
...
Should resolve https://github.com/ppy/osu/issues/18105 .
Checking through usages, it doesn't immediately look like this will
regress any other scenarios.
2022-05-06 17:37:46 +09:00
37cbc79283
Fix clamping logic to always clamp to the last displayed tick
2022-05-06 17:09:38 +09:00
684fef7f8c
Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation
2022-05-06 17:09:02 +09:00
