Commit Graph

39070 Commits

Author SHA1 Message Date
220eef0351 Remove overcomplicated date logic in MonthPanel 2021-05-10 17:00:18 +03:00
fbf8b198cd Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-10 16:47:15 +03:00
9027a09d6d Merge pull request #12688 from gagahpangeran/osu-markdown
Implement osu!-styled Markdown container
2021-05-10 20:39:56 +09:00
e7355da201 Merge branch 'master' into osu-markdown 2021-05-10 20:02:04 +09:00
a229ef5c13 Merge pull request #12708 from peppy/remove-hud-overlay-unused-pieces
Remove now unnecessary binding logic from `HUDOverlay`
2021-05-10 17:15:59 +09:00
fa872858b5 Remove unnecessary check 2021-05-10 16:40:06 +09:00
0d243be457 CI fixes 2021-05-10 10:07:43 +03:00
4b97224932 Implement NewsSideBar component 2021-05-10 09:53:52 +03:00
97e72849af Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
7971a2ef48 Implement MonthPanel component 2021-05-10 08:47:00 +03:00
78952c07b0 Merge branch 'master' into remove-hud-overlay-unused-pieces 2021-05-10 14:39:32 +09:00
5a6c7c30e0 Merge pull request #12707 from peppy/skin-components-bind-outwards-health
Update `HealthDisplay` components to use DI to attach data source
2021-05-10 14:39:17 +09:00
149f2bcc1c Merge pull request #12701 from ekrctb/framed-auto-generator
Factor out common logic of frame-based replay `AutoGenerator`
2021-05-10 13:43:53 +09:00
7ca3e13712 Implement basic years panel 2021-05-10 07:43:01 +03:00
35a7226cd8 Add newline 2021-05-10 13:41:04 +09:00
3c3500d070 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-10 12:23:18 +09:00
1d38fa29b5 Remove unused using statement 2021-05-10 12:23:04 +09:00
1bbbe80420 Fix missing instances of HealthProcessor caching 2021-05-10 12:22:24 +09:00
132bb7832d Fix some regressions when updating test scenes 2021-05-10 12:06:33 +09:00
b274fdf20d Merge branch 'master' into skin-components-bind-outwards-health 2021-05-10 11:13:44 +09:00
002622a92c Merge pull request #12732 from Joehuu/ss-sort-by-source
Add ability to sort by source in song select
2021-05-10 10:10:56 +09:00
0ff0353e13 Merge pull request #12734 from Susko3/make-max-volume-feel-better
Make adjusting volume to max feel better
2021-05-10 09:35:20 +09:00
ab6239fd5f change math for displaying volume "MAX" 2021-05-10 00:51:58 +02:00
a71e52da4c Fix enum ordering after adding source 2021-05-09 15:39:59 -07:00
a21718f1cd Move source case to a better spot 2021-05-09 14:26:45 -07:00
8964d51de9 Add ability to sort by source in song select 2021-05-09 14:10:38 -07:00
2bcf1ed306 Merge pull request #12715 from Cublibre/fix-early-exit-crash
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
a480e530fb Merge pull request #12706 from peppy/skin-components-bind-outwards-accuracy
Update `AccuracyCounter` components to use DI to attach data source
2021-05-09 20:10:23 +09:00
eb716455b7 Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
a669f90ae7 Merge pull request #12727 from EVAST9919/news-fix
Hide "Show More" button in news overlay if returned cursor is null
2021-05-09 18:50:35 +09:00
879c08e666 Use UntilStep instead of Assert to check button visibility 2021-05-09 10:06:36 +03:00
f0c1784d05 Use FirstOrDefault instead of First 2021-05-09 09:12:37 +03:00
8868439ce4 Another approach to fix test scene failure 2021-05-09 06:49:12 +03:00
0818deac17 Fix potential test scene failure due to showMoreButton not being loaded in time 2021-05-09 06:06:34 +03:00
ae2b5a0806 Actually test that player was exited 2021-05-08 22:42:14 -04:00
dde9fd28e6 Hide ShowMore button if there's nothing to load 2021-05-09 04:57:24 +03:00
342c5a5938 Add tests to indicate the issue 2021-05-09 04:49:40 +03:00
0e91e6a155 Merge pull request #12724 from bdach/remove-current-from-legacyscorecounter
Remove vestigial `Current` reimplementation from `LegacyScoreCounter`
2021-05-09 05:01:53 +09:00
ea066cddc9 Merge pull request #12722 from bdach/fix-beatmap-listing-temporary-files
Fix temporary files from beatmap downloads not being cleaned up
2021-05-09 04:51:48 +09:00
67cea6e762 Remove explicit binding to accuracy counter from overlay 2021-05-08 21:38:06 +02:00
efb9164658 Restore previous test scene logic 2021-05-08 21:35:12 +02:00
0bc6a026eb Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
c3bf6a0287 Remove weird vestigial Current reimplementation
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
b4a9c7095f Merge pull request #12705 from peppy/skin-components-bind-outwards-score-display 2021-05-08 21:00:29 +02:00
dec5400c0a Merge branch 'master' into skin-components-bind-outwards-score-display 2021-05-08 19:58:19 +02:00
d5efab0648 Merge pull request #12670 from peppy/skin-components-bind-outwards 2021-05-08 19:57:51 +02:00
9e0ea494fd Merge branch 'master' into skin-components-bind-outwards 2021-05-08 19:04:56 +02:00
25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
fe86ee629e Fix temp files from beatmap listing imports not being cleaned up
As reported in #12718, it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.

The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.

On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.

As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
13bd3e95a9 Merge pull request #12698 from peppy/fix-editor-slider-input-handling 2021-05-08 17:08:48 +02:00