Commit Graph

37592 Commits

Author SHA1 Message Date
2267aa1ac2 Add ability to retrieve serialisable drawables for specific rulesets 2023-02-17 18:24:05 +09:00
ffb99364b9 Ensure skin default component layouts only apply to global layout for now 2023-02-17 18:24:05 +09:00
9793774377 Update SkinDeserialisationTest to work with new serialisation structure 2023-02-17 16:22:48 +09:00
6b3652f567 Change serialisation format of skin layouts to allow more flexibility
Also adds per-ruleset storage for each container type.
2023-02-17 14:19:19 +09:00
9685fb2114 Always return a non-null container for SkinComponentsContainerLookups 2023-02-17 14:19:19 +09:00
4cc6664dc7 Add optional ruleset identifier to SkinComponentsContainerLookup 2023-02-17 14:19:19 +09:00
1a63ca9ece Add xmldoc around SkinComponentsContainerLookup 2023-02-17 14:18:05 +09:00
cb7df7282b Apply NRT to SerialisedDrawableInfo 2023-02-16 20:01:59 +09:00
81dcc105a9 Rename left-over skinnable naming in SerialisedDrawableExtensions 2023-02-16 15:34:41 +09:00
76f7accd13 Standardise all local SkinComponentsContainerLookup variables to containerLookup 2023-02-16 15:33:56 +09:00
eea0cd3cf8 Reword xmldoc on ISerialisableDrawable to make less skin-centric 2023-02-16 15:31:35 +09:00
0b25f7baeb Reword and fix typos in some new xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-16 15:27:30 +09:00
768eea1ea8 Merge branch 'master' into skinnable-clean-up-documentation 2023-02-15 21:26:11 +01:00
1d5d34ba0e Merge pull request #22647 from peppy/remove-target-component-container
Simplify and rename `SkinnableTargetComponentsContainer`
2023-02-15 21:25:49 +01:00
08ed174f61 Change GameplaySkinComponentLookup's generic to always be an enum
And document the class better.
2023-02-15 18:48:14 +09:00
a92e42bb84 Rename SkinnableTargetContainer to SkinComponentsContainer
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
b1cf6d83d8 Move extension methods closer to serialisation classes 2023-02-15 18:37:41 +09:00
e61d2d571c Move the lookup type out of ISserialisableDrawableContainer 2023-02-15 18:37:41 +09:00
a7b47f6503 Rename ISkinnableTarget to ISerialisableDrawableContainer 2023-02-15 18:37:41 +09:00
d159d6b970 Rename ISkinnableDrawable to ISerialisableDrawable 2023-02-15 18:37:41 +09:00
8cb5a51aa7 Add further documentation to skin classes 2023-02-15 18:23:19 +09:00
856efd9fd9 Rename SkinnableDrawableInfo to SerialisedDrawableInfo 2023-02-15 18:23:19 +09:00
9e651a7ca2 Rename SkinnableInfo to SkinnableDrawableInfo 2023-02-15 18:23:17 +09:00
6010dde86e Move SkinnableInfo to better namespace 2023-02-15 18:23:10 +09:00
8bbd00822c Simplify and rename SkinnableTargetComponentsContainer 2023-02-15 17:30:21 +09:00
e71dfd7555 Fix skin export failing if a directory exists with the proposed filename 2023-02-15 16:11:16 +09:00
99b78c63a0 Merge branch 'master' into fix-mania-long-note-regression 2023-02-14 21:25:31 +01:00
e6f0a1dec9 Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-14 17:06:50 +09:00
0217875f3f Merge branch 'master' into SkinSetOnNotificationClick 2023-02-14 16:04:03 +09:00
0ad245e9e0 Rewrite implementation to match other implementations 2023-02-14 16:00:23 +09:00
21429e164f Fix comment grammar 2023-02-14 15:55:32 +09:00
PC
ca2603324c Change present from skin selection tab to SkinCollection.First() 2023-02-14 09:43:40 +03:00
ea624b8ad0 Reset preview track when stopping instead 2023-02-13 22:39:34 -08:00
PC
9064391226 Use ChildrenOfType instead of linq 2023-02-14 08:24:03 +03:00
51d4ae5241 Merge branch 'master' into footer_V2_implementation 2023-02-14 14:00:53 +09:00
f0ebb920b9 Make Actions nullable 2023-02-14 13:54:00 +09:00
24a5a1061f Fix OsuClickableContainer sounds not being blocked by nested drawables 2023-02-13 15:36:17 -08:00
PC
f8f485e4c8 Move PresentSkinsImport to OsuGame. Replace switch with if statement 2023-02-14 02:29:50 +03:00
5006dbe3db Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-14 00:07:02 +01:00
939144fb6c Merge pull request #22628 from EVAST9919/letterbox-no-containers
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
7f7e72705f Fix beatmap card song preview progress sometimes showing past progress for one frame 2023-02-13 14:15:37 -08:00
ae9a17d76b Add offset to FooterButtonV2.cs shadow 2023-02-13 22:20:41 +01:00
be52d0a60c Add note explaining shadow opacity
pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`
2023-02-13 22:18:34 +01:00
61584ba63c Fix corner_radius missing in some parts of FooterButtonV2.cs.
Adjust shadow radius value to 5 to match figma.
2023-02-13 22:15:29 +01:00
6e6421caea Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
PC
10ab228d76 Improve xml doc 2023-02-13 22:47:29 +03:00
PC
46b13f2565 Improve code quality 2023-02-13 22:44:11 +03:00
PC
637b07efe6 Remove Resolved attribute 2023-02-13 22:36:51 +03:00
PC
a22a36bfe0 Add navigation to skin settings on multiple import 2023-02-13 20:31:09 +03:00
2dee783401 Remove not needed containers 2023-02-13 15:14:25 +03:00